Merge pull request #24 from mudbugmedia/update-penthouse-1.0

Update penthouse 1.3

Author: michael-misshore

README.md

@@ -2,22 +2,32 @@
 
 Only load the CSS you need for the initial viewport in Rails!
 
-This gem give you the ability to load only the CSS you *need* on an initial page view. This gives you blazin' fast rending as there's no initial network call to grab your application's CSS.
+This gem gives you the ability to load only the CSS you *need* on an initial page view. This gives you blazin' fast rending as there's no initial network call to grab your application's CSS.
 
 This gem assumes that you'll load the rest of the CSS asyncronously. At the moment, the suggested way is to use the [loadcss-rails](https://github.com/michael-misshore/loadcss-rails) gem.
 
 This gem uses [Penthouse](https://github.com/pocketjoso/penthouse) to generate the critical CSS.
 
-## Upgrading to the Latest Release
+## Dependency Requirements for / Upgrading to the Latest Release
 
-Upgrade instructions from each version are included below.
+### For 1.0.0 or later
+To maintain the latest version of Penthouse, this gem depends on NodeJS and NVM to be installed on the system.
+
+### For 2.0.0 or later
+This gem may require additional packages to be installed to run Chrome headless. Per the Penthouse documentation, this may be all you need:
+
+```
+sudo apt-get install libnss3
+```
+
+However, more packages may need to be installed depending on your OS distribution which can be found via [this answer](https://github.com/GoogleChrome/puppeteer/issues/404#issuecomment-323555784)
 
 ## Installation
 
-Add `critical-path-css-rails` to your Gemfile:
+After reviewing the dependency requirements, add `critical-path-css-rails` to your Gemfile:
 
 ```
-gem 'critical-path-css-rails', '~> 1.0.1'
+gem 'critical-path-css-rails', '~> 2.3.0'
 ```
 
 Download and install by running:
@@ -110,9 +120,6 @@ Careful use of these methods allows the developer to generate critical path CSS
 
 A user can use these methods to [dynamically generate critical path CSS](https://gist.github.com/taranda/1597e97ccf24c978b59aef9249666c77) without using the `rake critical_path_css:generate` rake task and without hardcoding the application's routes into `config/critical_path_css.yml`.  See [this Gist](https://gist.github.com/taranda/1597e97ccf24c978b59aef9249666c77) for an example of such an implementation.
 
-## Upgrading from version 0.X.X to 1.0.0
-To maintain the latest version of Penthouse, this gem now depends on NodeJS and NVM to be installed on the system.
-
 ## Upgrading from a version earlier than 0.3.0
 
 The latest version of Critcal Path CSS Rails changes the functionality of the `generate` method.  In past versions,
@@ -124,10 +131,10 @@ Developers upgrading from versions prior to 0.3.0 will need to replace `Critical
 rails generate critical_path_css:install
 ```
 
-Answer 'Y' when prompted to overwrite `critical_path_css.rake`.  However, overwriting `critical_path_css.yml` is not necessary and not recommended.
+Answer 'Y' when prompted to overwrite `critical_path_css.rake`.  However, overwriting `critical_path_css.yml` is not recommended nor necessary.
 
 
-## Testing
+## Testing / Development
 
 This gem is to be tested inside of docker/docker-compose. [Combustion](https://github.com/pat/combustion), alongside rspec-rails and capybara, are the primary components for testing. To run the test, you'll need to have [Docker](https://docs.docker.com/engine/installation) installed. Once installed, run the following commands in the gem's root to build, run, and shell into the docker container.
 
@@ -152,8 +159,6 @@ major version bump = major-level updates to critical-path-css-rails, Penthouse,
 
 ## Contributing
 
-Feel free to open an issue ticket if you find something that could be improved. A couple notes:
-
-* If the Penthouse.js script is outdated (i.e. maybe a new version of Penthouse.js was released yesterday), feel free to open an issue and prod us to get that thing updated. However, for security reasons, we won't be accepting pull requests with updated Penthouse.js script.
+Feel free to open an issue ticket if you find something that could be improved.
 
 Copyright Mudbug Media and Michael Misshore, released under the MIT License.

docker/ruby/Dockerfile

@@ -4,6 +4,9 @@ FROM ruby:2.5.0
 RUN curl -sL https://deb.nodesource.com/setup_8.x | bash -
 RUN apt-get update && apt-get install -y build-essential libpq-dev nodejs npm
 
+# Install Penthouse JS Dependencies
+RUN apt-get install -y libpangocairo-1.0-0 libx11-xcb1 libxcomposite1 libxcursor1 libxdamage1 libxi6 libxtst6 libnss3 libcups2 libxss1 libxrandr2 libgconf2-4 libasound2 libatk1.0-0 libgtk-3-0
+
 RUN npm cache clean -f
 RUN npm install -g n
 RUN n 8.9.3

docker/ruby/startup.dev

@@ -1,5 +1,6 @@
 #!/bin/bash
 
 bundle check || bundle install
+bundle update critical-path-css-rails
 
 bundle exec rackup --host 0.0.0.0

lib/critical_path_css/css_fetcher.rb

@@ -44,11 +44,6 @@ def css_for_route(route)
         'renderWaitTime' => 100,
         # set to false to load (external) JS (default: true)
         'blockJSRequests' => true,
-        # see `phantomjs --help` for the list of all available options
-        'phantomJsOptions' => {
-          'ignore-ssl-errors' => true,
-          'ssl-protocol' => 'tlsv1'
-        },
         'customPageHeaders' => {
           # use if getting compression errors like 'Data corrupted':
           'Accept-Encoding' => 'identity'

lib/critical_path_css/rails/version.rb

@@ -1,5 +1,5 @@
 module CriticalPathCSS
   module Rails
-    VERSION = '1.0.1'.freeze
+    VERSION = '2.3.0'.freeze
   end
 end