Skip to content

Commit f947308

Browse files
committed
expose property doesn't work with fullPaths enabled (fixes browserify#850)
1 parent 691efa3 commit f947308

File tree

5 files changed

+30
-0
lines changed

5 files changed

+30
-0
lines changed

index.js

+5
Original file line numberDiff line numberDiff line change
@@ -597,6 +597,11 @@ Browserify.prototype._label = function (opts) {
597597
if (row.indexDeps) row.deps = row.indexDeps || {};
598598

599599
Object.keys(row.deps).forEach(function (key) {
600+
if (self._expose[key]) {
601+
row.deps[key] = key;
602+
return;
603+
}
604+
600605
var afile = path.resolve(path.dirname(row.file), key);
601606
var rfile = '/' + path.relative(basedir, afile);
602607
if (self._external.indexOf(rfile) >= 0) {

test/entry/needs_three.js

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
require("three");

test/entry/package.json

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"browser": {
3+
"three": "./three.js"
4+
}
5+
}

test/entry/three.js

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
module.exports = 3;

test/full_paths.js

+18
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
var unpack = require('browser-unpack');
22
var browserify = require('../');
33
var test = require('tap').test;
4+
var vm = require('vm');
45

56
var deps = [
67
__dirname + '/entry/main.js',
@@ -37,3 +38,20 @@ test('fullPaths disabled', function (t) {
3738
});
3839
});
3940
});
41+
42+
test('fullPaths enabled, with custom exposed dependency name', function (t) {
43+
t.plan(1);
44+
45+
var b = browserify({
46+
entries: [__dirname + '/entry/needs_three.js'],
47+
fullPaths: true
48+
});
49+
50+
b.require(__dirname + '/entry/three.js', { expose: 'three' });
51+
52+
b.bundle(function (err, src) {
53+
t.doesNotThrow(function () {
54+
vm.runInNewContext(src, { console: console, t: t });
55+
});
56+
});
57+
});

0 commit comments

Comments
 (0)