Skip to content

Commit 4441bf0

Browse files
author
Marek Młynarski
committed
BUG#37058855 Link to external blog returned in upgrade checker's scan
A doc link for zeroDates check pointed to an extenral log - replaced with proper mysql documentation links. Change-Id: I5c6639a5d521fcabc8feb986f9fb1fd5de753af5
1 parent 7560a27 commit 4441bf0

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

res/upgrade_checker/upgrade_checker.msg

+4-1
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,10 @@ https://mysqlserverteam.com/new-defaults-in-mysql-8-0/
238238
# may not work correctly in the future.
239239

240240
* zeroDatesCheck.docLink
241-
https://lefred.be/content/mysql-8-0-and-wrong-dates/
241+
https://dev.mysql.com/doc/refman/8.0/en/datetime.html\n
242+
https://dev.mysql.com/doc/refman/8.0/en/sql-mode.html#sqlmode_no_zero_date\n
243+
https://dev.mysql.com/doc/refman/8.0/en/sql-mode.html#sqlmode_no_zero_in_date
244+
242245

243246
* schemaInconsistencyCheck.title
244247
# Schema inconsistencies resulting from file removal or corruption

unittest/modules/upgrade_check_t.cc

+6-2
Original file line numberDiff line numberDiff line change
@@ -1027,8 +1027,12 @@ TEST_F(MySQL_upgrade_check_test, zero_dates_check) {
10271027

10281028
PrepareTestDatabase("mysql_zero_dates_check_test");
10291029
auto check = Sql_upgrade_check::get_zero_dates_check();
1030-
EXPECT_EQ(0, strcmp("https://lefred.be/content/mysql-8-0-and-wrong-dates/",
1031-
check->get_doc_link()));
1030+
EXPECT_STREQ(
1031+
"https://dev.mysql.com/doc/refman/8.0/en/datetime.html\nhttps://"
1032+
"dev.mysql.com/doc/refman/8.0/en/"
1033+
"sql-mode.html#sqlmode_no_zero_date\nhttps://dev.mysql.com/doc/refman/"
1034+
"8.0/en/sql-mode.html#sqlmode_no_zero_in_date",
1035+
check->get_doc_link());
10321036
EXPECT_NO_ISSUES(check.get());
10331037

10341038
ASSERT_NO_THROW(

0 commit comments

Comments
 (0)