Bug fixes, debug shell, DB dump/import support

- Deleted obsoleted session_recorder.cc code
- Renamed Process_launcher class to Process, removed unnecessary methods,
added support for reading stdout from a thread to allow concurrent writing to stdin
- Added dumpData and importData methods to testutil
- Register testutil module in mysqlshrec
- Fixed bugs in comment handling in SQL statement splitter
- Added utility functions to find a file in PATH
- Bridge support for wrapping functions with std::vector<std::string> params
- Cleanup main()
- Restore original codepage on error in Windows
- Added util code to execute SQL scripts
- Added support for not recording test scripts with _norecord in the
name

Change-Id: Ic1366e7e11e2add3e4867f6f9f488688c05b055f

Author: akojima

CPPLINT.cfg

@@ -1,2 +1,2 @@
 exclude_files=ext/*
-filter=-build/c++11
+filter=-build/c++11,-readability/multiline_comment

mysqlshdk/CMakeLists.txt

@@ -1,4 +1,4 @@
-# Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
+# Copyright (c) 2017, 2018, Oracle and/or its affiliates. All rights reserved.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License, version 2.0,
@@ -21,6 +21,7 @@
 
 include_directories(BEFORE
     ${CMAKE_SOURCE_DIR}
+    ${CMAKE_BINARY_DIR}
     ${CMAKE_SOURCE_DIR}/mysqlshdk/libs
     ${CMAKE_SOURCE_DIR}/mysqlshdk/include
     ${CMAKE_BINARY_DIR}/mysqlshdk/include

mysqlshdk/include/scripting/types_cpp.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2014, 2017, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2014, 2018, Oracle and/or its affiliates. All rights reserved.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License, version 2.0,
@@ -133,6 +133,21 @@ struct Type_info<const std::string &> {
   static std::string default_value() { return std::string(); }
 };
 
+template <>
+struct Type_info<const std::vector<std::string> &> {
+  static std::vector<std::string> to_native(const shcore::Value &in) {
+    std::vector<std::string> strs;
+    shcore::Array_t array(in.as_array());
+    for (size_t i = 0; i < array->size(); ++i) {
+      strs.push_back(array->at(i).as_string());
+    }
+    return strs;
+  }
+  static Value_type vtype() { return shcore::Array; }
+  static const char *code() { return "A"; }
+  static std::vector<std::string> default_value() { return {}; }
+};
+
 template <>
 struct Type_info<const shcore::Dictionary_t&> {
   static shcore::Dictionary_t to_native(const shcore::Value &in) {

mysqlshdk/libs/db/CMakeLists.txt

@@ -1,4 +1,4 @@
-# Copyright (c) 2014, 2017, Oracle and/or its affiliates. All rights reserved.
+# Copyright (c) 2014, 2018, Oracle and/or its affiliates. All rights reserved.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License, version 2.0,
@@ -25,7 +25,6 @@ set(db_SOURCE
     row.h
     column.cc
     charset.cc
-    session_recorder.cc
     uri_parser.cc
     uri_encoder.cc
     connection_options.cc

mysqlshdk/libs/db/mysqlx/mysqlxclient_clean.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2017, 2018, Oracle and/or its affiliates. All rights reserved.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License, version 2.0,
@@ -29,6 +29,7 @@
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wshadow"
 #pragma GCC diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic ignored "-Wsign-compare"
 #elif defined(__clang__)
 #pragma clang diagnostic push
 #pragma clang diagnostic ignored "-Wshadow"

mysqlshdk/libs/db/replay/setup.cc

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2017, 2018, Oracle and/or its affiliates. All rights reserved.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License, version 2.0,
@@ -125,83 +125,6 @@ std::map<std::string, std::string> load_test_case_info() {
   return load_info(current_recording_dir() + "/info");
 }
 
-static std::list<std::weak_ptr<mysqlshdk::db::ISession>> g_open_sessions;
-
-static void on_session_connect(
-    std::shared_ptr<mysqlshdk::db::ISession> session) {
-  // called by session recorder classes when connect is called
-  // adds a weak ptr to the session object along with the stack trace
-  // to a list of open sessions, which will be checked when the test finishes
-  g_open_sessions.push_back(session);
-}
-
-static void on_session_close(std::shared_ptr<mysqlshdk::db::ISession> session) {
-  // called by session recorder classes when close is called
-  for (auto iter = g_open_sessions.begin(); iter != g_open_sessions.end();
-       ++iter) {
-    auto ptr = iter->lock();
-    if (ptr && ptr.get() == session.get()) {
-      g_open_sessions.erase(iter);
-      break;
-    }
-  }
-}
-
-void setup_global_from_env() {
-  int print_traces = 0;
-  if (const char* debug = getenv("TEST_DEBUG")) {
-    print_traces = atoi(debug);
-  }
-  if (const char* mode = getenv("MYSQLSH_RECORDER_MODE")) {
-    if (strcasecmp(mode, "direct") == 0 || !*mode) {
-      set_mode(Mode::Direct, 0);
-      puts("Disabled classic session recording");
-    } else if (strcasecmp(mode, "record") == 0) {
-      set_mode(Mode::Record, print_traces);
-
-      if (!getenv("MYSQLSH_RECORDER_PREFIX")) {
-        printf(
-            "MYSQLSH_RECORDER_MODE set but MYSQLSH_RECORDER_PREFIX is not!\n");
-        return;
-      }
-      set_recording_path_prefix(getenv("MYSQLSH_RECORDER_PREFIX"));
-
-      // Set up hooks for keeping track of opened sessions
-      on_recorder_connect_hook =
-          std::bind(&on_session_connect, std::placeholders::_1);
-      on_recorder_close_hook =
-          std::bind(&on_session_close, std::placeholders::_1);
-
-      printf("Recording classic sessions to %s\n", g_recording_path_prefix);
-    } else if (strcasecmp(mode, "replay") == 0) {
-      set_mode(Mode::Replay, print_traces);
-
-      if (!getenv("MYSQLSH_RECORDER_PREFIX")) {
-        printf(
-            "MYSQLSH_RECORDER_MODE set but MYSQLSH_RECORDER_PREFIX is not!\n");
-        return;
-      }
-      set_recording_path_prefix(getenv("MYSQLSH_RECORDER_PREFIX"));
-      printf("Replaying classic sessions from %s\n", g_recording_path_prefix);
-    } else {
-      printf("Invalid value for MYSQLSH_RECORDER_MODE '%s'\n", mode);
-    }
-  }
-}
-
-void finalize_global() {
-  // Automatically close recording sessions that may be still open
-  on_recorder_connect_hook = {};
-  on_recorder_close_hook = {};
-
-  for (const auto& s : g_open_sessions) {
-    if (auto session = s.lock()) {
-      session->close();
-    }
-  }
-  g_open_sessions.clear();
-}
-
 static Mode g_active_session_injector_mode = Mode::Direct;
 static int g_active_session_print_trace_mode = 0;
 

mysqlshdk/libs/db/replay/setup.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2017, 2018, Oracle and/or its affiliates. All rights reserved.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License, version 2.0,
@@ -40,9 +40,6 @@ namespace replay {
 
 enum class Mode { Direct, Record, Replay };
 
-void setup_global_from_env();
-void finalize_global();
-
 void set_mode(Mode mode, int print_traces);
 
 void set_recording_path_prefix(const std::string& path);