BUG#37712944 Improve jit-executor error handling and remove custom GC

This patch updates the shell integration code of the jit-executor
to match the one used in the MySQL Router where error handling was
improved.

Additionally, removes the unnecessary Garbage Collection logic in
favor of the default provided in the jit-executor.

Change-Id: Idf84e8ea5a1e873d93ab69f706b16b84546b7f3e

Author: rennox

mysqlshdk/scripting/CMakeLists.txt

@@ -53,7 +53,6 @@ if (HAVE_JIT_EXECUTOR)
       polyglot/polyglot_type_conversion.cc
       polyglot/languages/polyglot_language.cc
       polyglot/languages/polyglot_common_context.cc
-      polyglot/languages/polyglot_garbage_collector.cc
       polyglot/polyglot_context.cc
       polyglot/shell_polyglot_common_context.cc
       polyglot/shell_javascript.cc

mysqlshdk/scripting/polyglot/languages/polyglot_common_context.cc

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2024, Oracle and/or its affiliates.
+ * Copyright (c) 2024, 2025, Oracle and/or its affiliates.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License, version 2.0,
@@ -25,6 +25,7 @@
 
 #include "mysqlshdk/scripting/polyglot/languages/polyglot_common_context.h"
 
+#include "mysqlshdk/libs/utils/utils_general.h"
 #include "mysqlshdk/libs/utils/utils_string.h"
 #include "mysqlshdk/scripting/polyglot/native_wrappers/polyglot_collectable.h"
 #include "mysqlshdk/scripting/polyglot/utils/polyglot_error.h"
@@ -34,15 +35,35 @@
 namespace shcore {
 namespace polyglot {
 
-void Polyglot_common_context::initialize() {
-  if (const auto rc = poly_create_isolate(NULL, &m_isolate, &m_thread);
-      poly_ok != rc) {
-    throw Polyglot_generic_error(
-        shcore::str_format("Error creating polyglot isolate: %d", rc));
+void Polyglot_common_context::initialize(
+    const std::vector<std::string> &isolate_args) {
+  if (!isolate_args.empty()) {
+    std::vector<char *> raw_isolate_args = {nullptr};
+    for (const auto &arg : isolate_args) {
+      raw_isolate_args.push_back(const_cast<char *>(arg.data()));
+    }
+
+    auto params = raw_isolate_args.data();
+    poly_isolate_params isolate_params;
+    if (poly_ok != poly_set_isolate_params(&isolate_params,
+                                           isolate_args.size() + 1, params)) {
+      throw Polyglot_generic_error("Error creating polyglot isolate params");
+    }
+
+    if (const auto rc =
+            poly_create_isolate(&isolate_params, &m_isolate, &m_thread);
+        rc != poly_ok) {
+      throw Polyglot_generic_error(
+          shcore::str_format("Error creating polyglot isolate: %d", rc));
+    }
+  } else {
+    if (const auto rc = poly_create_isolate(NULL, &m_isolate, &m_thread);
+        rc != poly_ok) {
+      throw Polyglot_generic_error(
+          shcore::str_format("Error creating polyglot isolate: %d", rc));
+    }
   }
 
-  m_garbage_collector.start(gc_config(), m_isolate);
-
   m_scope = std::make_unique<Polyglot_scope>(m_thread);
 
   if (const auto rc = poly_register_log_handler_callbacks(
@@ -64,11 +85,13 @@ void Polyglot_common_context::finalize() {
 
   m_scope.reset();
 
-  m_garbage_collector.stop();
-
-  if (const auto rc = poly_tear_down_isolate(m_thread); rc != poly_ok) {
-    std::string error{"polyglot error while tearing down the isolate"};
-    log(error.data(), error.size());
+  if (m_isolate && m_thread) {
+    if (const auto rc = poly_detach_all_threads_and_tear_down_isolate(m_thread);
+        rc != poly_ok) {
+      const auto error = shcore::str_format(
+          "Polyglot error while tearing down the isolate: %d", rc);
+      log(error.data(), error.size());
+    }
   }
 
   clean_collectables();

mysqlshdk/scripting/polyglot/languages/polyglot_common_context.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2024, Oracle and/or its affiliates.
+ * Copyright (c) 2024, 2025, Oracle and/or its affiliates.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License, version 2.0,
@@ -30,7 +30,6 @@
 
 #include <memory>
 
-#include "mysqlshdk/scripting/polyglot/languages/polyglot_garbage_collector.h"
 #include "mysqlshdk/scripting/polyglot/native_wrappers/polyglot_collectable.h"
 #include "mysqlshdk/scripting/polyglot/utils/polyglot_scope.h"
 #include "mysqlshdk/scripting/polyglot/utils/polyglot_store.h"
@@ -59,22 +58,20 @@ class Polyglot_common_context {
   Polyglot_common_context() = default;
   virtual ~Polyglot_common_context() = default;
 
-  virtual void initialize();
+  virtual void initialize(const std::vector<std::string> &isolate_args);
   virtual void finalize();
 
   poly_reference engine() const { return m_engine.get(); }
   poly_isolate isolate() const { return m_isolate; }
   poly_thread thread() const { return m_thread; }
 
-  Garbage_collector &garbage_collector() { return m_garbage_collector; }
-
   void clean_collectables();
 
   Collectable_registry *collectable_registry() { return &m_registry; }
 
  protected:
-  poly_isolate m_isolate;
-  poly_thread m_thread;
+  poly_isolate m_isolate = nullptr;
+  poly_thread m_thread = nullptr;
 
  private:
   void init_engine();
@@ -85,11 +82,9 @@ class Polyglot_common_context {
   virtual void flush() = 0;
   virtual void log(const char *bytes, size_t length) = 0;
   virtual poly_engine create_engine() { return nullptr; }
-  virtual Garbage_collector::Config gc_config() { return {}; }
 
   Store m_engine;
   std::unique_ptr<Polyglot_scope> m_scope;
-  Garbage_collector m_garbage_collector;
   Collectable_registry m_registry;
 };