Skip to content

Commit a5761d8

Browse files
committed
Use groupName comment for listers/informers
If present, use the "// +groupName" doc comment as the desired group name when generating listers and informers.
1 parent 6ae80a6 commit a5761d8

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

cmd/libs/go2idl/informer-gen/generators/packages.go

+7
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,13 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
150150
targetGroupVersions = externalGroupVersions
151151
}
152152

153+
// If there's a comment of the form "// +groupName=somegroup" or
154+
// "// +groupName=somegroup.foo.bar.io", use the first field (somegroup) as the name of the
155+
// group when generating.
156+
if override := types.ExtractCommentTags("+", p.DocComments)["groupName"]; override != nil {
157+
gv.Group = clientgentypes.Group(strings.SplitN(override[0], ".", 2)[0])
158+
}
159+
153160
var typesToGenerate []*types.Type
154161
for _, t := range p.Types {
155162
// filter out types which dont have genclient=true.

cmd/libs/go2idl/lister-gen/generators/lister.go

+7
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,13 @@ func Packages(context *generator.Context, arguments *args.GeneratorArgs) generat
106106
internalGVPkg = strings.Join(parts[0:len(parts)-1], "/")
107107
}
108108

109+
// If there's a comment of the form "// +groupName=somegroup" or
110+
// "// +groupName=somegroup.foo.bar.io", use the first field (somegroup) as the name of the
111+
// group when generating.
112+
if override := types.ExtractCommentTags("+", p.DocComments)["groupName"]; override != nil {
113+
gv.Group = clientgentypes.Group(strings.SplitN(override[0], ".", 2)[0])
114+
}
115+
109116
var typesToGenerate []*types.Type
110117
for _, t := range p.Types {
111118
// filter out types which dont have genclient=true.

0 commit comments

Comments
 (0)