Skip to content

Commit a72907b

Browse files
committed
feat: Android recorder reuse
1 parent 193ebed commit a72907b

File tree

2 files changed

+14
-19
lines changed

2 files changed

+14
-19
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nativescript-audio",
3-
"version": "3.4.0",
3+
"version": "3.4.1",
44
"description": "NativeScript plugin to record and play audio.",
55
"main": "audio",
66
"typings": "index.d.ts",

src/android/recorder.ts

+13-18
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,9 @@ export class TNSRecorder implements TNSRecordI {
2626
public start(options: AudioRecorderOptions): Promise<any> {
2727
return new Promise((resolve, reject) => {
2828
try {
29-
let initializing = true;
30-
3129
if (this.recorder) {
3230
// reset for reuse
3331
this.recorder.reset();
34-
initializing = false;
3532
} else {
3633
this.recorder = new MediaRecorder();
3734
}
@@ -67,21 +64,19 @@ export class TNSRecorder implements TNSRecordI {
6764

6865
// Is there any benefit to calling start() before setting listener?
6966

70-
if (initializing) {
71-
// On Error
72-
this.recorder.setOnErrorListener(new android.media.MediaRecorder.OnErrorListener({
73-
onError: (recorder: any, error: number, extra: number) => {
74-
options.errorCallback({ recorder, error, extra });
75-
}
76-
}));
77-
78-
// On Info
79-
this.recorder.setOnInfoListener(new android.media.MediaRecorder.OnInfoListener({
80-
onInfo: (recorder: any, info: number, extra: number) => {
81-
options.infoCallback({ recorder, info, extra });
82-
}
83-
}));
84-
}
67+
// On Error
68+
this.recorder.setOnErrorListener(new android.media.MediaRecorder.OnErrorListener({
69+
onError: (recorder: any, error: number, extra: number) => {
70+
options.errorCallback({ recorder, error, extra });
71+
}
72+
}));
73+
74+
// On Info
75+
this.recorder.setOnInfoListener(new android.media.MediaRecorder.OnInfoListener({
76+
onInfo: (recorder: any, info: number, extra: number) => {
77+
options.infoCallback({ recorder, info, extra });
78+
}
79+
}));
8580

8681
this.recorder.prepare();
8782
this.recorder.start();

0 commit comments

Comments
 (0)