chore: cleanup

Author: farfromrefug

CONTRIBUTING.md

@@ -1,24 +1 @@
-## android typings
 
-```
-java -jar build/libs/dts-generator.jar -skip-declarations -input /Volumes/data/dev/carto/mobile-sdk/dist/android/carto-mobile-sdk.jar
-```
-
-### clean up typings
-
-* regexp: ```/export class .*?JNI {(.|[\r\n])*?}//```
-* regexp: ```/export module .*? {([\t\r\n])*?}//``` twice
-* regexp: ```/declare module com {([\t\r\n])*?}/```
-
-## ios typings
-
-run in the demo app
-```
-TNS_TYPESCRIPT_DECLARATIONS_PATH="$(pwd)/typings" tns build ios --bundle
-```
-
-### clean up typings
-
-* regexp: ```/description\(\): string;//```
-* regexp: ```/hash\(\): number;//```
-* regexp: ```/var:/variant:/```

package.json

@@ -1,7 +1,7 @@
 {
     "name": "nativescript-chart",
     "version": "1.0.0",
-    "description": "Nativescript plugin for Carto Mobile SDK",
+    "description": "Nativescript plugin for Charts",
     "scripts": {
         "tsc": "cpy '**/*.d.ts' '../plugin' --parents --cwd=src && tsc -skipLibCheck",
         "clean": "rimraf ./plugin/**/*.d.ts ./plugin/**/*.js ./plugin/**/*.js.map plugin/node_modules plugin/package-lock.json",

src/charting/renderer/LineChartRenderer.ts

@@ -173,6 +173,8 @@ export class LineChartRenderer extends LineRadarRenderer {
         if (dataSet.getEntryCount() < 1) return false;
         this.mRenderPaint.setStrokeWidth(dataSet.getLineWidth());
         this.mRenderPaint.setPathEffect(dataSet.getDashPathEffect());
+        this.mRenderPaint.setColor(dataSet.getColor());
+        this.mRenderPaint.setStyle(Style.STROKE);
         let result = false;
         switch (dataSet.getMode()) {
             default:
@@ -390,15 +392,10 @@ export class LineChartRenderer extends LineRadarRenderer {
             // result = true;
         }
 
-        this.mRenderPaint.setColor(dataSet.getColor());
-
-        this.mRenderPaint.setStyle(Style.STROKE);
-
         trans.pathValueToPixel(this.linePath);
 
         this.drawPath(c, this.linePath, this.mRenderPaint);
 
-        this.mRenderPaint.setPathEffect(null);
         return result;
     }
 
@@ -420,15 +417,11 @@ export class LineChartRenderer extends LineRadarRenderer {
             // result = true;
         }
 
-        this.mRenderPaint.setColor(dataSet.getColor());
-
-        this.mRenderPaint.setStyle(Style.STROKE);
 
         trans.pathValueToPixel(this.linePath);
 
         this.drawPath(c, this.linePath, this.mRenderPaint);
 
-        this.mRenderPaint.setPathEffect(null);
         return result;
     }
 
@@ -450,10 +443,6 @@ export class LineChartRenderer extends LineRadarRenderer {
             // result = true;
         }
 
-        this.mRenderPaint.setColor(dataSet.getColor());
-
-        this.mRenderPaint.setStyle(Style.STROKE);
-
         if (isAndroid) {
             trans.pathValueToPixel(this.linePath);
             this.drawPath(c, this.linePath, this.mRenderPaint);
@@ -463,7 +452,6 @@ export class LineChartRenderer extends LineRadarRenderer {
             c.drawLines(points, 0, length, this.mRenderPaint, trans.getValueToPixelMatrix());
         }
 
-        this.mRenderPaint.setPathEffect(null);
         return result;
     }