fix: DataSet.getColor fix

farfromrefug · farfromrefug · commit 34b34192b4a6 · 2024-04-26T21:34:38.000+02:00
diff --git a/src/ui-chart/data/BaseDataSet.ts b/src/ui-chart/data/BaseDataSet.ts
@@ -169,11 +169,11 @@ export abstract class BaseDataSet<T extends Entry> implements IDataSet<T> {
      * ###### ###### COLOR GETTING RELATED METHODS ##### ######
      */
 
-    public getColor(index?) {
-        if (index === undefined || this.colors.length === 0) {
-            return this.color;
+    public getColor(index = 0) {
+        if (this.colors?.length > 0) {
+            return this.colors[Math.floor(index) % this.colors.length];
         }
-        return this.colors[Math.floor(index) % this.colors.length];
+        return this.color;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -169,11 +169,11 @@ export abstract class BaseDataSet<T extends Entry> implements IDataSet<T> {`
`169`	`169`	`* ###### ###### COLOR GETTING RELATED METHODS ##### ######`
`170`	`170`	`*/`
`171`	`171`
`172`		`- public getColor(index?) {`
`173`		`- if (index === undefined \|\| this.colors.length === 0) {`
`174`		`- return this.color;`
	`172`	`+ public getColor(index = 0) {`
	`173`	`+ if (this.colors?.length > 0) {`
	`174`	`+ return this.colors[Math.floor(index) % this.colors.length];`
`175`	`175`	`}`
`176`		`- return this.colors[Math.floor(index) % this.colors.length];`
	`176`	`+ return this.color;`
`177`	`177`	`}`
`178`	`178`
`179`	`179`	`/**`