Skip to content

Commit 102a7d0

Browse files
committed
commitlint.sh,CI: use a previous version to fix CI
The last version of commitlint is making our tests fail. My suspicions for why are the following: a) After their massive refactoring migrating to ESM [1], they somehow changed their sub-package @commitlint/types, which I reported as bug 3942 [2]. b) When fixing bug 3942 [3], they updated their dependency to `@types/conventional-commits-parser` to a higher version (from 3.0.6 to 5.0.0). Version 5.0.0 of that package is about 18 days old, however, version 5.0.0 of package `conventional-commits-parser` [4] is 6 months old! But the worst is that the previous version 3.0.6 (which is the one that commitlint was using before this update) was published about 4 years ago! So I'm guessing our plugins were compatible with very old versions of this internal component and now its update has exposed bugs. [1] conventional-changelog/commitlint@3423735 [2] conventional-changelog/commitlint#3942 [3] conventional-changelog/commitlint@5a01f59 [4] https://www.npmjs.com/package/conventional-commits-parser
1 parent b2c1056 commit 102a7d0

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/CI.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ jobs:
9292
npm install --verboase --global yarn
9393
yarn add --dev jest typescript ts-jest @types/jest
9494
- name: Install commitlint dependencies
95-
run: npm install --verbose @commitlint/types
95+
run: npm install --verbose @commitlint/types@18.6.1
9696
- name: Print versions
9797
run: |
9898
git --version
@@ -122,7 +122,7 @@ jobs:
122122
npm install --verbose --global yarn
123123
yarn add --dev jest typescript ts-jest @types/jest ts-node
124124
- name: Install commitlint dependencies
125-
run: npm install --verbose @commitlint/types
125+
run: npm install --verbose @commitlint/types@18.6.1
126126
- name: Run typescript compiler
127127
run: npx tsc
128128
- name: Print versions

commitlint.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ set -euxo pipefail
44
# cd to directory of this script
55
cd "$(dirname "$0")"
66
npm install --verbose
7-
npm install --verbose @commitlint/config-conventional
7+
npm install --verbose @commitlint/config-conventional@18.6.1
88
npx commitlint --version
99
npx commitlint $@

0 commit comments

Comments
 (0)