Skip to content

Commit 7ff93a9

Browse files
committed
Use set literals
1 parent 12c5fcd commit 7ff93a9

12 files changed

+32
-32
lines changed

Diff for: coverage/collector.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class Collector(object):
5555
_collectors = []
5656

5757
# The concurrency settings we support here.
58-
SUPPORTED_CONCURRENCIES = set(["greenlet", "eventlet", "gevent", "thread"])
58+
SUPPORTED_CONCURRENCIES = {"greenlet", "eventlet", "gevent", "thread"}
5959

6060
def __init__(
6161
self, should_trace, check_include, should_start_context, file_mapper,

Diff for: coverage/html.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def __init__(self, cov):
8484
data = self.coverage.get_data()
8585
self.has_arcs = data.has_arcs()
8686
if self.config.show_contexts:
87-
if data.measured_contexts() == set([""]):
87+
if data.measured_contexts() == {""}:
8888
self.coverage._warn("No contexts were measured")
8989
data.set_query_contexts(self.config.report_contexts)
9090

Diff for: coverage/misc.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def new_contract(*args, **kwargs):
7777
def one_of(argnames):
7878
"""Ensure that only one of the argnames is non-None."""
7979
def _decorator(func):
80-
argnameset = set(name.strip() for name in argnames.split(","))
80+
argnameset = {name.strip() for name in argnames.split(",")}
8181
def _wrapper(*args, **kwargs):
8282
vals = [kwargs.get(name) for name in argnameset]
8383
assert sum(val is not None for val in vals) == 1

Diff for: coverage/parser.py

+9-9
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ def first_lines(self, lines):
220220
Returns a set of the first lines.
221221
222222
"""
223-
return set(self.first_line(l) for l in lines)
223+
return {self.first_line(l) for l in lines}
224224

225225
def translate_lines(self, lines):
226226
"""Implement `FileReporter.translate_lines`."""
@@ -520,7 +520,7 @@ class AstArcAnalyzer(object):
520520
def __init__(self, text, statements, multiline):
521521
self.root_node = ast.parse(neuter_encoding_declaration(text))
522522
# TODO: I think this is happening in too many places.
523-
self.statements = set(multiline.get(l, l) for l in statements)
523+
self.statements = {multiline.get(l, l) for l in statements}
524524
self.multiline = multiline
525525

526526
if AST_DUMP: # pragma: debugging
@@ -626,10 +626,10 @@ def _line__Module(self, node):
626626
return 1
627627

628628
# The node types that just flow to the next node with no complications.
629-
OK_TO_DEFAULT = set([
629+
OK_TO_DEFAULT = {
630630
"Assign", "Assert", "AugAssign", "Delete", "Exec", "Expr", "Global",
631631
"Import", "ImportFrom", "Nonlocal", "Pass", "Print",
632-
])
632+
}
633633

634634
@contract(returns='ArcStarts')
635635
def add_arcs(self, node):
@@ -661,7 +661,7 @@ def add_arcs(self, node):
661661
print("*** Unhandled: {}".format(node))
662662

663663
# Default for simple statements: one exit from this node.
664-
return set([ArcStart(self.line_for_node(node))])
664+
return {ArcStart(self.line_for_node(node))}
665665

666666
@one_of("from_start, prev_starts")
667667
@contract(returns='ArcStarts')
@@ -677,7 +677,7 @@ def add_body_arcs(self, body, from_start=None, prev_starts=None):
677677
678678
"""
679679
if prev_starts is None:
680-
prev_starts = set([from_start])
680+
prev_starts = {from_start}
681681
for body_node in body:
682682
lineno = self.line_for_node(body_node)
683683
first_line = self.multiline.get(lineno, lineno)
@@ -890,7 +890,7 @@ def _handle_decorated(self, node):
890890
self.add_arc(last, lineno)
891891
last = lineno
892892
# The body is handled in collect_arcs.
893-
return set([ArcStart(last)])
893+
return {ArcStart(last)}
894894

895895
_handle__ClassDef = _handle_decorated
896896

@@ -984,7 +984,7 @@ def _handle__Try(self, node):
984984
# If there are `except` clauses, then raises in the try body
985985
# will already jump to them. Start this set over for raises in
986986
# `except` and `else`.
987-
try_block.raise_from = set([])
987+
try_block.raise_from = set()
988988
else:
989989
self.block_stack.pop()
990990

@@ -1079,7 +1079,7 @@ def _combine_finally_starts(self, starts, exits):
10791079
if start.cause is not None:
10801080
causes.append(start.cause.format(lineno=start.lineno))
10811081
cause = " or ".join(causes)
1082-
exits = set(ArcStart(xit.lineno, cause) for xit in exits)
1082+
exits = {ArcStart(xit.lineno, cause) for xit in exits}
10831083
return exits
10841084

10851085
@contract(returns='ArcStarts')

Diff for: coverage/phystokens.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ def source_token_lines(source):
8787
8888
"""
8989

90-
ws_tokens = set([token.INDENT, token.DEDENT, token.NEWLINE, tokenize.NL])
90+
ws_tokens = {token.INDENT, token.DEDENT, token.NEWLINE, tokenize.NL}
9191
line = []
9292
col = 0
9393

Diff for: coverage/sqldata.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -784,7 +784,7 @@ def measured_contexts(self):
784784
"""
785785
self._start_using()
786786
with self._connect() as con:
787-
contexts = set(row[0] for row in con.execute("select distinct(context) from context"))
787+
contexts = {row[0] for row in con.execute("select distinct(context) from context")}
788788
return contexts
789789

790790
def file_tracer(self, filename):
@@ -857,7 +857,7 @@ def lines(self, filename):
857857
arcs = self.arcs(filename)
858858
if arcs is not None:
859859
all_lines = itertools.chain.from_iterable(arcs)
860-
return list(set(l for l in all_lines if l > 0))
860+
return list({l for l in all_lines if l > 0})
861861

862862
with self._connect() as con:
863863
file_id = self._file_id(filename)

Diff for: tests/plugin1.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def line_number_range(self, frame):
4444
class FileReporter(coverage.FileReporter):
4545
"""Dead-simple FileReporter."""
4646
def lines(self):
47-
return set([105, 106, 107, 205, 206, 207])
47+
return {105, 106, 107, 205, 206, 207}
4848

4949

5050
def coverage_init(reg, options): # pylint: disable=unused-argument

Diff for: tests/test_collector.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,6 @@ def otherfunc(x):
4545
self.start_import_stop(cov, "f2")
4646

4747
# Double-check that our files were checked.
48-
abs_files = set(os.path.abspath(f) for f in should_trace_hook.filenames)
48+
abs_files = {os.path.abspath(f) for f in should_trace_hook.filenames}
4949
self.assertIn(os.path.abspath("f1.py"), abs_files)
5050
self.assertIn(os.path.abspath("f2.py"), abs_files)

Diff for: tests/test_parser.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -171,11 +171,11 @@ def meth(self):
171171
def func(x=25):
172172
return 26
173173
""")
174-
raw_statements = set([3, 4, 5, 6, 8, 9, 10, 13, 15, 16, 17, 20, 22, 23, 25, 26])
174+
raw_statements = {3, 4, 5, 6, 8, 9, 10, 13, 15, 16, 17, 20, 22, 23, 25, 26}
175175
if env.PYBEHAVIOR.trace_decorated_def:
176176
raw_statements.update([11, 19])
177177
self.assertEqual(parser.raw_statements, raw_statements)
178-
self.assertEqual(parser.statements, set([8]))
178+
self.assertEqual(parser.statements, {8})
179179

180180
def test_class_decorator_pragmas(self):
181181
parser = self.parse_source("""\
@@ -188,8 +188,8 @@ class Bar(object):
188188
def __init__(self):
189189
self.x = 8
190190
""")
191-
self.assertEqual(parser.raw_statements, set([1, 2, 3, 5, 6, 7, 8]))
192-
self.assertEqual(parser.statements, set([1, 2, 3]))
191+
self.assertEqual(parser.raw_statements, {1, 2, 3, 5, 6, 7, 8})
192+
self.assertEqual(parser.statements, {1, 2, 3})
193193

194194
def test_empty_decorated_function(self):
195195
parser = self.parse_source("""\
@@ -463,7 +463,7 @@ def test_missing_line_ending(self):
463463
""")
464464

465465
parser = self.parse_file("normal.py")
466-
self.assertEqual(parser.statements, set([1]))
466+
self.assertEqual(parser.statements, {1})
467467

468468
self.make_file("abrupt.py", """\
469469
out, err = subprocess.Popen(
@@ -476,4 +476,4 @@ def test_missing_line_ending(self):
476476
self.assertEqual(f.read()[-1], ")")
477477

478478
parser = self.parse_file("abrupt.py")
479-
self.assertEqual(parser.statements, set([1]))
479+
self.assertEqual(parser.statements, {1})

Diff for: tests/test_plugins.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -400,12 +400,12 @@ def test_plugin2_with_branch(self):
400400
# have 7 lines in it. If render() was called with line number 4,
401401
# then the plugin will claim that lines 4 and 5 were executed.
402402
analysis = cov._analyze("foo_7.html")
403-
self.assertEqual(analysis.statements, set([1, 2, 3, 4, 5, 6, 7]))
403+
self.assertEqual(analysis.statements, {1, 2, 3, 4, 5, 6, 7})
404404
# Plugins don't do branch coverage yet.
405405
self.assertEqual(analysis.has_arcs(), True)
406406
self.assertEqual(analysis.arc_possibilities(), [])
407407

408-
self.assertEqual(analysis.missing, set([1, 2, 3, 6, 7]))
408+
self.assertEqual(analysis.missing, {1, 2, 3, 6, 7})
409409

410410
def test_plugin2_with_text_report(self):
411411
self.make_render_and_caller()
@@ -553,7 +553,7 @@ def line_number_range(self, frame):
553553
554554
class MyReporter(coverage.FileReporter):
555555
def lines(self):
556-
return set([99, 999, 9999])
556+
return {99, 999, 9999}
557557
558558
def coverage_init(reg, options):
559559
reg.add_file_tracer(Plugin())

Diff for: tests/test_results.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ def test_should_fail_under_invalid_value():
114114

115115

116116
@pytest.mark.parametrize("statements, lines, result", [
117-
(set([1,2,3,4,5,10,11,12,13,14]), set([1,2,5,10,11,13,14]), "1-2, 5-11, 13-14"),
117+
({1,2,3,4,5,10,11,12,13,14}, {1,2,5,10,11,13,14}, "1-2, 5-11, 13-14"),
118118
([1,2,3,4,5,10,11,12,13,14,98,99], [1,2,5,10,11,13,14,99], "1-2, 5-11, 13-14, 99"),
119119
([1,2,3,4,98,99,100,101,102,103,104], [1,2,99,102,103,104], "1-2, 99, 102-104"),
120120
([17], [17], "17"),
@@ -128,8 +128,8 @@ def test_format_lines(statements, lines, result):
128128

129129
@pytest.mark.parametrize("statements, lines, arcs, result", [
130130
(
131-
set([1,2,3,4,5,10,11,12,13,14]),
132-
set([1,2,5,10,11,13,14]),
131+
{1,2,3,4,5,10,11,12,13,14},
132+
{1,2,5,10,11,13,14},
133133
(),
134134
"1-2, 5-11, 13-14"
135135
),

Diff for: tests/test_testing.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ class TestingTest(TestCase):
3333

3434
def test_assert_count_equal(self):
3535
self.assertCountEqual(set(), set())
36-
self.assertCountEqual(set([1,2,3]), set([3,1,2]))
36+
self.assertCountEqual({1,2,3}, {3,1,2})
3737
with self.assertRaises(AssertionError):
38-
self.assertCountEqual(set([1,2,3]), set())
38+
self.assertCountEqual({1,2,3}, set())
3939
with self.assertRaises(AssertionError):
40-
self.assertCountEqual(set([1,2,3]), set([4,5,6]))
40+
self.assertCountEqual({1,2,3}, {4,5,6})
4141

4242

4343
class CoverageTestTest(CoverageTest):

0 commit comments

Comments
 (0)