Skip to content

Commit 3bdd82f

Browse files
committed
update tests to match format in test/skip.js (consistency) see: https://github.com/substack/tape/pull/314/files#r76536364 for tape-testing#312
1 parent ceec1f1 commit 3bdd82f

12 files changed

+54
-83
lines changed

test/array.js

+2-5
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,7 @@ tap.test('array test', function (tt) {
99
var test = tape.createHarness();
1010

1111
test.createStream().pipe(concat(function (rows) {
12-
13-
var rs = rows.toString('utf8').split('\n');
14-
15-
tt.same(rs, [
12+
tt.same(rows.toString('utf8'), [
1613
'TAP version 13',
1714
'# array',
1815
'ok 1 should be equivalent',
@@ -27,7 +24,7 @@ tap.test('array test', function (tt) {
2724
'',
2825
'# ok',
2926
''
30-
]);
27+
].join('\n'));
3128
}));
3229

3330
test('array', function (t) {

test/default-messages.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ tap.test('default messages', function (t) {
99

1010
ps.stdout.pipe(concat(function (rows) {
1111

12-
var rs = rows.toString('utf8').split('\n');
13-
14-
t.same(rs, [
12+
t.same(rows.toString('utf8'), [
1513
'TAP version 13',
1614
'# default messages',
1715
'ok 1 should be truthy',
@@ -29,6 +27,6 @@ tap.test('default messages', function (t) {
2927
'# ok',
3028
'',
3129
''
32-
]);
30+
].join('\n'));
3331
}));
3432
});

test/end-as-callback.js

+22-21
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,23 @@ tap.test("tape assert.end as callback", function (tt) {
66
var test = tape.createHarness({ exit: false })
77

88
test.createStream().pipe(concat(function (rows) {
9-
10-
var rs = rows.toString('utf8');
11-
12-
tt.equal(rs,
13-
'TAP version 13\n'
14-
+ '# do a task and write\n'
15-
+ 'ok 1 null\n'
16-
+ 'ok 2 should be equal\n'
17-
+ '# do a task and write fail\n'
18-
+ 'ok 3 null\n'
19-
+ 'ok 4 should be equal\n'
20-
+ 'not ok 5 Error: fail\n'
21-
+ getStackTrace(rs) // tap error stack
22-
+ '\n'
23-
+ '1..5\n'
24-
+ '# tests 5\n'
25-
+ '# pass 4\n'
26-
+ '# fail 1\n'
27-
)
9+
tt.equal(rows.toString('utf8'), [
10+
'TAP version 13',
11+
'# do a task and write',
12+
'ok 1 null',
13+
'ok 2 should be equal',
14+
'# do a task and write fail',
15+
'ok 3 null',
16+
'ok 4 should be equal',
17+
'not ok 5 Error: fail',
18+
getStackTrace(rows), // tap error stack
19+
'',
20+
'1..5',
21+
'# tests 5',
22+
'# pass 4',
23+
'# fail 1',
24+
''
25+
].join('\n'));
2826
tt.end()
2927
}));
3028

@@ -70,18 +68,21 @@ function fakeAsyncWriteFail(name, cb) {
7068
function getStackTrace(rows) {
7169
var stacktrace = ' ---\n';
7270
var extract = false;
73-
rows.split('\n').forEach(function (row) {
71+
rows.toString('utf8').split('\n').forEach(function (row) {
7472
if (!extract) {
7573
if (row.indexOf('---') > -1) { // start of stack trace
7674
extract = true;
7775
}
7876
} else {
79-
stacktrace += row + '\n';
8077
if (row.indexOf('...') > -1) { // end of stack trace
8178
extract = false;
79+
stacktrace += ' ...';
80+
} else {
81+
stacktrace += row + '\n';
8282
}
8383

8484
}
8585
});
86+
// console.log(stacktrace);
8687
return stacktrace;
8788
}

test/exit.js

+9-17
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@ tap.test('exit ok', function (t) {
66
t.plan(2);
77

88
var tc = function (rows) {
9-
10-
var rs = rows.toString('utf8').split('\n');
11-
t.same(rs, [
9+
t.same(rows.toString('utf8'), [
1210
'TAP version 13',
1311
'# array',
1412
'# hi',
@@ -25,7 +23,7 @@ tap.test('exit ok', function (t) {
2523
'# ok',
2624
'',
2725
''
28-
]);
26+
].join('\n'));
2927
}
3028

3129
var ps = spawn(process.execPath, [ __dirname + '/exit/ok.js' ]);
@@ -39,9 +37,7 @@ tap.test('exit fail', function (t) {
3937
t.plan(2);
4038

4139
var tc = function (rows) {
42-
43-
var rs = rows.toString('utf8').split('\n');
44-
t.same(rs, [
40+
t.same(rows.toString('utf8'), [
4541
'TAP version 13',
4642
'# array',
4743
'ok 1 should be equivalent',
@@ -61,7 +57,7 @@ tap.test('exit fail', function (t) {
6157
'# fail 1',
6258
'',
6359
''
64-
]);
60+
].join('\n'));
6561
};
6662

6763
var ps = spawn(process.execPath, [ __dirname + '/exit/fail.js' ]);
@@ -74,10 +70,8 @@ tap.test('exit fail', function (t) {
7470
tap.test('too few exit', function (t) {
7571
t.plan(2);
7672

77-
var tc = function (rows) {
78-
79-
var rs = rows.toString('utf8').split('\n');
80-
t.same(rs, [
73+
var tc = function (rows) {
74+
t.same(rows.toString('utf8'), [
8175
'TAP version 13',
8276
'# array',
8377
'ok 1 should be equivalent',
@@ -98,7 +92,7 @@ tap.test('too few exit', function (t) {
9892
'# fail 1',
9993
'',
10094
''
101-
]);
95+
].join('\n'));
10296
};
10397

10498
var ps = spawn(process.execPath, [ __dirname + '/exit/too_few.js' ]);
@@ -112,9 +106,7 @@ tap.test('more planned in a second test', function (t) {
112106
t.plan(2);
113107

114108
var tc = function (rows) {
115-
116-
var rs = rows.toString('utf8').split('\n');
117-
t.same(rs, [
109+
t.same(rows.toString('utf8'), [
118110
'TAP version 13',
119111
'# first',
120112
'ok 1 should be truthy',
@@ -133,7 +125,7 @@ tap.test('more planned in a second test', function (t) {
133125
'# fail 1',
134126
'',
135127
'',
136-
]);
128+
].join('\n'));
137129
};
138130

139131
var ps = spawn(process.execPath, [ __dirname + '/exit/second.js' ]);

test/fail.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@ tap.test('array test', function (tt) {
88

99
var test = tape.createHarness({ exit : false });
1010
var tc = function (rows) {
11-
12-
var rs = rows.toString('utf8').split('\n');
13-
tt.same(rs, [
11+
tt.same(rows.toString('utf8'), [
1412
'TAP version 13',
1513
'# array',
1614
'ok 1 should be equivalent',
@@ -29,7 +27,7 @@ tap.test('array test', function (tt) {
2927
'# pass 4',
3028
'# fail 1',
3129
''
32-
]);
30+
].join('\n'));
3331
};
3432

3533
test.createStream().pipe(concat(tc));

test/nested-sync-noplan-noend.js

+2-5
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ tap.test('nested sync test without plan or end', function (tt) {
77

88
var test = tape.createHarness();
99
var tc = function (rows) {
10-
11-
var rs = rows.toString('utf8').split('\n');
12-
var expected = [
10+
tt.same(rows.toString('utf8'), [
1311
'TAP version 13',
1412
'# nested without plan or end',
1513
'# first',
@@ -23,8 +21,7 @@ tap.test('nested sync test without plan or end', function (tt) {
2321
'',
2422
'# ok',
2523
''
26-
]
27-
tt.same(rs, expected);
24+
].join('\n'));
2825
};
2926

3027
test.createStream().pipe(concat(tc));

test/nested.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@ tap.test('array test', function (tt) {
88

99
var test = tape.createHarness();
1010
var tc = function (rows) {
11-
12-
var rs = rows.toString('utf8').split('\n');
13-
tt.same(rs, [
11+
tt.same(rows.toString('utf8'), [
1412
'TAP version 13',
1513
'# nested array test',
1614
'ok 1 should be equivalent',
@@ -30,7 +28,7 @@ tap.test('array test', function (tt) {
3028
'',
3129
'# ok',
3230
''
33-
]);
31+
].join('\n'));
3432
};
3533

3634
test.createStream().pipe(concat(tc));

test/only.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ tap.test('tape only test', function (tt) {
77
var ran = [];
88

99
var tc = function (rows) {
10-
11-
var rs = rows.toString('utf8').split('\n');
12-
tt.deepEqual(rs, [
10+
tt.deepEqual(rows.toString('utf8'), [
1311
'TAP version 13',
1412
'# run success',
1513
'ok 1 assert name',
@@ -20,7 +18,7 @@ tap.test('tape only test', function (tt) {
2018
'',
2119
'# ok',
2220
''
23-
])
21+
].join('\n'));
2422
tt.deepEqual(ran, [ 3 ]);
2523

2624
tt.end()

test/require.js

+4-8
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@ tap.test('requiring a single module', function (t) {
66
t.plan(2);
77

88
var tc = function (rows) {
9-
10-
var rs = rows.toString('utf8').split('\n');
11-
t.same(rs, [
9+
t.same(rows.toString('utf8'), [
1210
'TAP version 13',
1311
'# module-a',
1412
'ok 1 loaded module a',
@@ -23,7 +21,7 @@ tap.test('requiring a single module', function (t) {
2321
'# ok',
2422
'',
2523
''
26-
]);
24+
].join('\n'));
2725
};
2826

2927
var ps = tape('-r ./require/a require/test-a.js');
@@ -37,9 +35,7 @@ tap.test('requiring multiple modules', function (t) {
3735
t.plan(2);
3836

3937
var tc = function (rows) {
40-
41-
var rs = rows.toString('utf8').split('\n');
42-
t.same(rs, [
38+
t.same(rows.toString('utf8'), [
4339
'TAP version 13',
4440
'# module-a',
4541
'ok 1 loaded module a',
@@ -59,7 +55,7 @@ tap.test('requiring multiple modules', function (t) {
5955
'# ok',
6056
'',
6157
''
62-
]);
58+
].join('\n'));
6359
};
6460

6561
var ps = tape('-r ./require/a -r ./require/b require/test-a.js require/test-b.js');

test/skip.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
var tap = require('tap');
21
var test = require('../');
3-
var concat = require('concat-stream');
42
var ran = 0;
53

4+
var concat = require('concat-stream');
5+
var tap = require('tap');
6+
67
tap.test('test SKIP comment', function (assert) {
78
assert.plan(1);
89

@@ -22,7 +23,6 @@ tap.test('test SKIP comment', function (assert) {
2223

2324
var tapeTest = test.createHarness();
2425
tapeTest.createStream().pipe(concat(verify));
25-
2626
tapeTest('skipped', { skip: true }, function (t) {
2727
t.end();
2828
});

test/timeoutAfter.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ tap.test('timeoutAfter test', function (tt) {
77

88
var test = tape.createHarness();
99
var tc = function (rows) {
10-
11-
var rs = rows.toString('utf8').split('\n');
12-
tt.same(rs, [
10+
tt.same(rows.toString('utf8'), [
1311
'TAP version 13',
1412
'# timeoutAfter',
1513
'not ok 1 test timed out after 1ms',
@@ -22,7 +20,7 @@ tap.test('timeoutAfter test', function (tt) {
2220
'# pass 0',
2321
'# fail 1',
2422
''
25-
]);
23+
].join('\n'));
2624
};
2725

2826
test.createStream().pipe(concat(tc));

test/too_many.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@ tap.test('array test', function (tt) {
88

99
var test = tape.createHarness({ exit : false });
1010
var tc = function (rows) {
11-
12-
var rs = rows.toString('utf8').split('\n');
13-
tt.same(rs, [
11+
tt.same(rows.toString('utf8'), [
1412
'TAP version 13',
1513
'# array',
1614
'ok 1 should be equivalent',
@@ -30,7 +28,7 @@ tap.test('array test', function (tt) {
3028
'# pass 5',
3129
'# fail 1',
3230
''
33-
]);
31+
].join('\n'));
3432
};
3533

3634
test.createStream().pipe(concat(tc));

0 commit comments

Comments
 (0)