Skip to content

Update graphql-java to 15.0 #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
claymccoy opened this issue Aug 28, 2020 · 3 comments
Closed

Update graphql-java to 15.0 #118

claymccoy opened this issue Aug 28, 2020 · 3 comments
Assignees

Comments

@claymccoy
Copy link
Contributor

claymccoy commented Aug 28, 2020

This project hasn't had a release in a while and even on master it uses an old version of graphql-java. This becomes an issue when you want to use another project that also depends on graphql-java and it is a newer version.
I'm specifically trying to use this with the graphql-kotlin-schema-generator which uses graphql-java version 15. There is a pretty cool use case to generate the schema from my application's Neo4j object model and then use neo4j-graphql-java to translate the queries to Cypher. But as of right now the two libraries are incompatible because of the different versions.
Is there an issue with updating this dependency? Would it be possible to do that an make a new release?
Thanks,
Clay

@claymccoy
Copy link
Contributor Author

I put together a PR to update graph-java #120. It required a fair amount of changes to both code and unit tests though. You probably want to check over what I did.
This project is great, but the adoption of it will be stifled unless you keep up to date with graphql-java or preferably remove that dependency. The author of it seems to enjoy making backwards-incompatible changes.

@jexp
Copy link
Contributor

jexp commented Aug 30, 2020

Thanks a lot @claymccoy for your feedback and contribution. Much appreciated!!

@Andy2003
Copy link
Collaborator

Andy2003 commented Sep 8, 2020

Resolved by #120
We have created a branch 1.0 and released version 1.0.1 to be compatible with graphql-java version 12

The master will be compatible with graphql-java version 15. We released these changes with version 1.1.0

@Andy2003 Andy2003 closed this as completed Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants