#10520: Restore ability to edit platform NAPALM fields via UI

Author: jeremystretch

netbox/dcim/filtersets.py

@@ -811,7 +811,7 @@ class PlatformFilterSet(OrganizationalModelFilterSet):
 
     class Meta:
         model = Platform
-        fields = ['id', 'name', 'slug', 'description']
+        fields = ['id', 'name', 'slug', 'napalm_driver', 'description']
 
 
 class DeviceFilterSet(NetBoxModelFilterSet, TenancyFilterSet, ContactModelFilterSet, LocalConfigContextFilterSet):

netbox/dcim/forms/bulk_edit.py

@@ -470,6 +470,10 @@ class PlatformBulkEditForm(NetBoxModelBulkEditForm):
         queryset=Manufacturer.objects.all(),
         required=False
     )
+    napalm_driver = forms.CharField(
+        max_length=50,
+        required=False
+    )
     config_template = DynamicModelChoiceField(
         queryset=ConfigTemplate.objects.all(),
         required=False
@@ -481,9 +485,9 @@ class PlatformBulkEditForm(NetBoxModelBulkEditForm):
 
     model = Platform
     fieldsets = (
-        (None, ('manufacturer', 'config_template', 'description')),
+        (None, ('manufacturer', 'config_template', 'napalm_driver', 'description')),
     )
-    nullable_fields = ('manufacturer', 'config_template', 'description')
+    nullable_fields = ('manufacturer', 'config_template', 'napalm_driver', 'description')
 
 
 class DeviceBulkEditForm(NetBoxModelBulkEditForm):

netbox/dcim/forms/bulk_import.py

@@ -347,7 +347,7 @@ class PlatformImportForm(NetBoxModelImportForm):
     class Meta:
         model = Platform
         fields = (
-            'name', 'slug', 'manufacturer', 'config_template', 'description', 'tags',
+            'name', 'slug', 'manufacturer', 'config_template', 'napalm_driver', 'napalm_args', 'description', 'tags',
         )
 
 

netbox/dcim/forms/model_forms.py

@@ -361,15 +361,18 @@ class PlatformForm(NetBoxModelForm):
 
     fieldsets = (
         ('Platform', (
-            'name', 'slug', 'manufacturer', 'config_template', 'description', 'tags',
+            'name', 'slug', 'manufacturer', 'config_template', 'napalm_driver', 'napalm_args', 'description', 'tags',
         )),
     )
 
     class Meta:
         model = Platform
         fields = [
-            'name', 'slug', 'manufacturer', 'config_template', 'description', 'tags',
+            'name', 'slug', 'manufacturer', 'config_template', 'napalm_driver', 'napalm_args', 'description', 'tags',
         ]
+        widgets = {
+            'napalm_args': forms.Textarea(),
+        }
 
 
 class DeviceForm(TenancyForm, NetBoxModelForm):

netbox/dcim/search.py

@@ -172,6 +172,7 @@ class PlatformIndex(SearchIndex):
     fields = (
         ('name', 100),
         ('slug', 110),
+        ('napalm_driver', 300),
         ('description', 500),
     )
 

netbox/dcim/tables/devices.py

@@ -133,11 +133,11 @@ class PlatformTable(NetBoxTable):
     class Meta(NetBoxTable.Meta):
         model = models.Platform
         fields = (
-            'pk', 'id', 'name', 'manufacturer', 'device_count', 'vm_count', 'slug', 'config_template', 'description',
-            'tags', 'actions', 'created', 'last_updated',
+            'pk', 'id', 'name', 'manufacturer', 'device_count', 'vm_count', 'slug', 'config_template', 'napalm_driver',
+            'napalm_args', 'description', 'tags', 'actions', 'created', 'last_updated',
         )
         default_columns = (
-            'pk', 'name', 'manufacturer', 'device_count', 'vm_count', 'description',
+            'pk', 'name', 'manufacturer', 'device_count', 'vm_count', 'napalm_driver', 'description',
         )
 
 

netbox/dcim/tests/test_filtersets.py

@@ -1498,9 +1498,9 @@ def setUpTestData(cls):
         Manufacturer.objects.bulk_create(manufacturers)
 
         platforms = (
-            Platform(name='Platform 1', slug='platform-1', manufacturer=manufacturers[0], description='A'),
-            Platform(name='Platform 2', slug='platform-2', manufacturer=manufacturers[1], description='B'),
-            Platform(name='Platform 3', slug='platform-3', manufacturer=manufacturers[2], description='C'),
+            Platform(name='Platform 1', slug='platform-1', manufacturer=manufacturers[0], napalm_driver='driver-1', description='A'),
+            Platform(name='Platform 2', slug='platform-2', manufacturer=manufacturers[1], napalm_driver='driver-2', description='B'),
+            Platform(name='Platform 3', slug='platform-3', manufacturer=manufacturers[2], napalm_driver='driver-3', description='C'),
         )
         Platform.objects.bulk_create(platforms)
 
@@ -1516,6 +1516,10 @@ def test_description(self):
         params = {'description': ['A', 'B']}
         self.assertEqual(self.filterset(params, self.queryset).qs.count(), 2)
 
+    def test_napalm_driver(self):
+        params = {'napalm_driver': ['driver-1', 'driver-2']}
+        self.assertEqual(self.filterset(params, self.queryset).qs.count(), 2)
+
     def test_manufacturer(self):
         manufacturers = Manufacturer.objects.all()[:2]
         params = {'manufacturer_id': [manufacturers[0].pk, manufacturers[1].pk]}

netbox/dcim/tests/test_views.py

@@ -1591,6 +1591,8 @@ def setUpTestData(cls):
             'name': 'Platform X',
             'slug': 'platform-x',
             'manufacturer': manufacturer.pk,
+            'napalm_driver': 'junos',
+            'napalm_args': None,
             'description': 'A new platform',
             'tags': [t.pk for t in tags],
         }
@@ -1610,6 +1612,7 @@ def setUpTestData(cls):
         )
 
         cls.bulk_edit_data = {
+            'napalm_driver': 'ios',
             'description': 'New description',
         }
 

netbox/templates/dcim/platform.html

@@ -43,10 +43,36 @@ <h5 class="card-header">
             <th scope="row">Config Template</th>
             <td>{{ object.config_template|linkify|placeholder }}</td>
           </tr>
+          <tr>
+            <th scope="row">
+              NAPALM Driver
+              <i
+                class="mdi mdi-alert-box text-warning"
+                data-bs-toggle="tooltip"
+                data-bs-placement="right"
+                title="This field has been deprecated, and will be removed in NetBox v3.6."
+              ></i>
+            </th>
+            <td>{{ object.napalm_driver|placeholder }}</td>
+          </tr>
         </table>
       </div>
     </div>
     {% include 'inc/panels/tags.html' %}
+    <div class="card">
+      <h5 class="card-header">
+        NAPALM Arguments
+        <i
+          class="mdi mdi-alert-box text-warning"
+          data-bs-toggle="tooltip"
+          data-bs-placement="right"
+          title="This field has been deprecated, and will be removed in NetBox v3.6."
+        ></i>
+      </h5>
+      <div class="card-body">
+        <pre>{{ object.napalm_args|json }}</pre>
+      </div>
+    </div>
     {% plugin_left_page object %}
 	</div>
 	<div class="col col-md-6">