Skip to content

Commit 40ad9bf

Browse files
committed
Check for change records only if objects being deleted support change logging
1 parent c99ecc2 commit 40ad9bf

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

netbox/utilities/testing/views.py

+8-6
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
from extras.choices import ObjectChangeActionChoices
1010
from extras.models import ObjectChange
11+
from netbox.models.features import ChangeLoggingMixin
1112
from users.models import ObjectPermission
1213
from utilities.choices import ImportFormatChoices
1314
from .base import ModelTestCase
@@ -350,12 +351,13 @@ def test_delete_object_with_permission(self):
350351
self._get_queryset().get(pk=instance.pk)
351352

352353
# Verify ObjectChange creation
353-
objectchanges = ObjectChange.objects.filter(
354-
changed_object_type=ContentType.objects.get_for_model(instance),
355-
changed_object_id=instance.pk
356-
)
357-
self.assertEqual(len(objectchanges), 1)
358-
self.assertEqual(objectchanges[0].action, ObjectChangeActionChoices.ACTION_DELETE)
354+
if issubclass(instance.__class__, ChangeLoggingMixin):
355+
objectchanges = ObjectChange.objects.filter(
356+
changed_object_type=ContentType.objects.get_for_model(instance),
357+
changed_object_id=instance.pk
358+
)
359+
self.assertEqual(len(objectchanges), 1)
360+
self.assertEqual(objectchanges[0].action, ObjectChangeActionChoices.ACTION_DELETE)
359361

360362
@override_settings(EXEMPT_VIEW_PERMISSIONS=['*'])
361363
def test_delete_object_with_constrained_permission(self):

0 commit comments

Comments
 (0)