Skip to content

Commit 5036020

Browse files
12433 update object list widget to correctly parameterize urls (#12434)
* 12433 update object list widget to correctly parameterize urls * Update netbox/extras/dashboard/widgets.py Co-authored-by: Jeremy Stretch <[email protected]> * 12433 fix indent * Correct per_page query parameter --------- Co-authored-by: Jeremy Stretch <[email protected]>
1 parent 78ec3a6 commit 5036020

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

netbox/extras/dashboard/widgets.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,11 @@ def render(self, request):
229229
htmx_url = reverse(viewname)
230230
except NoReverseMatch:
231231
htmx_url = None
232-
if parameters := self.config.get('url_params'):
232+
parameters = self.config.get('url_params') or {}
233+
if page_size := self.config.get('page_size'):
234+
parameters['per_page'] = page_size
235+
236+
if parameters:
233237
try:
234238
htmx_url = f'{htmx_url}?{urlencode(parameters, doseq=True)}'
235239
except ValueError:
@@ -238,7 +242,6 @@ def render(self, request):
238242
'viewname': viewname,
239243
'has_permission': has_permission,
240244
'htmx_url': htmx_url,
241-
'page_size': self.config.get('page_size'),
242245
})
243246

244247

netbox/templates/extras/dashboard/widgets/objectlist.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{% if htmx_url and has_permission %}
2-
<div class="htmx-container" hx-get="{{ htmx_url }}{% if page_size %}?per_page={{ page_size }}{% endif %}" hx-trigger="load"></div>
2+
<div class="htmx-container" hx-get="{{ htmx_url }}" hx-trigger="load"></div>
33
{% elif htmx_url %}
44
<div class="text-muted text-center">
55
<i class="mdi mdi-lock-outline"></i> No permission to view this content.

0 commit comments

Comments
 (0)