Skip to content

Commit 689ebb7

Browse files
committed
Closes #11766: Remove obsolete custom ChoiceField and MultipleChoiceField classes
1 parent e40e9cb commit 689ebb7

File tree

3 files changed

+8
-23
lines changed

3 files changed

+8
-23
lines changed

docs/release-notes/version-3.6.md

+7
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# NetBox v3.6
2+
3+
## v3.6.0 (FUTURE)
4+
5+
### Other Changes
6+
7+
* [#11766](https://github.com/netbox-community/netbox/issues/11766) - Remove obsolete custom `ChoiceField` and `MultipleChoiceField` classes

mkdocs.yml

+1
Original file line numberDiff line numberDiff line change
@@ -273,6 +273,7 @@ nav:
273273
- git Cheat Sheet: 'development/git-cheat-sheet.md'
274274
- Release Notes:
275275
- Summary: 'release-notes/index.md'
276+
- Version 3.6: 'release-notes/version-3.6.md'
276277
- Version 3.5: 'release-notes/version-3.5.md'
277278
- Version 3.4: 'release-notes/version-3.4.md'
278279
- Version 3.3: 'release-notes/version-3.3.md'

netbox/utilities/forms/fields/fields.py

-23
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,11 @@
1111
from utilities.validators import EnhancedURLValidator
1212

1313
__all__ = (
14-
'ChoiceField',
1514
'ColorField',
1615
'CommentField',
1716
'JSONField',
1817
'LaxURLField',
1918
'MACAddressField',
20-
'MultipleChoiceField',
2119
'SlugField',
2220
'TagFilterField',
2321
)
@@ -128,24 +126,3 @@ def to_python(self, value):
128126
raise forms.ValidationError(self.error_messages['invalid'], code='invalid')
129127

130128
return value
131-
132-
133-
#
134-
# Choice fields
135-
#
136-
137-
class ChoiceField(forms.ChoiceField):
138-
"""
139-
Previously used to override Django's built-in `ChoiceField` to use NetBox's now-obsolete `StaticSelect` widget.
140-
"""
141-
# TODO: Remove in v3.6
142-
pass
143-
144-
145-
class MultipleChoiceField(forms.MultipleChoiceField):
146-
"""
147-
Previously used to override Django's built-in `MultipleChoiceField` to use NetBox's now-obsolete
148-
`StaticSelectMultiple` widget.
149-
"""
150-
# TODO: Remove in v3.6
151-
pass

0 commit comments

Comments
 (0)