Closes #11765: Remove StaticSelect & StaticSelectMultiple (#11767)

* Remove StaticSelect, StaticSelectMultiple form widgets

* Tag custom ChoiceField, MultipleChoiceField classes for removal in v3.6

Author: jeremystretch

docs/plugins/development/forms.md

@@ -170,6 +170,9 @@ In addition to the [form fields provided by Django](https://docs.djangoproject.c
 
 ## Choice Fields
 
+!!! warning "Obsolete Fields"
+    NetBox's custom `ChoiceField` and `MultipleChoiceField` classes are no longer necessary thanks to improvements made to the user interface. Django's native form fields can be used instead. These custom field classes will be removed in NetBox v3.6.
+
 ::: utilities.forms.ChoiceField
     options:
       members: false

netbox/circuits/forms/bulk_edit.py

@@ -7,7 +7,7 @@
 from netbox.forms import NetBoxModelBulkEditForm
 from tenancy.models import Tenant
 from utilities.forms import (
-    add_blank_choice, CommentField, DatePicker, DynamicModelChoiceField, DynamicModelMultipleChoiceField, StaticSelect,
+    add_blank_choice, CommentField, DatePicker, DynamicModelChoiceField, DynamicModelMultipleChoiceField,
 )
 
 __all__ = (
@@ -100,8 +100,7 @@ class CircuitBulkEditForm(NetBoxModelBulkEditForm):
     status = forms.ChoiceField(
         choices=add_blank_choice(CircuitStatusChoices),
         required=False,
-        initial='',
-        widget=StaticSelect()
+        initial=''
     )
     tenant = DynamicModelChoiceField(
         queryset=Tenant.objects.all(),

netbox/circuits/forms/filtersets.py

@@ -7,7 +7,7 @@
 from ipam.models import ASN
 from netbox.forms import NetBoxModelFilterSetForm
 from tenancy.forms import TenancyFilterForm, ContactModelFilterForm
-from utilities.forms import DatePicker, DynamicModelMultipleChoiceField, MultipleChoiceField, TagFilterField
+from utilities.forms import DatePicker, DynamicModelMultipleChoiceField, TagFilterField
 
 __all__ = (
     'CircuitFilterForm',
@@ -107,7 +107,7 @@ class CircuitFilterForm(TenancyFilterForm, ContactModelFilterForm, NetBoxModelFi
         },
         label=_('Provider network')
     )
-    status = MultipleChoiceField(
+    status = forms.MultipleChoiceField(
         choices=CircuitStatusChoices,
         required=False
     )

netbox/circuits/forms/model_forms.py

@@ -7,7 +7,6 @@
 from tenancy.forms import TenancyForm
 from utilities.forms import (
     CommentField, DatePicker, DynamicModelChoiceField, DynamicModelMultipleChoiceField, SelectSpeedWidget, SlugField,
-    StaticSelect,
 )
 
 __all__ = (
@@ -102,7 +101,6 @@ class Meta:
             'commit_rate': _("Committed rate"),
         }
         widgets = {
-            'status': StaticSelect(),
             'install_date': DatePicker(),
             'termination_date': DatePicker(),
             'commit_rate': SelectSpeedWidget(),
@@ -174,7 +172,6 @@ class Meta:
             'pp_info': _("Patch panel ID and port number(s)")
         }
         widgets = {
-            'term_side': StaticSelect(),
             'port_speed': SelectSpeedWidget(),
             'upstream_speed': SelectSpeedWidget(),
         }

netbox/core/forms/bulk_edit.py

@@ -4,9 +4,7 @@
 from core.choices import DataSourceTypeChoices
 from core.models import *
 from netbox.forms import NetBoxModelBulkEditForm
-from utilities.forms import (
-    add_blank_choice, BulkEditNullBooleanSelect, CommentField, StaticSelect,
-)
+from utilities.forms import add_blank_choice, BulkEditNullBooleanSelect, CommentField
 
 __all__ = (
     'DataSourceBulkEditForm',
@@ -17,8 +15,7 @@ class DataSourceBulkEditForm(NetBoxModelBulkEditForm):
     type = forms.ChoiceField(
         choices=add_blank_choice(DataSourceTypeChoices),
         required=False,
-        initial='',
-        widget=StaticSelect()
+        initial=''
     )
     enabled = forms.NullBooleanField(
         required=False,

netbox/core/forms/filtersets.py

@@ -4,9 +4,7 @@
 from core.choices import *
 from core.models import *
 from netbox.forms import NetBoxModelFilterSetForm
-from utilities.forms import (
-    BOOLEAN_WITH_BLANK_CHOICES, DynamicModelMultipleChoiceField, MultipleChoiceField, StaticSelect,
-)
+from utilities.forms import BOOLEAN_WITH_BLANK_CHOICES, DynamicModelMultipleChoiceField
 
 __all__ = (
     'DataFileFilterForm',
@@ -20,17 +18,17 @@ class DataSourceFilterForm(NetBoxModelFilterSetForm):
         (None, ('q', 'filter_id')),
         ('Data Source', ('type', 'status')),
     )
-    type = MultipleChoiceField(
+    type = forms.MultipleChoiceField(
         choices=DataSourceTypeChoices,
         required=False
     )
-    status = MultipleChoiceField(
+    status = forms.MultipleChoiceField(
         choices=DataSourceStatusChoices,
         required=False
     )
     enabled = forms.NullBooleanField(
         required=False,
-        widget=StaticSelect(
+        widget=forms.Select(
             choices=BOOLEAN_WITH_BLANK_CHOICES
         )
     )

netbox/core/forms/model_forms.py

@@ -3,7 +3,7 @@
 from django import forms
 
 from core.models import *
-from netbox.forms import NetBoxModelForm, StaticSelect
+from netbox.forms import NetBoxModelForm
 from netbox.registry import registry
 from utilities.forms import CommentField
 
@@ -21,7 +21,7 @@ class Meta:
             'name', 'type', 'source_url', 'enabled', 'description', 'comments', 'ignore_rules', 'tags',
         ]
         widgets = {
-            'type': StaticSelect(
+            'type': forms.Select(
                 attrs={
                     'hx-get': '.',
                     'hx-include': '#form_fields input',