Skip to content
This repository was archived by the owner on Oct 19, 2022. It is now read-only.

Commit 93c771d

Browse files
author
Dominik Rowicki
committed
Merge tag 'v1.1.0' into facebookincubator-master
2 parents 21e4f0d + d979964 commit 93c771d

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+1047
-713
lines changed

.travis.yml

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,9 @@
11
---
2-
# Use Ubuntu Precise instead of new default Trusty which cause build fail
3-
# with pre installed yarn v0.17.8
4-
# https://github.com/facebookincubator/create-react-app/issues/3054
5-
# TODO: remove after Trusty environment is updated with a lastet version of yarn
6-
dist: precise
2+
dist: trusty
73
language: node_js
84
node_js:
9-
- 6
105
- 8
6+
- 9
117
cache:
128
directories:
139
- node_modules
@@ -18,18 +14,15 @@ script:
1814
- 'if [ $TEST_SUITE = "simple" ]; then tasks/e2e-simple.sh; fi'
1915
- 'if [ $TEST_SUITE = "installs" ]; then tasks/e2e-installs.sh; fi'
2016
- 'if [ $TEST_SUITE = "kitchensink" ]; then tasks/e2e-kitchensink.sh; fi'
17+
- 'if [ $TEST_SUITE = "old-node" ]; then tasks/e2e-old-node.sh; fi'
2118
env:
22-
global:
23-
- USE_YARN=no
2419
matrix:
2520
- TEST_SUITE=simple
2621
- TEST_SUITE=installs
2722
- TEST_SUITE=kitchensink
2823
matrix:
2924
include:
3025
- node_js: 0.10
31-
env: TEST_SUITE=simple
32-
# There's a weird Yarn/Lerna bug related to prerelease versions.
33-
# TODO: reenable after we ship 1.0.
34-
# - node_js: 6
35-
# env: USE_YARN=yes TEST_SUITE=simple
26+
env: TEST_SUITE=old-node
27+
- node_js: 6
28+
env: TEST_SUITE=kitchensink

.yarnrc

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
--install.no-lockfile true
2+
--install.check-files true
3+
--add.no-lockfile true

CHANGELOG.md

Lines changed: 187 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,190 @@
1+
## 1.1.0 (January 15, 2018)
2+
3+
#### :rocket: New Feature
4+
5+
* `react-scripts`
6+
7+
* [#3387](https://github.com/facebookincubator/create-react-app/pull/3387) Add support for variable expansion in `.env` files. ([@moos](https://github.com/moos))
8+
9+
* `react-error-overlay`
10+
11+
* [#3474](https://github.com/facebookincubator/create-react-app/pull/3474) Allow the error overlay to be unregistered. ([@Timer](https://github.com/Timer))
12+
13+
* `create-react-app`
14+
15+
* [#3408](https://github.com/facebookincubator/create-react-app/pull/3408) Add `--info` flag to help gather bug reports. ([@tabrindle](https://github.com/tabrindle))
16+
* [#3409](https://github.com/facebookincubator/create-react-app/pull/3409) Add `--use-npm` flag to bypass Yarn even on systems that have it. ([@tabrindle](https://github.com/tabrindle))
17+
* [#3725](https://github.com/facebookincubator/create-react-app/pull/3725) Extend `--scripts-version` to include `.tar.gz` format. ([@SaschaDens](https://github.com/SaschaDens))
18+
* [#3629](https://github.com/facebookincubator/create-react-app/pull/3629) Allowing `"file:<path>"` `--scripts-version` values. ([@GreenGremlin](https://github.com/GreenGremlin))
19+
20+
21+
#### :bug: Bug Fix
22+
23+
* `babel-preset-react-app`, `react-scripts`
24+
25+
* [#3788](https://github.com/facebookincubator/create-react-app/pull/3788) Fix object destructuring inside an array on Node 6. ([@gaearon](https://github.com/gaearon))
26+
27+
* `react-dev-utils`
28+
29+
* [#3784](https://github.com/facebookincubator/create-react-app/pull/3784) Detach browser process from the shell on Linux. ([@gaearon](https://github.com/gaearon))
30+
* [#3726](https://github.com/facebookincubator/create-react-app/pull/3726) Use proxy for all request methods other than `GET`. ([@doshisid](https://github.com/doshisid))
31+
* [#3440](https://github.com/facebookincubator/create-react-app/pull/3440) Print full directory name from `lsof`. ([@rmccue](https://github.com/rmccue))
32+
* [#2071](https://github.com/facebookincubator/create-react-app/pull/2071) Fix broken console clearing on Windows. ([@danielverejan](https://github.com/danielverejan))
33+
* [#3686](https://github.com/facebookincubator/create-react-app/pull/3686) Fix starting a project in directory with `++` in the name. ([@Norris1z](https://github.com/Norris1z))
34+
35+
* `create-react-app`
36+
37+
* [#3320](https://github.com/facebookincubator/create-react-app/pull/3320) Fix offline installation to respect proxy from `.npmrc`. ([@mdogadailo](https://github.com/mdogadailo))
38+
39+
* `react-scripts`
40+
41+
* [#3537](https://github.com/facebookincubator/create-react-app/pull/3537) Add `mjs` and `jsx` filename extensions to `file-loader` exclude pattern. ([@iansu](https://github.com/iansu))
42+
* [#3511](https://github.com/facebookincubator/create-react-app/pull/3511) Unmount the component in the default generated test. ([@gaearon](https://github.com/gaearon))
43+
44+
#### :nail_care: Enhancement
45+
46+
* `react-scripts`
47+
48+
* [#3730](https://github.com/facebookincubator/create-react-app/pull/3730) Print when `HOST` environment variable is set. ([@iansu](https://github.com/iansu))
49+
* [#3455](https://github.com/facebookincubator/create-react-app/pull/3455) Add a localhost-only log message pointing folks to the PWA docs. ([@jeffposnick](https://github.com/jeffposnick))
50+
* [#3416](https://github.com/facebookincubator/create-react-app/pull/3416) Improve eject message. ([@xjlim](https://github.com/xjlim))
51+
52+
* `create-react-app`
53+
54+
* [#3740](https://github.com/facebookincubator/create-react-app/pull/3740) Allow more non-conflicting files in initial project directory. ([@GreenGremlin](https://github.com/GreenGremlin))
55+
56+
* `react-dev-utils`
57+
58+
* [#3104](https://github.com/facebookincubator/create-react-app/pull/3104) Add link to deployment docs after build. ([@viankakrisna](https://github.com/viankakrisna))
59+
* [#3652](https://github.com/facebookincubator/create-react-app/pull/3652) Add `code-insiders` to the editor list. ([@shrynx](https://github.com/shrynx))
60+
* [#3700](https://github.com/facebookincubator/create-react-app/pull/3700) Add editor support for Sublime Dev & VSCode Insiders. ([@yyx990803](https://github.com/yyx990803))
61+
* [#3545](https://github.com/facebookincubator/create-react-app/pull/3545) Autodetect MacVim editor. ([@gnapse](https://github.com/gnapse))
62+
63+
* `react-dev-utils`, `react-error-overlay`
64+
65+
* [#3465](https://github.com/facebookincubator/create-react-app/pull/3465) Open editor to exact column from build error overlay. ([@tharakawj](https://github.com/tharakawj))
66+
67+
* `react-dev-utils`, `react-scripts`
68+
69+
* [#3721](https://github.com/facebookincubator/create-react-app/pull/3721) Support setting `none` in `REACT_EDITOR` environment variable. ([@raerpo](https://github.com/raerpo))
70+
71+
* `eslint-config-react-app`
72+
73+
* [#3716](https://github.com/facebookincubator/create-react-app/pull/3716) Relax `no-cond-assign` rule. ([@gaearon](https://github.com/gaearon))
74+
75+
#### :memo: Documentation
76+
77+
* User Guide
78+
79+
* [#3659](https://github.com/facebookincubator/create-react-app/pull/3659) Add info about service-worker and HTTP caching headers into Firebase section. ([@bobrosoft](https://github.com/bobrosoft))
80+
* [#3515](https://github.com/facebookincubator/create-react-app/pull/3515) Add Powershell commands to README.md. ([@Gua-naiko-che](https://github.com/Gua-naiko-che))
81+
* [#3656](https://github.com/facebookincubator/create-react-app/pull/3656) Better documentation for setupTests.js when ejecting. ([@dannycalleri](https://github.com/dannycalleri))
82+
* [#1791](https://github.com/facebookincubator/create-react-app/pull/1791) Add link for automatic deployment to azure. ([@ulrikstrid](https://github.com/ulrikstrid))
83+
* [#3717](https://github.com/facebookincubator/create-react-app/pull/3717) Update README.md. ([@maecapozzi](https://github.com/maecapozzi))
84+
* [#3710](https://github.com/facebookincubator/create-react-app/pull/3710) Link to an explanation for forking react-scripts. ([@gaearon](https://github.com/gaearon))
85+
* [#3709](https://github.com/facebookincubator/create-react-app/pull/3709) Document adding a router. ([@gaearon](https://github.com/gaearon))
86+
* [#3670](https://github.com/facebookincubator/create-react-app/pull/3670) Fix typo in the User Guide. ([@qbahers](https://github.com/qbahers))
87+
* [#3645](https://github.com/facebookincubator/create-react-app/pull/3645) Update README.md. ([@elie222](https://github.com/elie222))
88+
* [#3533](https://github.com/facebookincubator/create-react-app/pull/3533) Use safer/more aesthetic syntax for setting environment variables on Windows. ([@cdanielsen](https://github.com/cdanielsen))
89+
* [#3605](https://github.com/facebookincubator/create-react-app/pull/3605) Updated Debugging Tests for VSCode. ([@amadeogallardo](https://github.com/amadeogallardo))
90+
* [#3601](https://github.com/facebookincubator/create-react-app/pull/3601) Fixed typo in webpack.config.dev.js. ([@nmenglund](https://github.com/nmenglund))
91+
* [#3576](https://github.com/facebookincubator/create-react-app/pull/3576) Updates comment to reflect codebase. ([@rahulcs](https://github.com/rahulcs))
92+
* [#3510](https://github.com/facebookincubator/create-react-app/pull/3510) Update User Guide with deploying to GitHub User pages. ([@aaronlna](https://github.com/aaronlna))
93+
* [#3503](https://github.com/facebookincubator/create-react-app/pull/3503) Update Prettier editor integration link. ([@gaving](https://github.com/gaving))
94+
* [#3453](https://github.com/facebookincubator/create-react-app/pull/3453) Fix dead links. ([@vannio](https://github.com/vannio))
95+
* [#2992](https://github.com/facebookincubator/create-react-app/pull/2992) Docs: How to Debug Unit Tests. ([@MattMorgis](https://github.com/MattMorgis))
96+
97+
* Other
98+
99+
* [#3729](https://github.com/facebookincubator/create-react-app/pull/3729) Update README.md to note Neutrino's support of react components. ([@eliperelman](https://github.com/eliperelman))
100+
* [#2841](https://github.com/facebookincubator/create-react-app/pull/2841) Documentation to help windows contributors. ([@Dubes](https://github.com/Dubes))
101+
* [#3489](https://github.com/facebookincubator/create-react-app/pull/3489) Add link to nvm-windows. ([@davidgilbertson](https://github.com/davidgilbertson))
102+
103+
* `eslint-config-react-app`
104+
105+
* [#3460](https://github.com/facebookincubator/create-react-app/pull/3460) Fix broken link to `href-no-hash` eslint rule. ([@hazolsky](https://github.com/hazolsky))
106+
107+
#### :house: Internal
108+
109+
* Other
110+
111+
* [#3769](https://github.com/facebookincubator/create-react-app/pull/3769) Enable Yarn check files. ([@Timer](https://github.com/Timer))
112+
* [#3756](https://github.com/facebookincubator/create-react-app/pull/3756) Clean up changes to npm and yarn registry in E2E tests. ([@viankakrisna](https://github.com/viankakrisna))
113+
* [#3744](https://github.com/facebookincubator/create-react-app/pull/3744) Use private registry in E2E tests. ([@Timer](https://github.com/Timer))
114+
* [#3738](https://github.com/facebookincubator/create-react-app/pull/3738) Always use Yarn on CI. ([@gaearon](https://github.com/gaearon))
115+
* [#2309](https://github.com/facebookincubator/create-react-app/pull/2309) Port `cra.sh` development task to javascript. ([@ianschmitz](https://github.com/ianschmitz))
116+
* [#3411](https://github.com/facebookincubator/create-react-app/pull/3411) Simplify waiting for app start in E2E tests. ([@xjlim](https://github.com/xjlim))
117+
* [#3755](https://github.com/facebookincubator/create-react-app/pull/3755) Switch to Yarn Workspaces. ([@gaearon](https://github.com/gaearon))
118+
* [#3757](https://github.com/facebookincubator/create-react-app/pull/3757) Try updating Flow. ([@gaearon](https://github.com/gaearon))
119+
* [#3414](https://github.com/facebookincubator/create-react-app/pull/3414) Export `dismissRuntimeErrors` function. ([@skidding](https://github.com/skidding))
120+
* [#3036](https://github.com/facebookincubator/create-react-app/pull/3036) Cleaning up `printHostingInstructions` a bit. ([@GreenGremlin](https://github.com/GreenGremlin))
121+
* [#3514](https://github.com/facebookincubator/create-react-app/pull/3514) Fix `FileSizeReporter` for multi build Webpack setups. ([@iiska](https://github.com/iiska))
122+
* [#3362](https://github.com/facebookincubator/create-react-app/pull/3362) Refactor extra watch options regex to `react-dev-utils`. ([@xjlim](https://github.com/xjlim))
123+
124+
#### Committers: 47
125+
126+
- Aaron Lamb ([aaronlna](https://github.com/aaronlna))
127+
- Ade Viankakrisna Fadlil ([viankakrisna](https://github.com/viankakrisna))
128+
- Amadeo Gallardo ([amadeogallardo](https://github.com/amadeogallardo))
129+
- Andy Kenward ([andykenward](https://github.com/andykenward))
130+
- Christian Danielsen ([cdanielsen](https://github.com/cdanielsen))
131+
- Clayton Ray ([iamclaytonray](https://github.com/iamclaytonray))
132+
- Dan Abramov ([gaearon](https://github.com/gaearon))
133+
- Daniel Verejan ([danielverejan](https://github.com/danielverejan))
134+
- Danny Calleri ([dannycalleri](https://github.com/dannycalleri))
135+
- David Boyne ([boyney123](https://github.com/boyney123))
136+
- David Gilbertson ([davidgilbertson](https://github.com/davidgilbertson))
137+
- Eli Perelman ([eliperelman](https://github.com/eliperelman))
138+
- Elie ([elie222](https://github.com/elie222))
139+
- Ernesto García ([gnapse](https://github.com/gnapse))
140+
- Evan You ([yyx990803](https://github.com/yyx990803))
141+
- Gavin Gilmour ([gaving](https://github.com/gaving))
142+
- Ian Schmitz ([ianschmitz](https://github.com/ianschmitz))
143+
- Ian Sutherland ([iansu](https://github.com/iansu))
144+
- JANG SUN HYUK ([wkdtjsgur100](https://github.com/wkdtjsgur100))
145+
- Jeffrey Posnick ([jeffposnick](https://github.com/jeffposnick))
146+
- Joe Haddad ([Timer](https://github.com/Timer))
147+
- Joe Lim ([xjlim](https://github.com/xjlim))
148+
- Jonathan ([GreenGremlin](https://github.com/GreenGremlin))
149+
- Juhamatti Niemelä ([iiska](https://github.com/iiska))
150+
- Mae Capozzi ([maecapozzi](https://github.com/maecapozzi))
151+
- Maksym Dogadailo ([mdogadailo](https://github.com/mdogadailo))
152+
- Mario Nebl ([marionebl](https://github.com/marionebl))
153+
- Matt Morgis ([MattMorgis](https://github.com/MattMorgis))
154+
- Misha Khokhlov ([hazolsky](https://github.com/hazolsky))
155+
- Moos ([moos](https://github.com/moos))
156+
- Nils Magnus Englund ([nmenglund](https://github.com/nmenglund))
157+
- Norris Oduro ([Norris1z](https://github.com/Norris1z))
158+
- Ovidiu Cherecheș ([skidding](https://github.com/skidding))
159+
- Quentin Bahers ([qbahers](https://github.com/qbahers))
160+
- Rafael E. Poveda ([raerpo](https://github.com/raerpo))
161+
- Rahul Chanila ([rahulcs](https://github.com/rahulcs))
162+
- Ryan McCue ([rmccue](https://github.com/rmccue))
163+
- Sascha Dens ([SaschaDens](https://github.com/SaschaDens))
164+
- Siddharth Doshi ([doshisid](https://github.com/doshisid))
165+
- Tao Gómez Gil ([Gua-naiko-che](https://github.com/Gua-naiko-che))
166+
- Tharaka Wijebandara ([tharakawj](https://github.com/tharakawj))
167+
- Trevor Brindle ([tabrindle](https://github.com/tabrindle))
168+
- Ulrik Strid ([ulrikstrid](https://github.com/ulrikstrid))
169+
- Vladimir Tolstikov ([bobrosoft](https://github.com/bobrosoft))
170+
- [Dubes](https://github.com/Dubes)
171+
- [vannio](https://github.com/vannio)
172+
- shrynx ([shrynx](https://github.com/shrynx))
173+
174+
### Migrating from 1.0.17 to 1.1.0
175+
176+
Inside any created project that has not been ejected, run:
177+
178+
```
179+
npm install --save --save-exact [email protected]
180+
```
181+
182+
or
183+
184+
```
185+
yarn add --exact [email protected]
186+
```
187+
1188
## 1.0.17 (November 3, 2017)
2189

3190
#### :nail_care: Enhancement

CODE_OF_CONDUCT.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# Code of Conduct
2+
3+
Facebook has adopted a Code of Conduct that we expect project participants to adhere to. Please [read the full text](https://code.facebook.com/pages/876921332402685/open-source-code-of-conduct) so that you can understand what actions will and will not be tolerated.

CONTRIBUTING.md

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,27 +75,40 @@ All functionality must be retained (and configuration given to the user) if they
7575

7676
1. Clone the repo with `git clone https://github.com/facebookincubator/create-react-app`
7777

78-
2. Run `npm install` in the root `create-react-app` folder.
78+
2. Run `yarn` in the root `create-react-app` folder.
7979

80-
Once it is done, you can modify any file locally and run `npm start`, `npm test` or `npm run build` just like in a generated project.
80+
Once it is done, you can modify any file locally and run `yarn start`, `yarn test` or `yarn build` just like in a generated project.
8181

8282
If you want to try out the end-to-end flow with the global CLI, you can do this too:
8383

8484
```
85-
npm run create-react-app my-app
85+
yarn create-react-app my-app
8686
cd my-app
8787
```
8888

89-
and then run `npm start` or `npm run build`.
90-
91-
*Note: if you are using yarn, we suggest that you use `yarn install --no-lockfile` instead of the bare `yarn` or `yarn install` because we [intentionally](https://github.com/facebookincubator/create-react-app/pull/2014#issuecomment-300811661) do not ignore or add yarn.lock to our repo.*
89+
and then run `yarn start` or `yarn build`.
9290

9391
## Contributing to E2E (end to end) tests
9492

9593
**TL;DR** use the command `yarn e2e:docker` to run unit and e2e tests.
9694

9795
More detailed information are in the dedicated [README](/packages/react-scripts/fixtures/kitchensink/README.md).
9896

97+
## Tips for contributors using Windows
98+
99+
The scripts in tasks folder and other scripts in `package.json` will not work in Windows out of the box. However, using [Bash on windows](https://msdn.microsoft.com/en-us/commandline/wsl/about) makes it easier to use those scripts without any workarounds. The steps to do so are detailed below:
100+
101+
### Install Bash on Ubuntu on Windows
102+
103+
A good step by step guide can be found [here](https://www.howtogeek.com/249966/how-to-install-and-use-the-linux-bash-shell-on-windows-10/)
104+
105+
### Install Node.js and yarn
106+
Even if you have node and yarn installed on your windows, it would not be accessible from the bash shell. You would have to install it again. Installing via [`nvm`](https://github.com/creationix/nvm#install-script) is recommended.
107+
108+
### Line endings
109+
110+
By default git would use `CRLF` line endings which would cause the scripts to fail. You can change it for this repo only by setting `autocrlf` to false by running `git config core.autocrlf false`. You can also enable it for all your repos by using the `--global` flag if you wish to do so.
111+
99112
## Cutting a Release
100113

101114
1. Tag all merged pull requests that go into the release with the relevant milestone. Each merged PR should also be labeled with one of the [labels](https://github.com/facebookincubator/create-react-app/labels) named `tag: ...` to indicate what kind of change it is.
@@ -104,11 +117,11 @@ More detailed information are in the dedicated [README](/packages/react-scripts/
104117
4. Note that files in `packages/create-react-app` should be modified with extreme caution. Since it’s a global CLI, any version of `create-react-app` (global CLI) including very old ones should work with the latest version of `react-scripts`.
105118
5. Create a change log entry for the release:
106119
* You'll need an [access token for the GitHub API](https://help.github.com/articles/creating-an-access-token-for-command-line-use/). Save it to this environment variable: `export GITHUB_AUTH="..."`
107-
* Run `npm run changelog`. The command will find all the labeled pull requests merged since the last release and group them by the label and affected packages, and create a change log entry with all the changes and links to PRs and their authors. Copy and paste it to `CHANGELOG.md`.
120+
* Run `yarn changelog`. The command will find all the labeled pull requests merged since the last release and group them by the label and affected packages, and create a change log entry with all the changes and links to PRs and their authors. Copy and paste it to `CHANGELOG.md`.
108121
* Add a four-space indented paragraph after each non-trivial list item, explaining what changed and why. For each breaking change also write who it affects and instructions for migrating existing code.
109122
* Maybe add some newlines here and there. Preview the result on GitHub to get a feel for it. Changelog generator output is a bit too terse for my taste, so try to make it visually pleasing and well grouped.
110123
6. Make sure to include “Migrating from ...” instructions for the previous release. Often you can copy and paste them.
111-
7. **Do not run `npm publish`. Instead, run `npm run publish`.**
124+
7. Run `npm run publish`. (It has to be `npm run publish` exactly, not just `npm publish` or `yarn publish`.)
112125
8. Wait for a long time, and it will get published. Don’t worry that it’s stuck. In the end the publish script will prompt for versions before publishing the packages.
113126
9. After publishing, create a GitHub Release with the same text as the changelog entry. See previous Releases for inspiration.
114127

0 commit comments

Comments
 (0)