fix(config): ignores an empty config file path (#5037)

* fix(deps): check for config file path and add tests

* fix(config): regenerate snapshots

---------

Co-authored-by: Lukas Holzer <[email protected]>

Author: jenae-janzen

package-lock.json

@@ -0,0 +1,2 @@
+[build]
+command = "echo not party town"

packages/build/tests/core/fixtures/toml/apps/nested/netlify.toml

@@ -0,0 +1,2 @@
+[build]
+command = "echo 'party town'"

packages/build/tests/core/fixtures/toml/netlify.toml

@@ -175,6 +175,107 @@ Generated by [AVA](https://avajs.dev).
     (Netlify Build completed in 1ms)␊
     Build step duration: Netlify Build completed in 1ms`
 
+## nested --config
+
+> Snapshot 1
+
+    `␊
+    Netlify Build                                                 ␊
+    ────────────────────────────────────────────────────────────────␊
+    ␊
+    > Version␊
+      @netlify/build 1.0.0␊
+    ␊
+    > Flags␊
+      config: packages/build/tests/core/fixtures/toml/apps/nested/netlify.toml␊
+      debug: true␊
+      repositoryRoot: packages/build/tests/core/fixtures/toml␊
+      testOpts:␊
+        pluginsListUrl: test␊
+        silentLingeringProcesses: true␊
+    ␊
+    > Current directory␊
+      packages/build/tests/core/fixtures/toml␊
+    ␊
+    > Config file␊
+      packages/build/tests/core/fixtures/toml/apps/nested/netlify.toml␊
+    ␊
+    > Resolved config␊
+      build:␊
+        command: echo not party town␊
+        commandOrigin: config␊
+        publish: packages/build/tests/core/fixtures/toml␊
+        publishOrigin: default␊
+    ␊
+    > Context␊
+      production␊
+    ␊
+    build.command from netlify.toml                               ␊
+    ────────────────────────────────────────────────────────────────␊
+    ␊
+    $ echo not party town␊
+    not party town␊
+    ␊
+    (build.command completed in 1ms)␊
+    Build step duration: build.command completed in 1ms␊
+    ␊
+    Netlify Build Complete                                        ␊
+    ────────────────────────────────────────────────────────────────␊
+    ␊
+    (Netlify Build completed in 1ms)␊
+    Build step duration: Netlify Build completed in 1ms`
+
+## empty --config
+
+> Snapshot 1
+
+    `␊
+    Netlify Build                                                 ␊
+    ────────────────────────────────────────────────────────────────␊
+    ␊
+    > Version␊
+      @netlify/build 1.0.0␊
+    ␊
+    > Flags␊
+      cwd: packages/build/tests/core/fixtures/toml/apps/nested␊
+      debug: true␊
+      repositoryRoot: packages/build/tests/core/fixtures/toml␊
+      testOpts:␊
+        pluginsListUrl: test␊
+        silentLingeringProcesses: true␊
+    ␊
+    > Current directory␊
+      packages/build/tests/core/fixtures/toml/apps/nested␊
+    ␊
+    > Config file␊
+      packages/build/tests/core/fixtures/toml/apps/nested/netlify.toml␊
+    ␊
+    > Resolved config␊
+      build:␊
+        base: packages/build/tests/core/fixtures/toml/apps/nested␊
+        command: echo not party town␊
+        commandOrigin: config␊
+        publish: packages/build/tests/core/fixtures/toml/apps/nested␊
+        publishOrigin: default␊
+    ␊
+    > Context␊
+      production␊
+    ␊
+    build.command from netlify.toml                               ␊
+    ────────────────────────────────────────────────────────────────␊
+    ␊
+    $ echo not party town␊
+    not party town␊
+    ␊
+    (build.command completed in 1ms)␊
+    Build step duration: build.command completed in 1ms␊
+    ␊
+    Netlify Build Complete                                        ␊
+    ────────────────────────────────────────────────────────────────␊
+    ␊
+    (Netlify Build completed in 1ms)␊
+    Build step duration: Netlify Build completed in 1ms`
+
 ## --defaultConfig CLI flag
 
 > Snapshot 1

packages/build/tests/core/snapshots/tests.js.md

@@ -132,6 +132,20 @@ test('--config', async (t) => {
   t.snapshot(normalizeOutput(output))
 })
 
+test('nested --config', async (t) => {
+  const output = await new Fixture('./fixtures/toml')
+    .withFlags({ config: `${FIXTURES_DIR}/toml/apps/nested/netlify.toml` })
+    .runWithBuild()
+  t.snapshot(normalizeOutput(output))
+})
+
+test('empty --config', async (t) => {
+  const output = await new Fixture('./fixtures/toml')
+    .withFlags({ config: '', cwd: `${FIXTURES_DIR}/toml/apps/nested` })
+    .runWithBuild()
+  t.snapshot(normalizeOutput(output))
+})
+
 test('--defaultConfig CLI flag', async (t) => {
   const { output } = await new Fixture('./fixtures/empty')
     .withFlags({

packages/build/tests/core/snapshots/tests.js.snap

@@ -216,7 +216,6 @@ const getFullConfig = async function ({
   featureFlags,
 }) {
   const configPath = await getConfigPath({ configOpt, cwd, repositoryRoot, configBase })
-
   try {
     const config = await parseConfig(configPath)
     const configA = mergeAndNormalizeConfig({

packages/build/tests/core/tests.js

@@ -26,7 +26,7 @@ export const getConfigPath = async function ({ configOpt, cwd, repositoryRoot, c
 
 /** --config CLI flag */
 const searchConfigOpt = function (cwd: string, configOpt?: string) {
-  if (configOpt === undefined) {
+  if (configOpt === undefined || configOpt.length === 0) {
     return
   }
 

packages/config/src/main.js

@@ -0,0 +1,2 @@
+[build]
+command = "not party town"

packages/config/src/path.ts

@@ -0,0 +1,2 @@
+[build]
+command = "party town"