Merge pull request #815 from netlify/feat/add-dep-error-message

Improve error message when dependencies installation fails

Author: ehmicky

packages/build/src/plugins/options.js

@@ -40,7 +40,7 @@ const resolvePlugin = async function({ package, ...pluginOptions }, baseDir) {
     // `resolve`
   } catch (error) {
     logResolveError(error, package)
-    await addDependency(package, { packageRoot: baseDir, stdio: 'ignore' })
+    await addDependency(package, { packageRoot: baseDir })
     return await tryResolvePlugin(package, pluginOptions, baseDir)
   }
 }

packages/build/src/utils/install.js

@@ -20,8 +20,16 @@ const installDependencies = async function(packageRoot) {
 }
 
 // Add new Node.js dependencies
-const addDependency = async function(packageName, { packageRoot, stdio }) {
-  await execa.command(`npm install --no-progress --no-audit --no-fund ${packageName}`, { cwd: packageRoot, stdio })
+const addDependency = async function(packageName, { packageRoot }) {
+  try {
+    await execa.command(`npm install --no-progress --no-audit --no-fund ${packageName}`, {
+      cwd: packageRoot,
+      all: true,
+    })
+  } catch (error) {
+    const errorA = new Error(`Error while installing dependencies in ${packageRoot}\n${error.all}`)
+    throw errorA
+  }
 }
 
 module.exports = { installDependencies, addDependency }

packages/build/tests/config/load/snapshots/tests.js.snap

@@ -698,53 +698,6 @@ Generated by [AVA](https://ava.li).
     └─────────────────────────────┘␊
     `
 
-## plugins.any.type renamed
-
-> Snapshot 1
-
-    `␊
-    > Starting Netlify Build v1.0.0␊
-      https://github.com/netlify/build␊
-    ␊
-    > Flags␊
-    { config: '/file/path' }␊
-    ␊
-    > Current directory␊
-      /file/path␊
-    ␊
-    > Config file␊
-      /file/path␊
-    ␊
-    Configuration property plugins[0].type has been renamed to "package".␊
-    ␊
-    Invalid syntax␊
-    ␊
-      plugins:␊
-        - type: /file/path␊
-    ␊
-    Valid syntax␊
-    ␊
-      plugins:␊
-        - enabled: true␊
-          package: /file/path␊
-    ␊
-      Error: '/file/path' plugin not installed or found.␊
-      Please install it with npm or yarn.␊
-      Cannot find module '/file/path' from '/file/path'␊
-    ␊
-    ␊
-    ┌─────────────────────────────┐␊
-    │     Netlify Build Error     │␊
-    └─────────────────────────────┘␊
-    ␊
-    Error: Command failed with exit code 1: npm install --no-progress --no-audit --no-fund /file/path␊
-    STACK TRACE␊
-    ␊
-    ┌─────────────────────────────┐␊
-    │   END Netlify Build Error   │␊
-    └─────────────────────────────┘␊
-    `
-
 ## plugins.any: unknown property
 
 > Snapshot 1

packages/build/tests/config/normalize/snapshots/tests.js.snap

@@ -282,40 +282,6 @@ Generated by [AVA](https://ava.li).
     Have a nice day!␊
     `
 
-## Missing plugins
-
-> Snapshot 1
-
-    `␊
-    > Starting Netlify Build v1.0.0␊
-      https://github.com/netlify/build␊
-    ␊
-    > Flags␊
-    { config: '/file/path' }␊
-    ␊
-    > Current directory␊
-      /file/path␊
-    ␊
-    > Config file␊
-      /file/path␊
-    ␊
-      Error: 'does-not-exist' plugin not installed or found.␊
-      Please install it with npm or yarn.␊
-      Cannot find module 'does-not-exist' from '/file/path'␊
-    ␊
-    ␊
-    ┌─────────────────────────────┐␊
-    │     Netlify Build Error     │␊
-    └─────────────────────────────┘␊
-    ␊
-    Error: Command failed with exit code 1: npm install --no-progress --no-audit --no-fund does-not-exist␊
-    STACK TRACE␊
-    ␊
-    ┌─────────────────────────────┐␊
-    │   END Netlify Build Error   │␊
-    └─────────────────────────────┘␊
-    `
-
 ## Node module plugins
 
 > Snapshot 1