Do not allow overriding an error status with a success status (#1273)

Author: ehmicky

packages/build/src/core/status.js

@@ -27,8 +27,14 @@ const addStatus = function({ newStatus, statuses, event, package, packageJson: {
     return statuses
   }
 
+  // Error statuses cannot be overwritten
+  const formerStatus = statuses.find(status => status.package === package)
+  if (formerStatus !== undefined && formerStatus.state !== 'success') {
+    return statuses
+  }
+
   // Overrides plugin's previous status and add more information
-  const newStatuses = statuses.filter(status => status.package !== package)
+  const newStatuses = statuses.filter(status => status !== formerStatus)
   return [...newStatuses, { ...newStatus, event, package, version }]
 }
 

packages/build/tests/plugins/status/fixtures/error_status_override/netlify.toml

@@ -0,0 +1,2 @@
+[[plugins]]
+package = "./plugin.js"

packages/build/tests/plugins/status/fixtures/error_status_override/plugin.js

@@ -0,0 +1,19 @@
+module.exports = {
+  onBuild() {
+    throw new Error('onBuild')
+  },
+  onError({
+    utils: {
+      status: { show },
+    },
+  }) {
+    show({ summary: 'summary' })
+  },
+  onEnd({
+    utils: {
+      status: { show },
+    },
+  }) {
+    show({ summary: 'summary' })
+  },
+}

packages/build/tests/plugins/status/snapshots/tests.js.md

@@ -306,6 +306,75 @@ Generated by [AVA](https://ava.li).
       In "onInit" event in local plugin "/file/path"␊
     `
 
+## utils.status.show() cannot override an error status
+
+> Snapshot 1
+
+    `␊
+    ┌─────────────────────────────┐␊
+    │        Netlify Build        │␊
+    └─────────────────────────────┘␊
+    ␊
+    > Version␊
+      @netlify/build 1.0.0␊
+    ␊
+    > Flags␊
+      repositoryRoot: /file/path␊
+    ␊
+    > Current directory␊
+      /file/path␊
+    ␊
+    > Config file␊
+      /file/path␊
+    ␊
+    > Resolved config␊
+      plugins:␊
+        - package: /file/path␊
+    ␊
+    > Context␊
+      production␊
+    ␊
+    > Loading plugins␊
+       - /file/path␊
+    ␊
+    ┌─────────────────────────────────────┐␊
+    │ 1. onBuild command from /file/path │␊
+    └─────────────────────────────────────┘␊
+    ␊
+    ␊
+    ┌─────────────────────────────────────┐␊
+    │ 2. onError command from /file/path │␊
+    └─────────────────────────────────────┘␊
+    ␊
+    ␊
+    (/file/path onError completed in 1ms)␊
+    ␊
+    ┌───────────────────────────────────┐␊
+    │ 3. onEnd command from /file/path │␊
+    └───────────────────────────────────┘␊
+    ␊
+    ␊
+    (/file/path onEnd completed in 1ms)␊
+    ␊
+    ┌─────────────────────────────────────┐␊
+    │ Plugin "/file/path" internal error │␊
+    └─────────────────────────────────────┘␊
+    ␊
+      Error message␊
+      Error: onBuild␊
+    ␊
+      Plugin details␊
+      Name:           /file/path␊
+      Version:        1.0.0␊
+      Repository:     git+https://github.com/netlify/build.git␊
+      npm link:       https://www.npmjs.com/package/@netlify/build␊
+      Report issues:  https://github.com/netlify/build/issues␊
+    ␊
+      Error location␊
+      In "onBuild" event in local plugin "/file/path"␊
+    STACK TRACE␊
+    `
+
 ## utils.status.show() does not fail
 
 > Snapshot 1

packages/build/tests/plugins/status/snapshots/tests.js.snap

@@ -14,6 +14,10 @@ test('utils.status.show() are printed locally', async t => {
   await runFixture(t, 'print')
 })
 
+test('utils.status.show() cannot override an error status', async t => {
+  await runFixture(t, 'error_status_override')
+})
+
 test('utils.status.show() argument should be defined', async t => {
   await runUtilsStatusShow(t, '')
 })