diff --git a/packages/build/src/plugins/options.js b/packages/build/src/plugins/options.js index 092715f125..5c121a75f4 100644 --- a/packages/build/src/plugins/options.js +++ b/packages/build/src/plugins/options.js @@ -40,7 +40,7 @@ const resolvePlugin = async function({ package, ...pluginOptions }, baseDir) { // `resolve` } catch (error) { logResolveError(error, package) - await addDependency(package, { packageRoot: baseDir, stdio: 'ignore' }) + await addDependency(package, { packageRoot: baseDir }) return await tryResolvePlugin(package, pluginOptions, baseDir) } } diff --git a/packages/build/src/utils/install.js b/packages/build/src/utils/install.js index fe5906d4cb..c68246e765 100644 --- a/packages/build/src/utils/install.js +++ b/packages/build/src/utils/install.js @@ -20,8 +20,16 @@ const installDependencies = async function(packageRoot) { } // Add new Node.js dependencies -const addDependency = async function(packageName, { packageRoot, stdio }) { - await execa.command(`npm install --no-progress --no-audit --no-fund ${packageName}`, { cwd: packageRoot, stdio }) +const addDependency = async function(packageName, { packageRoot }) { + try { + await execa.command(`npm install --no-progress --no-audit --no-fund ${packageName}`, { + cwd: packageRoot, + all: true, + }) + } catch (error) { + const errorA = new Error(`Error while installing dependencies in ${packageRoot}\n${error.all}`) + throw errorA + } } module.exports = { installDependencies, addDependency } diff --git a/packages/build/tests/config/load/snapshots/tests.js.snap b/packages/build/tests/config/load/snapshots/tests.js.snap index 5e9c49e56b..fa46bad7fc 100644 Binary files a/packages/build/tests/config/load/snapshots/tests.js.snap and b/packages/build/tests/config/load/snapshots/tests.js.snap differ diff --git a/packages/build/tests/config/normalize/snapshots/tests.js.snap b/packages/build/tests/config/normalize/snapshots/tests.js.snap index 487402365e..8b50c3fe0a 100644 Binary files a/packages/build/tests/config/normalize/snapshots/tests.js.snap and b/packages/build/tests/config/normalize/snapshots/tests.js.snap differ diff --git a/packages/build/tests/config/template/snapshots/tests.js.snap b/packages/build/tests/config/template/snapshots/tests.js.snap index 13387a5614..9ed619ced8 100644 Binary files a/packages/build/tests/config/template/snapshots/tests.js.snap and b/packages/build/tests/config/template/snapshots/tests.js.snap differ diff --git a/packages/build/tests/config/validate/snapshots/tests.js.md b/packages/build/tests/config/validate/snapshots/tests.js.md index ba83556199..cc772000ca 100644 --- a/packages/build/tests/config/validate/snapshots/tests.js.md +++ b/packages/build/tests/config/validate/snapshots/tests.js.md @@ -698,53 +698,6 @@ Generated by [AVA](https://ava.li). └─────────────────────────────┘␊ ` -## plugins.any.type renamed - -> Snapshot 1 - - `␊ - > Starting Netlify Build v1.0.0␊ - https://github.com/netlify/build␊ - ␊ - > Flags␊ - { config: '/file/path' }␊ - ␊ - > Current directory␊ - /file/path␊ - ␊ - > Config file␊ - /file/path␊ - ␊ - Configuration property plugins[0].type has been renamed to "package".␊ - ␊ - Invalid syntax␊ - ␊ - plugins:␊ - - type: /file/path␊ - ␊ - Valid syntax␊ - ␊ - plugins:␊ - - enabled: true␊ - package: /file/path␊ - ␊ - Error: '/file/path' plugin not installed or found.␊ - Please install it with npm or yarn.␊ - Cannot find module '/file/path' from '/file/path'␊ - ␊ - ␊ - ┌─────────────────────────────┐␊ - │ Netlify Build Error │␊ - └─────────────────────────────┘␊ - ␊ - Error: Command failed with exit code 1: npm install --no-progress --no-audit --no-fund /file/path␊ - STACK TRACE␊ - ␊ - ┌─────────────────────────────┐␊ - │ END Netlify Build Error │␊ - └─────────────────────────────┘␊ - ` - ## plugins.any: unknown property > Snapshot 1 diff --git a/packages/build/tests/config/validate/snapshots/tests.js.snap b/packages/build/tests/config/validate/snapshots/tests.js.snap index 0eb8b79aa2..0e776fb966 100644 Binary files a/packages/build/tests/config/validate/snapshots/tests.js.snap and b/packages/build/tests/config/validate/snapshots/tests.js.snap differ diff --git a/packages/build/tests/core/cli/snapshots/tests.js.snap b/packages/build/tests/core/cli/snapshots/tests.js.snap index 049390b075..4147ee8d0c 100644 Binary files a/packages/build/tests/core/cli/snapshots/tests.js.snap and b/packages/build/tests/core/cli/snapshots/tests.js.snap differ diff --git a/packages/build/tests/core/commands/snapshots/tests.js.snap b/packages/build/tests/core/commands/snapshots/tests.js.snap index 8985b054cc..fd66c0f092 100644 Binary files a/packages/build/tests/core/commands/snapshots/tests.js.snap and b/packages/build/tests/core/commands/snapshots/tests.js.snap differ diff --git a/packages/build/tests/core/error/snapshots/tests.js.snap b/packages/build/tests/core/error/snapshots/tests.js.snap index d5b7232148..7023c87e15 100644 Binary files a/packages/build/tests/core/error/snapshots/tests.js.snap and b/packages/build/tests/core/error/snapshots/tests.js.snap differ diff --git a/packages/build/tests/core/lifecycle/snapshots/tests.js.snap b/packages/build/tests/core/lifecycle/snapshots/tests.js.snap index 9c733d0747..aeea7a1c8c 100644 Binary files a/packages/build/tests/core/lifecycle/snapshots/tests.js.snap and b/packages/build/tests/core/lifecycle/snapshots/tests.js.snap differ diff --git a/packages/build/tests/plugins/api/snapshots/tests.js.snap b/packages/build/tests/plugins/api/snapshots/tests.js.snap index 44c84465f6..02d016908b 100644 Binary files a/packages/build/tests/plugins/api/snapshots/tests.js.snap and b/packages/build/tests/plugins/api/snapshots/tests.js.snap differ diff --git a/packages/build/tests/plugins/config/snapshots/tests.js.snap b/packages/build/tests/plugins/config/snapshots/tests.js.snap index b9ad460435..452bfed125 100644 Binary files a/packages/build/tests/plugins/config/snapshots/tests.js.snap and b/packages/build/tests/plugins/config/snapshots/tests.js.snap differ diff --git a/packages/build/tests/plugins/constants/snapshots/tests.js.snap b/packages/build/tests/plugins/constants/snapshots/tests.js.snap index 5bab7d63a2..81c9192ce3 100644 Binary files a/packages/build/tests/plugins/constants/snapshots/tests.js.snap and b/packages/build/tests/plugins/constants/snapshots/tests.js.snap differ diff --git a/packages/build/tests/plugins/duplicate/snapshots/tests.js.snap b/packages/build/tests/plugins/duplicate/snapshots/tests.js.snap index eaac36c81e..eac525af19 100644 Binary files a/packages/build/tests/plugins/duplicate/snapshots/tests.js.snap and b/packages/build/tests/plugins/duplicate/snapshots/tests.js.snap differ diff --git a/packages/build/tests/plugins/env/snapshots/tests.js.snap b/packages/build/tests/plugins/env/snapshots/tests.js.snap index e7ef5cf32b..c461380d5a 100644 Binary files a/packages/build/tests/plugins/env/snapshots/tests.js.snap and b/packages/build/tests/plugins/env/snapshots/tests.js.snap differ diff --git a/packages/build/tests/plugins/functions/snapshots/tests.js.snap b/packages/build/tests/plugins/functions/snapshots/tests.js.snap index e0cd211bba..eceedc8c4b 100644 Binary files a/packages/build/tests/plugins/functions/snapshots/tests.js.snap and b/packages/build/tests/plugins/functions/snapshots/tests.js.snap differ diff --git a/packages/build/tests/plugins/install/snapshots/tests.js.snap b/packages/build/tests/plugins/install/snapshots/tests.js.snap index c8544e84fc..75d00d7fa2 100644 Binary files a/packages/build/tests/plugins/install/snapshots/tests.js.snap and b/packages/build/tests/plugins/install/snapshots/tests.js.snap differ diff --git a/packages/build/tests/plugins/load/snapshots/tests.js.md b/packages/build/tests/plugins/load/snapshots/tests.js.md index 438b0cd9be..512384ef5f 100644 --- a/packages/build/tests/plugins/load/snapshots/tests.js.md +++ b/packages/build/tests/plugins/load/snapshots/tests.js.md @@ -282,40 +282,6 @@ Generated by [AVA](https://ava.li). Have a nice day!␊ ` -## Missing plugins - -> Snapshot 1 - - `␊ - > Starting Netlify Build v1.0.0␊ - https://github.com/netlify/build␊ - ␊ - > Flags␊ - { config: '/file/path' }␊ - ␊ - > Current directory␊ - /file/path␊ - ␊ - > Config file␊ - /file/path␊ - ␊ - Error: 'does-not-exist' plugin not installed or found.␊ - Please install it with npm or yarn.␊ - Cannot find module 'does-not-exist' from '/file/path'␊ - ␊ - ␊ - ┌─────────────────────────────┐␊ - │ Netlify Build Error │␊ - └─────────────────────────────┘␊ - ␊ - Error: Command failed with exit code 1: npm install --no-progress --no-audit --no-fund does-not-exist␊ - STACK TRACE␊ - ␊ - ┌─────────────────────────────┐␊ - │ END Netlify Build Error │␊ - └─────────────────────────────┘␊ - ` - ## Node module plugins > Snapshot 1 diff --git a/packages/build/tests/plugins/load/snapshots/tests.js.snap b/packages/build/tests/plugins/load/snapshots/tests.js.snap index f133f61de8..fc4c8ffd24 100644 Binary files a/packages/build/tests/plugins/load/snapshots/tests.js.snap and b/packages/build/tests/plugins/load/snapshots/tests.js.snap differ diff --git a/packages/build/tests/plugins/validate/snapshots/tests.js.snap b/packages/build/tests/plugins/validate/snapshots/tests.js.snap index 463ab3ccea..d4b17dd58f 100644 Binary files a/packages/build/tests/plugins/validate/snapshots/tests.js.snap and b/packages/build/tests/plugins/validate/snapshots/tests.js.snap differ diff --git a/packages/build/tests/utils/cache/snapshots/tests.js.snap b/packages/build/tests/utils/cache/snapshots/tests.js.snap index 04f8ebf426..71dc9b8536 100644 Binary files a/packages/build/tests/utils/cache/snapshots/tests.js.snap and b/packages/build/tests/utils/cache/snapshots/tests.js.snap differ diff --git a/packages/build/tests/utils/git/snapshots/tests.js.snap b/packages/build/tests/utils/git/snapshots/tests.js.snap index 7ff42d4ac9..c26936c7bf 100644 Binary files a/packages/build/tests/utils/git/snapshots/tests.js.snap and b/packages/build/tests/utils/git/snapshots/tests.js.snap differ diff --git a/packages/build/tests/utils/load/snapshots/tests.js.snap b/packages/build/tests/utils/load/snapshots/tests.js.snap index 36e659907a..075eec6b7d 100644 Binary files a/packages/build/tests/utils/load/snapshots/tests.js.snap and b/packages/build/tests/utils/load/snapshots/tests.js.snap differ diff --git a/packages/build/tests/utils/run/snapshots/tests.js.snap b/packages/build/tests/utils/run/snapshots/tests.js.snap index 1e978ad32e..bace7390da 100644 Binary files a/packages/build/tests/utils/run/snapshots/tests.js.snap and b/packages/build/tests/utils/run/snapshots/tests.js.snap differ