-
Notifications
You must be signed in to change notification settings - Fork 394
fix: update got & remove outdated workaround #5437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -20,19 +10,6 @@ const extendedGot = got.extend({ | |||
statusCodes: STATUS_CODE, | |||
}, | |||
timeout: TIMEOUT, | |||
// TODO: remove when https://github.com/sindresorhus/got/issues/1489 is fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note here: Issue was resolved in sindresorhus/got#2187 so this workaround suggested in sindresorhus/got#1489 (comment) is no longer needed.
📊 Benchmark resultsComparing with 78a1932 Package size: 265 MB(no change)
Legend
|
Note: This PR won't result in any change in |
Really nice, thanks. |
🎉 Thanks for submitting a pull request! 🎉
Summary
Partial fix to #4921 & #2744
This PR updates
got
to a non-vulnerable version & removes a workaround that's no longer needed after the update.For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)