Skip to content

Add a title to the generate iframe #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mark-making opened this issue Sep 20, 2019 · 3 comments
Closed

Add a title to the generate iframe #199

mark-making opened this issue Sep 20, 2019 · 3 comments

Comments

@mark-making
Copy link
Contributor

mark-making commented Sep 20, 2019

To ensure an accessible web, and for the sake of passing accessibility audits, please can we set the title for the generated iframe? Looking through the code it would be similar to how the id is set.

iframe.id = "netlify-identity-widget";

iframe.title = "Netlify identity widget";

@swyxio
Copy link
Contributor

swyxio commented Sep 20, 2019

pr welcome

@steveperrito
Copy link

Chrome's Lighthouse tab made me aware of this issue. I solved this in my Vue app with a simple check that seems to be working for me:

// in main.js
import netlifyIdentity from 'netlify-identity-widget';

let netlifyIdentityWidgetIframe = document.getElementById('netlify-identity-widget');

if (!netlifyIdentityWidgetIframe) {
  netlifyIdentity.init();
}

@jlengstorf
Copy link
Contributor

this was closed by #200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants