chore: update tooling (#241)

BREAKING CHANGE: support for node 8 was dropped

Author: erezrokah

.eslintrc.js

@@ -0,0 +1,16 @@
+module.exports = {
+  env: {
+    commonjs: true,
+    es6: true,
+    node: true,
+    jest: true,
+  },
+  extends: 'eslint:recommended',
+  globals: {
+    Atomics: 'readonly',
+    SharedArrayBuffer: 'readonly',
+  },
+  parserOptions: {
+    ecmaVersion: 11,
+  },
+};

.github/workflows/test.yml

@@ -0,0 +1,46 @@
+name: Node CI
+
+on:
+  push:
+    branches:
+      - master
+    tags:
+      - '*'
+
+  pull_request:
+    types: [opened, synchronize, reopened]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        os: [macos-latest, ubuntu-latest, windows-latest]
+        node-version: [10.x, 12.x, 13.x]
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node-version }}
+      - name: Get npm cache directory
+        id: npm-cache
+        run: |
+          echo "::set-output name=dir::$(npm config get cache)"
+      - uses: actions/cache@v2
+        with:
+          path: ${{ steps.npm-cache.outputs.dir }}
+          key: ${{ runner.os }}-node-${{ matrix.node-version }}-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-${{ matrix.node-version }}-
+      - name: log versions
+        run: node --version && npm --version
+      - name: install dependencies
+        run: npm ci
+      - name: run linter
+        run: npm run lint
+      - name: check formatting
+        run: npm run format:ci
+      - name: run tests
+        run: npm test

.gitignore

@@ -1,5 +1,4 @@
 node_modules/
 .vscode/
 *.swp
-package-lock.json
 .temp

.prettierrc

@@ -1 +1,15 @@
-{}
+{
+    "printWidth": 80,
+    "tabWidth": 2,
+    "semi": true,
+    "singleQuote": true,
+    "trailingComma": "all",
+    "useTabs": false,
+    "overrides": [
+      {
+        "files": "*.json",
+        "options": { "printWidth": 200 }
+      }
+    ]
+  }
+  

bin/cmd.js

@@ -4,61 +4,61 @@
  * Module dependencies.
  */
 
-var program = require("commander");
-var fs = require("fs");
-var path = require("path");
+var program = require('commander');
+var fs = require('fs');
+var path = require('path');
 var pkg = JSON.parse(
-  fs.readFileSync(path.join(__dirname, "..", "package.json"))
+  fs.readFileSync(path.join(__dirname, '..', 'package.json')),
 );
-var build = require("../lib/build");
-var serve = require("../lib/serve");
-var install = require("../lib/install");
+var build = require('../lib/build');
+var serve = require('../lib/serve');
+var install = require('../lib/install');
 
 program.version(pkg.version);
 
-const stringBooleanToBoolean = val => {
+const stringBooleanToBoolean = (val) => {
   console.log({ val });
-  if (typeof val !== "string" && (val !== "true" || val !== "false")) {
+  if (typeof val !== 'string' && (val !== 'true' || val !== 'false')) {
     throw Error(`Incorrect string value: ${val}`);
   }
 
-  return val === "true";
+  return val === 'true';
 };
 
 program
-  .option("-c --config <webpack-config>", "additional webpack configuration")
-  .option("-p --port <port>", "port to serve from (default: 9000)")
+  .option('-c --config <webpack-config>', 'additional webpack configuration')
+  .option('-p --port <port>', 'port to serve from (default: 9000)')
   .option(
-    "-b --babelrc <babelrc>",
-    "use .babelrc in root (default: true)",
-    stringBooleanToBoolean
+    '-b --babelrc <babelrc>',
+    'use .babelrc in root (default: true)',
+    stringBooleanToBoolean,
   )
   .option(
-    "-t --timeout <timeout>",
-    "function invocation timeout in seconds (default: 10)"
+    '-t --timeout <timeout>',
+    'function invocation timeout in seconds (default: 10)',
   )
-  .option("-s --static", "serve pre-built lambda files");
+  .option('-s --static', 'serve pre-built lambda files');
 
 program
-  .command("serve <dir>")
-  .description("serve and watch functions")
-  .action(function(cmd, options) {
-    console.log("netlify-lambda: Starting server");
+  .command('serve <dir>')
+  .description('serve and watch functions')
+  .action(function (cmd) {
+    console.log('netlify-lambda: Starting server');
     var static = Boolean(program.static);
     var server;
-    var startServer = function() {
+    var startServer = function () {
       server = serve.listen(
         program.port || 9000,
         static,
-        Number(program.timeout) || 10
+        Number(program.timeout) || 10,
       );
     };
     if (static) {
       startServer();
       return; // early terminate, don't build
     }
     const { config: userWebpackConfig, babelrc: useBabelrc = true } = program;
-    build.watch(cmd, { userWebpackConfig, useBabelrc }, function(err, stats) {
+    build.watch(cmd, { userWebpackConfig, useBabelrc }, function (err, stats) {
       if (err) {
         console.error(err);
         return;
@@ -67,47 +67,47 @@ program
       if (!server) {
         startServer();
       }
-      stats.compilation.chunks.forEach(function(chunk) {
+      stats.compilation.chunks.forEach(function (chunk) {
         server.clearCache(chunk.name || chunk.id.toString());
       });
     });
   });
 
 program
-  .command("build <dir>")
-  .description("build functions")
-  .action(function(cmd, options) {
-    console.log("netlify-lambda: Building functions");
+  .command('build <dir>')
+  .description('build functions')
+  .action(function (cmd) {
+    console.log('netlify-lambda: Building functions');
 
     const { config: userWebpackConfig, babelrc: useBabelrc = true } = program;
     build
       .run(cmd, { userWebpackConfig, useBabelrc })
-      .then(function(stats) {
+      .then(function (stats) {
         console.log(stats.toString(stats.compilation.options.stats));
       })
-      .catch(function(err) {
+      .catch(function (err) {
         console.error(err);
         process.exit(1);
       });
   });
 
 program
-  .command("install [dir]")
-  .description("install functions")
-  .action(function(cmd, options) {
-    console.log("netlify-lambda: installing function dependencies");
-    install.run(cmd).catch(function(err) {
+  .command('install [dir]')
+  .description('install functions')
+  .action(function (cmd) {
+    console.log('netlify-lambda: installing function dependencies');
+    install.run(cmd).catch(function (err) {
       console.error(err);
       process.exit(1);
     });
   });
 
 // error on unknown commands
 // ref: https://github.com/tj/commander.js#custom-event-listeners
-program.on("command:*", function() {
+program.on('command:*', function () {
   console.error(
-    "Invalid command: %s\nSee --help for a list of available commands.",
-    program.args.join(" ")
+    'Invalid command: %s\nSee --help for a list of available commands.',
+    program.args.join(' '),
   );
   process.exit(1);
 });

commitlint.config.js

@@ -0,0 +1 @@
+module.exports = { extends: ['@commitlint/config-conventional'] };