fix: move files to build cache after files are uploaded instead of copying them before uploads (#753)

* fix: move files to cache after upload instead of copying them before

* chore: edit demo site a bit to ensure caching changes continue to work

* chore: add heavy files for testing purposes

* fix: skip storing build cache when cli is used

* revert: remove debug changes

* chore: drop debug console logs

* fix: also move when restoring cache

* test: use older node (for gatsby v3)

* fix: restoreCache types

* fix: ensure all build step hooks have typed arguments

* test: relax content-type check a bit

* test: pin netlify-cli

* test: use latest v5, log output on failure

* chore: upgrade @netlify/build

Author: pieh

Diff for: .github/workflows/test.yml

@@ -14,7 +14,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: '*'
+          node-version: '18'
       - name: Global Node packages cache
         uses: actions/cache@v3
         with:
@@ -29,7 +29,7 @@ jobs:
           key:
             ubuntu-build-${{ env.cache-name }}-${{
             hashFiles('plugin/test/fixtures/**/package.json') }}-node-modules
-      - run: npm install -g netlify-cli
+      - run: npm install -g netlify-cli@18.0.0
       - run: npm ci
       - run: cd plugin && npm ci && npm run build
       - run: npm test
@@ -56,7 +56,7 @@ jobs:
           key:
             macOS-build-${{ env.cache-name }}-${{
             hashFiles('plugin/test/fixtures/**/package.json') }}-node-modules
-      - run: npm install -g netlify-cli
+      - run: npm install -g netlify-cli@18.0.0
       - run: npm ci
       - run: cd plugin && npm ci && npm run build
       - run: npm test

Diff for: demo-v5/package.json

@@ -21,7 +21,7 @@
   },
   "dependencies": {
     "@sindresorhus/slugify": "^1.1.2",
-    "gatsby": "next",
+    "gatsby": "5.11.0",
     "gatsby-plugin-image": "next",
     "gatsby-plugin-sharp": "next",
     "gatsby-source-filesystem": "next",

Diff for: package-lock.json

@@ -40,7 +40,7 @@
     "prettier": "--loglevel=warn \"{plugin,demo,.github}/**/*.{ts,js,md,yml,json,html}\" \"*.{ts,js,yml,json,html}\" \".*.{ts,js,yml,json,html}\" \"!package-lock.json\""
   },
   "devDependencies": {
-    "@netlify/build": "^29.36.1",
+    "@netlify/build": "^29.58.7",
     "@netlify/eslint-config-node": "7.0.1",
     "@types/jest": "^29.0.0",
     "ava": "^5.0.0",