Merge pull request #45 from netlify/error-invalid-filename-chars

Check for invalid characters instead of escaping

Author: brycekahle

go/porcelain/deploy.go

@@ -10,7 +10,6 @@ import (
 	"hash"
 	"io"
 	"io/ioutil"
-	"net/url"
 	"os"
 	"path/filepath"
 	"strings"
@@ -179,6 +178,12 @@ func (n *Netlify) DoDeploy(ctx context.Context, options *DeployOptions, deploy *
 		}
 		return nil, err
 	}
+	for name := range files.Files {
+		if strings.ContainsAny(name, "#?") {
+			return nil, fmt.Errorf("Invalid filename '%s'. Deployed filenames cannot contain # or ? characters", name)
+		}
+	}
+
 	options.files = files
 
 	functions, err := bundle(options.FunctionsDir, options.Observer)
@@ -399,8 +404,7 @@ func (n *Netlify) uploadFile(ctx context.Context, d *models.Deploy, f *FileBundl
 
 		switch t {
 		case fileUpload:
-			name := (&url.URL{Path: f.Name}).EscapedPath()
-			params := operations.NewUploadDeployFileParams().WithDeployID(d.ID).WithPath(name).WithFileBody(f)
+			params := operations.NewUploadDeployFileParams().WithDeployID(d.ID).WithPath(f.Name).WithFileBody(f)
 			if timeout != 0 {
 				params.SetTimeout(timeout)
 			}