go-client: Don’t poll deploy after upload

bcomnes · bcomnes · commit 0c86ceaf8946 · 2019-03-07T11:18:31.000-08:00
We decided we no longer need to poll here.  The reason we were polling was to fail the build prior to cache creation.  

This change, essentially allows for cache creation even if tree operations fail later, which is our fault most likely.
diff --git a/go/porcelain/deploy.go b/go/porcelain/deploy.go
@@ -290,7 +290,7 @@ func (n *Netlify) DoDeploy(ctx context.Context, options *DeployOptions, deploy *
 		}
 	}
 
-	return n.WaitForDeployComplete(ctx, deploy, options.DoneProcessingTimeout)
+	return deploy, nil
 }
 
 func (n *Netlify) waitForState(ctx context.Context, d *models.Deploy, timeout time.Duration, states ...string) (*models.Deploy, error) {

Original file line number	Diff line number	Diff line change
`@@ -290,7 +290,7 @@ func (n Netlify) DoDeploy(ctx context.Context, options DeployOptions, deploy *`
`290`	`290`	`}`
`291`	`291`	`}`
`292`	`292`
`293`		`- return n.WaitForDeployComplete(ctx, deploy, options.DoneProcessingTimeout)`
	`293`	`+ return deploy, nil`
`294`	`294`	`}`
`295`	`295`
`296`	`296`	`func (n Netlify) waitForState(ctx context.Context, d models.Deploy, timeout time.Duration, states ...string) (*models.Deploy, error) {`