-
Notifications
You must be signed in to change notification settings - Fork 94
feat: add feature_flags parameter to the getSite endpoint #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for open-api ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@mraerino I've updated to the newer version of redoc cli (the version we were using was deprecated) - and now this allows for us to filter out properties & methods with I'm also seeing that the "Verify Go client" job is failing - I know nothing about Go - what do I need to do here to be able to run |
I ran
I think it was something like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x-internal
s are not visible in the deploy preview 👍
https://deploy-preview-466--open-api.netlify.app/#tag/site/operation/getSite
Adds to the swagger documentation the ability to pass in a
feature_flags
parameter to thegetSite
api, which will return a list of feature flags and whether or not they are enabled.Unsure about the values, but went off of this definition: https://github.com/netlify/bitballoon/pull/15495/files#diff-c7977f571d39c09cf8480243e53e44eb1c40acfc7fcb1d76446222e28de96478R100
Also unsure about how to mark as
x-internal
, as elsewhere in the swagger, only endpoints are set withtags: [x-internal]
, not parameters.Depends on: https://github.com/netlify/bitballoon/pull/15495
Related: https://github.com/netlify/pod-dev-foundations/issues/519