fix: al2 uploads need to have function name in SHA #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for open-api ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JGAntunes
reviewed
Oct 27, 2023
go/porcelain/deploy.go
Outdated
| @@ -979,6 +979,7 @@ func createHeader(archive *zip.Writer, i os.FileInfo, runtime string) (io.Writer | |||
| return archive.CreateHeader(&zip.FileHeader{ | |||
| CreatorVersion: 3 << 8, // indicates Unix | |||
| ExternalAttrs: 0777 << 16, // -rwxrwxrwx file permissions | |||
| Comment: i.Name(), | |||
There was a problem hiding this comment.
Tiny one, but could we add a comment here so that future us are not 🤯 trying to figure out why?
There was a problem hiding this comment.
yes! done in 22d8ab9
mraerino
approved these changes
Oct 30, 2023
Skn0tt
added a commit
that referenced
this pull request
Oct 30, 2023
Skn0tt
added a commit
that referenced
this pull request
Oct 30, 2023
fix: trigger patch release for #509
Skn0tt
added a commit
that referenced
this pull request
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a detailed writeup of why this is necessary in https://linear.app/netlify/issue/COM-95/bug-what-happens-when-we-upload-two-functions-with-the-exact-identical.
In short: Netlify requires two different functions to have separate hashsums. Before, this was the case because every ZIP contained the function name as the entrypoint filename. With the changes in #505, this will now always be
bootstrap, so it doesn't effect the hashsum anymore. By adding the filename as a comment, we get back this behaviour.