Skip to content

No read/delete for deploy keys? #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mitchellh opened this issue Dec 7, 2017 · 2 comments
Closed

No read/delete for deploy keys? #52

mitchellh opened this issue Dec 7, 2017 · 2 comments

Comments

@mitchellh
Copy link

I'm working on a Terraform provider and noticed there is no read/delete endpoints for deploy keys.

The primary sketchy thing about this for me is that Terraform can't verify that a deploy key is still valid.

From a Netlify PoV, we'll likely be running nightly acceptance tests at some point that could create dozens if not a hundred or more deploy keys. Is it okay that these grow unbounded?
@calavera calavera mentioned this issue Dec 7, 2017
Merged
@calavera
Copy link
Contributor

calavera commented Dec 7, 2017

I just added those missing endpoints @mitchellh 🙌

@mitchellh
Copy link
Author

Great! Thanks. Implemented now and works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@calavera @mitchellh