Skip to content

Commit 1a00421

Browse files
netromdkBrandon Davis
authored and
Brandon Davis
committed
Require Python 3.4+ and also test with Travis
- abc.ABC requires 3.4 - urllib3 depends on module _implemetation that isn't in 3.1 - Found some syntax errors when installing env for 3.1+3.2
1 parent 82760d4 commit 1a00421

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.travis.yml

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ sudo: false
22
language: python
33
python:
44
- '3.5'
5+
- '3.4'
56
- '3.6'
67
- nightly
78
install:

Makefile

+4-4
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ clean:
88
find . -iname __pycache__ | xargs rm -fr
99

1010
check-python-version:
11-
@python3 -c 'import sys; sys.exit(0) if sys.version_info >= (3, 0) else sys.exit(1)'; \
12-
if [ $$? -ne 0 ] ; then echo "Python 3 required"; exit 1 ; fi
11+
@python3 -c 'import sys; sys.exit(0) if sys.version_info >= (3, 4) else sys.exit(1)'; \
12+
if [ $$? -ne 0 ] ; then echo "Python 3.4 required"; exit 1 ; fi
1313

1414
install: uninstall
1515
ln -s "`pwd`/slacker.sh" /usr/local/bin/slacker
@@ -27,8 +27,8 @@ check-style:
2727
flake8 --ignore E111,E114,E121,E126,E302 --max-line-length 100 --count --show-source \
2828
slacker slacker.py
2929

30-
static_analysis:
30+
static-analysis:
3131
vulture --min-confidence 60 --sort-by-size --exclude slacker/commands/__init__.py \
3232
slacker slacker.py .vulture_whitelist.py
3333

34-
check: check-cmds check-style static_analysis
34+
check: check-cmds check-style static-analysis

0 commit comments

Comments
 (0)