Skip to content

Commit 9415503

Browse files
authored
fix: Updated messaging example instrumentation file (#304)
Signed-off-by: mrickard <[email protected]>
1 parent e16933c commit 9415503

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

custom-instrumentation/instrument-messages/instrumentation.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,13 @@ function instrumentNiftyMessages(shim, messages, moduleName) {
8585
shim.recordConsume(Client.prototype, 'getMessage', new shim.specs.MessageSpec({
8686
destinationName: shim.FIRST,
8787
callback: shim.LAST,
88-
after({ args }) {
89-
const [err, msg] = args
90-
if (msg) {
88+
after({ result, error }) {
89+
if (result) {
9190
console.log(
92-
`[NEWRELIC] getMessage on queue ${msg.queueName} returned a message: '${msg.msg}'`
91+
`[NEWRELIC] getMessage on queue ${result.queueName} returned a message: '${result.msg}'`
9392
)
9493
// misc key/value parameters can be recorded as a part of the trace segment
95-
const params = { message: msg.msg, queueName: msg.queueName }
94+
const params = { message: result.msg, queueName: result.queueName }
9695

9796
return {
9897
parameters: params
@@ -101,7 +100,7 @@ function instrumentNiftyMessages(shim, messages, moduleName) {
101100

102101
console.log('[NEWRELIC] getMessage returned no message')
103102
return {
104-
parameters: { err }
103+
parameters: { err: error }
105104
}
106105
}
107106
}))
@@ -155,4 +154,4 @@ function instrumentNiftyMessages(shim, messages, moduleName) {
155154
parameters: params
156155
})
157156
})
158-
}
157+
}

custom-instrumentation/instrument-messages/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"license": "ISC",
1313
"dependencies": {
1414
"express": "^4.19.2",
15-
"newrelic": "^12.0.0"
15+
"newrelic": "^12.5.0"
1616
},
1717
"devDependencies": {
1818
"@newrelic/eslint-config": "^0.2.0"

0 commit comments

Comments
 (0)