Merge pull request #3110 from tan-linx/dev

Fixes NoMethodError: undefined method `queue_name' for nil in ActiveJobSubscriber when using perform_all_later.

Author: hannahramadan

lib/new_relic/agent/instrumentation/active_job_subscriber.rb

@@ -8,16 +8,20 @@ module NewRelic
   module Agent
     module Instrumentation
       class ActiveJobSubscriber < NotificationsSubscriber
-        PAYLOAD_KEYS = %i[adapter db_runtime error job wait]
+        PAYLOAD_KEYS = %i[adapter db_runtime error job wait jobs]
 
         def add_segment_params(segment, payload)
           PAYLOAD_KEYS.each do |key|
             segment.params[key] = payload[key] if payload.key?(key)
           end
         end
 
+        # NOTE: For `enqueue_all.active_job`, only the first job is used to determine the queue.
+        # Therefore, this assumes all jobs given as arguments for perform_all_later share the same queue.
         def metric_name(name, payload)
-          queue = payload[:job].queue_name
+          job = payload[:job] || payload[:jobs].first
+
+          queue = job.queue_name
           method = method_from_name(name)
           "Ruby/ActiveJob/#{queue}/#{method}"
         end

test/new_relic/agent/instrumentation/rails/active_job_subscriber.rb

@@ -35,6 +35,11 @@ def test_segment_naming_with_unknown_method
         SUBSCRIBER.send(:metric_name, 'indecipherable', {job: TestJob.new})
     end
 
+    def test_segment_naming_multiple_jobs
+      assert_equal 'Ruby/ActiveJob/default/Unknown',
+        SUBSCRIBER.send(:metric_name, 'indecipherable', {jobs: [TestJob.new, TestJob.new]})
+    end
+
     # perform.active_job
     def test_perform_active_job
       job = TestJob.new