[elasticsearch] remove masterTerminationFix (elastic#1183)

* [elasticsearch] fix values table formatting

* [elasticsearch] remove masterTerminationFix

This commit removes the `masterTerminationFix` side-car container
introduced in elastic#63 to fix slow elections issues when master node is
deleted. This workaround is no more needed since Elasticsearch 7.2.

Author: nflaig

elasticsearch/README.md

@@ -160,6 +160,7 @@ support multiple versions with minimal changes.
 | `secretMounts`                     | Allows you easily mount a secret as a file inside the StatefulSet. Useful for mounting certificates and other secrets. See [values.yaml][] for an example                                                                                                                                                         | `[]`                                             |
 | `securityContext`                  | Allows you to set the [securityContext][] for the container                                                                                                                                                                                                                                                       | see [values.yaml][]                              |
 | `service.annotations`              | [LoadBalancer annotations][] that Kubernetes will use for the service. This will configure load balancer if `service.type` is `LoadBalancer`                                                                                                                                                                      | `{}`                                             |
+| `service.enabled`                  | Enable non-headless service                                                                                                                                                                                                                                                                                       | `true`                                           |
 | `service.externalTrafficPolicy`    | Some cloud providers allow you to specify the [LoadBalancer externalTrafficPolicy][]. Kubernetes will use this to preserve the client source IP. This will configure load balancer if `service.type` is `LoadBalancer`                                                                                            | `""`                                             |
 | `service.httpPortName`             | The name of the http port within the service                                                                                                                                                                                                                                                                      | `http`                                           |
 | `service.labelsHeadless`           | Labels to be added to headless service                                                                                                                                                                                                                                                                            | `{}`                                             |

elasticsearch/templates/service.yaml

@@ -1,4 +1,5 @@
 ---
+{{- if .Values.service.enabled -}}
 kind: Service
 apiVersion: v1
 metadata:
@@ -43,6 +44,7 @@ spec:
 {{- if .Values.service.externalTrafficPolicy }}
   externalTrafficPolicy: {{ .Values.service.externalTrafficPolicy }}
 {{- end }}
+{{- end }}
 ---
 kind: Service
 apiVersion: v1

elasticsearch/values.yaml

@@ -180,6 +180,7 @@ httpPort: 9200
 transportPort: 9300
 
 service:
+  enabled: true
   labels: {}
   labelsHeadless: {}
   type: ClusterIP