Skip to content

Commit eb1bf23

Browse files
Update Kingfisher 6.x to 7.x (#98)
Upgrade Kingfisher library to 7.x
1 parent 7c0e505 commit eb1bf23

File tree

6 files changed

+48
-32
lines changed

6 files changed

+48
-32
lines changed

Diff for: CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,12 @@ All notable changes to this project will be documented in this file.
33
Adheres to [Semantic Versioning](http://semver.org/).
44

55
---
6+
## Pending on develop
7+
8+
##### Bug Fixes
9+
* Update Kingfisher library to latest 7.x.
10+
* Update references to Kingfisher's `ImageResource` struct because Xcode 15 introduced a conflicting `ImageResource` symbol.
11+
612
## 4.0.6
713

814
##### Features
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
3+
<plist version="1.0">
4+
<dict>
5+
<key>IDEDidComputeMac32BitWarning</key>
6+
<true/>
7+
</dict>
8+
</plist>

Diff for: Mage/AttachmentUIImageView.swift

+3-3
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ import Kingfisher
193193
largeUrl = URL(string: String(format: "%@_large", attachmentUrl)) ?? url
194194
}
195195
DispatchQueue.main.async {
196-
let resource = Kingfisher.ImageResource(downloadURL: self.getAttachmentUrl(size: self.getImageSize())!, cacheKey: largeUrl.absoluteString)
196+
let resource = KF.ImageResource(downloadURL: self.getAttachmentUrl(size: self.getImageSize())!, cacheKey: largeUrl.absoluteString)
197197
self.kf.setImage(with: resource, placeholder: placeholder, options: options, progressBlock: progressBlock) { result in
198198

199199
switch result {
@@ -211,7 +211,7 @@ import Kingfisher
211211
} else {
212212
// Have to do this so that the placeholder image shows up behind the activity indicator
213213
DispatchQueue.main.async {
214-
let resource = Kingfisher.ImageResource(downloadURL: self.getAttachmentUrl(size: self.getImageSize())!, cacheKey: thumbUrl.absoluteString)
214+
let resource = KF.ImageResource(downloadURL: self.getAttachmentUrl(size: self.getImageSize())!, cacheKey: thumbUrl.absoluteString)
215215
self.kf.setImage(with: resource, placeholder: placeholder, options: options, progressBlock: progressBlock) { result in
216216

217217
switch result {
@@ -237,7 +237,7 @@ import Kingfisher
237237
if let attachmentUrl = self.attachment?.url {
238238
largeUrl = URL(string: String(format: "%@_large", attachmentUrl)) ?? url
239239
}
240-
let resource = Kingfisher.ImageResource(downloadURL: self.getAttachmentUrl(size: getImageSize())!, cacheKey: largeUrl.absoluteString)
240+
let resource = KF.ImageResource(downloadURL: self.getAttachmentUrl(size: getImageSize())!, cacheKey: largeUrl.absoluteString)
241241

242242
placeholder.kf.setImage(with: resource, options: options) { result in
243243

Diff for: Podfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def common_pods
1414
pod 'DateTools', '~> 2.0.0'
1515
pod 'MaterialComponents'
1616
pod 'MDFInternationalization'
17-
pod 'Kingfisher', '~> 6'
17+
pod 'Kingfisher', '~> 7.0'
1818
pod 'PureLayout'
1919
pod "AFNetworking", "~> 4.0.1"
2020
pod "DateTools", "~> 2.0.0"

Diff for: Podfile.lock

+5-5
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ PODS:
3333
- KIF (3.8.9):
3434
- KIF/Core (= 3.8.9)
3535
- KIF/Core (3.8.9)
36-
- Kingfisher (6.3.1)
36+
- Kingfisher (7.10.1)
3737
- libPhoneNumber-iOS (0.9.15)
3838
- MagicalRecord (2.3.2):
3939
- MagicalRecord/Core (= 2.3.2)
@@ -734,7 +734,7 @@ DEPENDENCIES:
734734
- geopackage-ios (~> 8.0.4)
735735
- HexColors (~> 4.0.0)
736736
- KIF
737-
- Kingfisher (~> 6)
737+
- Kingfisher (~> 7.0)
738738
- libPhoneNumber-iOS (~> 0.9.15)
739739
- MagicalRecord (~> 2.3.2)
740740
- MaterialComponents
@@ -809,7 +809,7 @@ SPEC CHECKSUMS:
809809
grid-ios: a86f1d0e90c6ae2721ec3abcf1763a2d300ab19b
810810
HexColors: 5f95843ef89aff6a72e1fd3a8ebabf205cc43379
811811
KIF: 7660c626b0f2d4562533590960db70a36d640558
812-
Kingfisher: 016c8b653a35add51dd34a3aba36b580041acc74
812+
Kingfisher: bc5abe80a8e0144537ef1dd5a0b2621b04f7f439
813813
libPhoneNumber-iOS: 0a32a9525cf8744fe02c5206eb30d571e38f7d75
814814
MagicalRecord: 53bed74b4323b930992a725be713e53b37d19755
815815
MaterialComponents: 1a9b2d9d45b1601ae544de85089adc4c464306d4
@@ -837,6 +837,6 @@ SPEC CHECKSUMS:
837837
UIImage-Categories: 5103b772ae91894f4d650eb696b006f4a2487ec3
838838
zxcvbn-ios: fef98b7c80f1512ff0eec47ac1fa399fc00f7e3c
839839

840-
PODFILE CHECKSUM: 1683a1f1f6e7a14f370fb9f7f3f7688e8c9a038e
840+
PODFILE CHECKSUM: 89eca234d687507258e09eaade442fa4c43c1e1f
841841

842-
COCOAPODS: 1.14.2
842+
COCOAPODS: 1.12.1

Diff for: sdk/Model1To15.xcmappingmodel/xcmapping.xml

+25-23
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<plist version="1.0">
1111
<dict>
1212
<key>NSPersistenceFrameworkVersion</key>
13-
<integer>866</integer>
13+
<integer>1251</integer>
1414
<key>NSStoreModelVersionHashes</key>
1515
<dict>
1616
<key>XDDevAttributeMapping</key>
@@ -34,6 +34,8 @@
3434
akYY9LhehVA/mCb4ATLWuI9XGLcjpm14wWL1oEBtIcs=
3535
</data>
3636
</dict>
37+
<key>NSStoreModelVersionHashesDigest</key>
38+
<string>+Hmc2uYZK6og+Pvx5GUJ7oW75UG4V/ksQanTjfTKUnxyGWJRMtB5tIRgVwGsrd7lz/QR57++wbvWsr6nxwyS0A==</string>
3739
<key>NSStoreModelVersionHashesVersion</key>
3840
<integer>3</integer>
3941
<key>NSStoreModelVersionIdentifiers</key>
@@ -58,11 +60,11 @@
5860
</object>
5961
<object type="XDDEVENTITYMAPPING" id="z105">
6062
<attribute name="mappingtypename" type="string">Undefined</attribute>
61-
<attribute name="mappingnumber" type="int16">10</attribute>
63+
<attribute name="mappingnumber" type="int16">8</attribute>
6264
<attribute name="destinationname" type="string">StaticLayer</attribute>
6365
<attribute name="autogenerateexpression" type="bool">1</attribute>
6466
<relationship name="mappingmodel" type="1/1" destination="XDDEVMAPPINGMODEL" idrefs="z173"></relationship>
65-
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z166 z145 z108 z186 z182 z161 z111 z116 z192 z165 z132"></relationship>
67+
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z111 z108 z166 z161 z182 z186 z116 z145 z192 z165 z132"></relationship>
6668
<relationship name="relationshipmappings" type="0/0" destination="XDDEVRELATIONSHIPMAPPING"></relationship>
6769
</object>
6870
<object type="XDDEVATTRIBUTEMAPPING" id="z106">
@@ -103,11 +105,11 @@
103105
</object>
104106
<object type="XDDEVENTITYMAPPING" id="z115">
105107
<attribute name="mappingtypename" type="string">Undefined</attribute>
106-
<attribute name="mappingnumber" type="int16">12</attribute>
108+
<attribute name="mappingnumber" type="int16">10</attribute>
107109
<attribute name="destinationname" type="string">ObservationFavorite</attribute>
108110
<attribute name="autogenerateexpression" type="bool">1</attribute>
109111
<relationship name="mappingmodel" type="1/1" destination="XDDEVMAPPINGMODEL" idrefs="z173"></relationship>
110-
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z212 z194 z170"></relationship>
112+
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z170 z212 z194"></relationship>
111113
<relationship name="relationshipmappings" type="0/0" destination="XDDEVRELATIONSHIPMAPPING" idrefs="z118"></relationship>
112114
</object>
113115
<object type="XDDEVATTRIBUTEMAPPING" id="z116">
@@ -150,7 +152,7 @@
150152
</object>
151153
<object type="XDDEVENTITYMAPPING" id="z125">
152154
<attribute name="mappingtypename" type="string">Undefined</attribute>
153-
<attribute name="mappingnumber" type="int16">6</attribute>
155+
<attribute name="mappingnumber" type="int16">5</attribute>
154156
<attribute name="destinationname" type="string">Server</attribute>
155157
<attribute name="autogenerateexpression" type="bool">1</attribute>
156158
<relationship name="mappingmodel" type="1/1" destination="XDDEVMAPPINGMODEL" idrefs="z173"></relationship>
@@ -163,11 +165,11 @@
163165
</object>
164166
<object type="XDDEVENTITYMAPPING" id="z127">
165167
<attribute name="mappingtypename" type="string">Undefined</attribute>
166-
<attribute name="mappingnumber" type="int16">14</attribute>
168+
<attribute name="mappingnumber" type="int16">12</attribute>
167169
<attribute name="destinationname" type="string">ObservationImportant</attribute>
168170
<attribute name="autogenerateexpression" type="bool">1</attribute>
169171
<relationship name="mappingmodel" type="1/1" destination="XDDEVMAPPINGMODEL" idrefs="z173"></relationship>
170-
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z123 z201 z150 z156 z147"></relationship>
172+
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z201 z156 z150 z147 z123"></relationship>
171173
<relationship name="relationshipmappings" type="0/0" destination="XDDEVRELATIONSHIPMAPPING" idrefs="z202"></relationship>
172174
</object>
173175
<object type="XDDEVRELATIONSHIPMAPPING" id="z128">
@@ -269,7 +271,7 @@
269271
</object>
270272
<object type="XDDEVENTITYMAPPING" id="z151">
271273
<attribute name="mappingtypename" type="string">Undefined</attribute>
272-
<attribute name="mappingnumber" type="int16">4</attribute>
274+
<attribute name="mappingnumber" type="int16">3</attribute>
273275
<attribute name="destinationname" type="string">Role</attribute>
274276
<attribute name="autogenerateexpression" type="bool">1</attribute>
275277
<relationship name="mappingmodel" type="1/1" destination="XDDEVMAPPINGMODEL" idrefs="z173"></relationship>
@@ -288,11 +290,11 @@
288290
<object type="XDDEVENTITYMAPPING" id="z154">
289291
<attribute name="sourcename" type="string">User</attribute>
290292
<attribute name="mappingtypename" type="string">Undefined</attribute>
291-
<attribute name="mappingnumber" type="int16">11</attribute>
293+
<attribute name="mappingnumber" type="int16">9</attribute>
292294
<attribute name="destinationname" type="string">User</attribute>
293295
<attribute name="autogenerateexpression" type="bool">1</attribute>
294296
<relationship name="mappingmodel" type="1/1" destination="XDDEVMAPPINGMODEL" idrefs="z173"></relationship>
295-
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z204 z157 z113 z129 z130 z104 z131 z175 z195 z148"></relationship>
297+
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z175 z104 z113 z131 z195 z148 z129 z157 z204 z130"></relationship>
296298
<relationship name="relationshipmappings" type="0/0" destination="XDDEVRELATIONSHIPMAPPING"></relationship>
297299
</object>
298300
<object type="XDDEVATTRIBUTEMAPPING" id="z155">
@@ -414,7 +416,7 @@ cBIAAYagrxEKFAAHAAgAFwAzADQANQBXAFgAWQBaAFsAXABdAF4AXwBgAGEAYgBjAGQAZQCAAIEAggCI
414416
</object>
415417
<object type="XDDEVENTITYMAPPING" id="z180">
416418
<attribute name="mappingtypename" type="string">Undefined</attribute>
417-
<attribute name="mappingnumber" type="int16">5</attribute>
419+
<attribute name="mappingnumber" type="int16">4</attribute>
418420
<attribute name="destinationname" type="string">Canary</attribute>
419421
<attribute name="autogenerateexpression" type="bool">1</attribute>
420422
<relationship name="mappingmodel" type="1/1" destination="XDDEVMAPPINGMODEL" idrefs="z173"></relationship>
@@ -439,11 +441,11 @@ cBIAAYagrxEKFAAHAAgAFwAzADQANQBXAFgAWQBaAFsAXABdAF4AXwBgAGEAYgBjAGQAZQCAAIEAggCI
439441
</object>
440442
<object type="XDDEVENTITYMAPPING" id="z185">
441443
<attribute name="mappingtypename" type="string">Undefined</attribute>
442-
<attribute name="mappingnumber" type="int16">2</attribute>
444+
<attribute name="mappingnumber" type="int16">1</attribute>
443445
<attribute name="destinationname" type="string">Team</attribute>
444446
<attribute name="autogenerateexpression" type="bool">1</attribute>
445447
<relationship name="mappingmodel" type="1/1" destination="XDDEVMAPPINGMODEL" idrefs="z173"></relationship>
446-
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z141 z136 z134"></relationship>
448+
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z134 z141 z136"></relationship>
447449
<relationship name="relationshipmappings" type="0/0" destination="XDDEVRELATIONSHIPMAPPING" idrefs="z158 z128"></relationship>
448450
</object>
449451
<object type="XDDEVATTRIBUTEMAPPING" id="z186">
@@ -470,22 +472,22 @@ cBIAAYagrxEKFAAHAAgAFwAzADQANQBXAFgAWQBaAFsAXABdAF4AXwBgAGEAYgBjAGQAZQCAAIEAggCI
470472
</object>
471473
<object type="XDDEVENTITYMAPPING" id="z190">
472474
<attribute name="mappingtypename" type="string">Undefined</attribute>
473-
<attribute name="mappingnumber" type="int16">13</attribute>
475+
<attribute name="mappingnumber" type="int16">11</attribute>
474476
<attribute name="destinationname" type="string">Event</attribute>
475477
<attribute name="autogenerateexpression" type="bool">1</attribute>
476478
<relationship name="mappingmodel" type="1/1" destination="XDDEVMAPPINGMODEL" idrefs="z173"></relationship>
477-
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z167 z172 z214 z121 z102 z149"></relationship>
479+
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z167 z121 z102 z172 z214 z149"></relationship>
478480
<relationship name="relationshipmappings" type="0/0" destination="XDDEVRELATIONSHIPMAPPING" idrefs="z119"></relationship>
479481
</object>
480482
<object type="XDDEVENTITYMAPPING" id="z191">
481483
<attribute name="sourcename" type="string">Observation</attribute>
482484
<attribute name="mappingtypename" type="string">Undefined</attribute>
483-
<attribute name="mappingnumber" type="int16">7</attribute>
485+
<attribute name="mappingnumber" type="int16">6</attribute>
484486
<attribute name="destinationname" type="string">Observation</attribute>
485487
<attribute name="autogenerateexpression" type="bool">1</attribute>
486488
<relationship name="mappingmodel" type="1/1" destination="XDDEVMAPPINGMODEL" idrefs="z173"></relationship>
487-
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z209 z162 z140 z205 z143 z177 z197 z139 z183 z159 z155 z152"></relationship>
488-
<relationship name="relationshipmappings" type="0/0" destination="XDDEVRELATIONSHIPMAPPING" idrefs="z142 z179 z206 z178"></relationship>
489+
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z159 z183 z139 z155 z177 z143 z162 z209 z140 z152 z197 z205"></relationship>
490+
<relationship name="relationshipmappings" type="0/0" destination="XDDEVRELATIONSHIPMAPPING" idrefs="z179 z206 z142 z178"></relationship>
489491
</object>
490492
<object type="XDDEVATTRIBUTEMAPPING" id="z192">
491493
<attribute name="name" type="string">url</attribute>
@@ -568,11 +570,11 @@ cBIAAYagrxEKFAAHAAgAFwAzADQANQBXAFgAWQBaAFsAXABdAF4AXwBgAGEAYgBjAGQAZQCAAIEAggCI
568570
<object type="XDDEVENTITYMAPPING" id="z211">
569571
<attribute name="sourcename" type="string">Layer</attribute>
570572
<attribute name="mappingtypename" type="string">Undefined</attribute>
571-
<attribute name="mappingnumber" type="int16">3</attribute>
573+
<attribute name="mappingnumber" type="int16">2</attribute>
572574
<attribute name="destinationname" type="string">Layer</attribute>
573575
<attribute name="autogenerateexpression" type="bool">1</attribute>
574576
<relationship name="mappingmodel" type="1/1" destination="XDDEVMAPPINGMODEL" idrefs="z173"></relationship>
575-
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z120 z171 z169 z124 z135 z208 z103 z107 z144 z164"></relationship>
577+
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z164 z124 z171 z107 z135 z144 z103 z169 z208 z120"></relationship>
576578
<relationship name="relationshipmappings" type="0/0" destination="XDDEVRELATIONSHIPMAPPING"></relationship>
577579
</object>
578580
<object type="XDDEVATTRIBUTEMAPPING" id="z212">
@@ -594,11 +596,11 @@ cBIAAYagrxEKFAAHAAgAFwAzADQANQBXAFgAWQBaAFsAXABdAF4AXwBgAGEAYgBjAGQAZQCAAIEAggCI
594596
<object type="XDDEVENTITYMAPPING" id="z216">
595597
<attribute name="sourcename" type="string">Attachment</attribute>
596598
<attribute name="mappingtypename" type="string">Undefined</attribute>
597-
<attribute name="mappingnumber" type="int16">9</attribute>
599+
<attribute name="mappingnumber" type="int16">7</attribute>
598600
<attribute name="destinationname" type="string">Attachment</attribute>
599601
<attribute name="autogenerateexpression" type="bool">1</attribute>
600602
<relationship name="mappingmodel" type="1/1" destination="XDDEVMAPPINGMODEL" idrefs="z173"></relationship>
601-
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z187 z109 z126 z114 z110 z168 z184 z193 z200 z213 z163 z198"></relationship>
603+
<relationship name="attributemappings" type="0/0" destination="XDDEVATTRIBUTEMAPPING" idrefs="z168 z198 z110 z193 z184 z213 z114 z187 z200 z109 z163 z126"></relationship>
602604
<relationship name="relationshipmappings" type="0/0" destination="XDDEVRELATIONSHIPMAPPING" idrefs="z146"></relationship>
603605
</object>
604606
<object type="XDDEVRELATIONSHIPMAPPING" id="z217">

0 commit comments

Comments
 (0)