Skip to content

Commit 00d452f

Browse files
committed
Fix mergeableIngress typo
1 parent 6051d2b commit 00d452f

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

nginx-controller/controller/controller.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -679,7 +679,7 @@ func (lbc *LoadBalancerController) syncIng(task Task) {
679679
}
680680
return
681681
}
682-
err = lbc.cnf.AddOrUpdateMergableIngress(mergeableIngExs)
682+
err = lbc.cnf.AddOrUpdateMergeableIngress(mergeableIngExs)
683683
if err != nil {
684684
lbc.recorder.Eventf(ing, api_v1.EventTypeWarning, "AddedOrUpdatedWithError", "Configuration for %v(Master) was added or updated, but not applied: %v", key, err)
685685
for _, minion := range mergeableIngExs.Minions {
@@ -804,7 +804,7 @@ func (lbc *LoadBalancerController) syncSecret(task Task) {
804804
glog.Errorf("Ignoring Ingress %v(Minion): %v", minion.Name, err)
805805
continue
806806
}
807-
err = lbc.cnf.AddOrUpdateMergableIngress(mergeableIngress)
807+
err = lbc.cnf.AddOrUpdateMergeableIngress(mergeableIngress)
808808
if err != nil {
809809
glog.Errorf("Failed to update Ingress %v(Master) of %v(Minion): %v", master.Name, minion.Name, err)
810810
}
@@ -864,7 +864,7 @@ func (lbc *LoadBalancerController) syncSecret(task Task) {
864864
glog.Errorf("Ignoring Ingress %v(Minion): %v", minion.Name, err)
865865
continue
866866
}
867-
err = lbc.cnf.AddOrUpdateMergableIngress(mergeableIngress)
867+
err = lbc.cnf.AddOrUpdateMergeableIngress(mergeableIngress)
868868
if err != nil {
869869
glog.Errorf("Failed to update Ingress %v(Master) of %v(Minion): %v", master.Name, minion.Name, err)
870870
}

nginx-controller/nginx/configurator.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ func (cnf *Configurator) addOrUpdateIngress(ingEx *IngressEx) error {
8080
return nil
8181
}
8282

83-
// AddOrUpdateMergableIngress adds or updates NGINX configuration for the Ingress resources with Mergeable Types
84-
func (cnf *Configurator) AddOrUpdateMergableIngress(mergeableIngs *MergeableIngresses) error {
83+
// AddOrUpdateMergeableIngress adds or updates NGINX configuration for the Ingress resources with Mergeable Types
84+
func (cnf *Configurator) AddOrUpdateMergeableIngress(mergeableIngs *MergeableIngresses) error {
8585
if err := cnf.addOrUpdateMergeableIngress(mergeableIngs); err != nil {
8686
return fmt.Errorf("Error when adding or updating ingress %v/%v: %v", mergeableIngs.Master.Ingress.Namespace, mergeableIngs.Master.Ingress.Name, err)
8787
}

nginx-controller/nginx/configurator_test.go

+9-9
Original file line numberDiff line numberDiff line change
@@ -668,20 +668,20 @@ func TestAddOrUpdateIngress(t *testing.T) {
668668
}
669669
}
670670

671-
func TestAddOrUpdateMergableIngress(t *testing.T) {
671+
func TestAddOrUpdateMergeableIngress(t *testing.T) {
672672
cnf, err := createTestConfigurator()
673673
if err != nil {
674674
t.Errorf("Failed to create a test configurator: %v", err)
675675
}
676676
mergeableIngess := createMergeableCafeIngress()
677-
err = cnf.AddOrUpdateMergableIngress(mergeableIngess)
677+
err = cnf.AddOrUpdateMergeableIngress(mergeableIngess)
678678
if err != nil {
679-
t.Errorf("AddOrUpdateMergableIngress returned \n%v, expected \n%v", err, nil)
679+
t.Errorf("AddOrUpdateMergeableIngress returned \n%v, expected \n%v", err, nil)
680680
}
681681

682-
cnfHasMergableIngress := cnf.HasIngress(mergeableIngess.Master.Ingress)
683-
if !cnfHasMergableIngress {
684-
t.Errorf("AddOrUpdateMergableIngress didn't add mergable ingress successfully. HasIngress returned %v, expected %v", cnfHasMergableIngress, true)
682+
cnfHasMergeableIngress := cnf.HasIngress(mergeableIngess.Master.Ingress)
683+
if !cnfHasMergeableIngress {
684+
t.Errorf("AddOrUpdateMergeableIngress didn't add mergeable ingress successfully. HasIngress returned %v, expected %v", cnfHasMergeableIngress, true)
685685
}
686686
}
687687

@@ -698,16 +698,16 @@ func TestAddOrUpdateIngressFailsWithInvalidIngressTemplate(t *testing.T) {
698698
}
699699
}
700700

701-
func TestAddOrUpdateMergableIngressFailsWithInvalidIngressTemplate(t *testing.T) {
701+
func TestAddOrUpdateMergeableIngressFailsWithInvalidIngressTemplate(t *testing.T) {
702702
cnf, err := createTestConfiguratorInvalidIngressTemplate()
703703
if err != nil {
704704
t.Errorf("Failed to create a test configurator: %v", err)
705705
}
706706

707707
mergeableIngess := createMergeableCafeIngress()
708-
err = cnf.AddOrUpdateMergableIngress(mergeableIngess)
708+
err = cnf.AddOrUpdateMergeableIngress(mergeableIngess)
709709
if err == nil {
710-
t.Errorf("AddOrUpdateMergableIngress returned \n%v, but expected \n%v", nil, "template execution error")
710+
t.Errorf("AddOrUpdateMergeableIngress returned \n%v, but expected \n%v", nil, "template execution error")
711711
}
712712
}
713713

0 commit comments

Comments
 (0)