Allow extra labels to be specified for Service resource in helm chart

[michasHL]

I would like to start a discussion to see if a change to the helm chart could be implemented to allow setting extra labels on the created service k8s resource.
We're monitoring our services with prometheus and use servicemonitors that match specific services on a label.

Currently the service resource only gets some standard labels attached that are created in the tpl file.

[bjee19]

Hey @michasHL,

Thanks for opening this discussion! It seems like allowing extra labels to be specified for Services is quite popular as there was already another PR opened to allow for this #3294. However we decided to hold off on it for now because of an upcoming architecture change which will be completed in our 2.0 release sometime end of may. Here's a quote as to why the PR was closed:

We're going to hold off on this change right now because our architecture is changing in our next release (2.0) and there will be a different way to specify labels on the Service.

The control plane will provision an nginx data plane (including a Service) when you create your Gateway object (instead of the current architecture of a shared Pod between the control/data planes). On the Gateway object, you'll be able to set the infrastructure.labels field to propagate any labels to the nginx Service/Deployment objects that are provisioned. We'll have documentation around this as well.

So if I'm understanding your needs, I think this is due to be implemented soon!