Skip to content
This repository was archived by the owner on May 24, 2023. It is now read-only.

Commit 3645c11

Browse files
committed
Improve doc for spec.reportIngressStatus
1 parent 460b2b2 commit 3645c11

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

deploy/crds/k8s.nginx.org_nginxingresscontrollers_crd.yaml

+5-3
Original file line numberDiff line numberDiff line change
@@ -208,15 +208,17 @@ spec:
208208
description: 'Specifies the name of the service with the type LoadBalancer
209209
through which the Ingress controller pods are exposed externally.
210210
The external address of the service is used when reporting the
211-
status of Ingress resources. Note: Only if serviceType is NodePort.'
211+
status of Ingress resources. Note: if serviceType is LoadBalancer,
212+
the value of this field will be ignored, and the operator will
213+
use the name of the created LoadBalancer service instead.'
212214
type: string
213215
ingressLink:
214216
description: 'Specifies the name of the IngressLink resource, which
215217
exposes the Ingress Controller pods via a BIG-IP system. The IP
216218
of the BIG-IP system is used when reporting the status of Ingress,
217219
VirtualServer and VirtualServerRoute resources. Requires reportIngressStatus.enable
218-
set to true. Note: Only if serviceType is NodePort and reportIngressStatus.externalService
219-
is not set.'
220+
set to true. Note: If serviceType is LoadBalancer or reportIngressStatus.externalService
221+
is set, the value of this field will be ignored.'
220222
type: string
221223
required:
222224
- enable

docs/nginx-ingress-controller.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,8 @@ spec:
138138
| Field | Type | Description | Required |
139139
| --- | --- | --- | --- |
140140
| `enable` | `boolean` | Enable reporting of the Ingress status. | Yes |
141-
| `externalService` | `string` | Specifies the name of the service with the type LoadBalancer through which the Ingress controller pods are exposed externally. The external address of the service is used when reporting the status of Ingress resources. Note: Only if ServiceType is `NodePort`. | No |
142-
| `ingressLink` | `string` | Specifies the name of the IngressLink resource, which exposes the Ingress Controller pods via a BIG-IP system. The IP of the BIG-IP system is used when reporting the status of Ingress, VirtualServer and VirtualServerRoute resources. Requires `reportIngressStatus.enable` set to `true`. Note: Only if ServiceType is `NodePort` and externalService is not set. | No |
141+
| `externalService` | `string` | Specifies the name of the service with the type LoadBalancer through which the Ingress controller pods are exposed externally. The external address of the service is used when reporting the status of Ingress resources. Note: if `serviceType` is `LoadBalancer`, the value of this field will be ignored, and the operator will use the name of the created LoadBalancer service instead. | No |
142+
| `ingressLink` | `string` | Specifies the name of the IngressLink resource, which exposes the Ingress Controller pods via a BIG-IP system. The IP of the BIG-IP system is used when reporting the status of Ingress, VirtualServer and VirtualServerRoute resources. Requires `reportIngressStatus.enable` set to `true`. Note: If `serviceType` is `LoadBalancer` or `reportIngressStatus.externalService` is set, the value of this field will be ignored. | No |
143143

144144
## NginxIngressController.Prometheus
145145

pkg/apis/k8s/v1alpha1/nginxingresscontroller_types.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -191,13 +191,14 @@ type ReportIngressStatus struct {
191191
Enable bool `json:"enable"`
192192
// Specifies the name of the service with the type LoadBalancer through which the Ingress controller pods are exposed externally.
193193
// The external address of the service is used when reporting the status of Ingress resources.
194-
// Note: Only if serviceType is NodePort.
194+
// Note: if serviceType is LoadBalancer, the value of this field will be ignored, and the operator will use the name of the created LoadBalancer service instead.
195195
// +kubebuilder:validation:Optional
196196
ExternalService string `json:"externalService"`
197197
// Specifies the name of the IngressLink resource, which exposes the Ingress Controller pods via a BIG-IP system.
198198
// The IP of the BIG-IP system is used when reporting the status of Ingress, VirtualServer and VirtualServerRoute resources.
199199
// Requires reportIngressStatus.enable set to true.
200-
// Note: Only if serviceType is NodePort and reportIngressStatus.externalService is not set.
200+
// Note: If serviceType is LoadBalancer or reportIngressStatus.externalService is set, the value of this field
201+
// will be ignored.
201202
// +kubebuilder:validation:Optional
202203
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true
203204
IngressLink string `json:"ingressLink,omitempty"`

0 commit comments

Comments
 (0)