Skip to content
This repository was archived by the owner on May 24, 2023. It is now read-only.

Commit 51ecbaa

Browse files
committed
Improve doc for spec.reportIngressStatus
1 parent 0b07a30 commit 51ecbaa

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

deploy/crds/k8s.nginx.org_nginxingresscontrollers_crd.yaml

+5-3
Original file line numberDiff line numberDiff line change
@@ -209,15 +209,17 @@ spec:
209209
description: 'Specifies the name of the service with the type LoadBalancer
210210
through which the Ingress controller pods are exposed externally.
211211
The external address of the service is used when reporting the
212-
status of Ingress resources. Note: Only if serviceType is NodePort.'
212+
status of Ingress resources. Note: if serviceType is LoadBalancer,
213+
the value of this field will be ignored, and the operator will
214+
use the name of the created LoadBalancer service instead.'
213215
type: string
214216
ingressLink:
215217
description: 'Specifies the name of the IngressLink resource, which
216218
exposes the Ingress Controller pods via a BIG-IP system. The IP
217219
of the BIG-IP system is used when reporting the status of Ingress,
218220
VirtualServer and VirtualServerRoute resources. Requires reportIngressStatus.enable
219-
set to true. Note: Only if serviceType is NodePort and reportIngressStatus.externalService
220-
is not set.'
221+
set to true. Note: If serviceType is LoadBalancer or reportIngressStatus.externalService
222+
is set, the value of this field will be ignored.'
221223
type: string
222224
required:
223225
- enable

docs/nginx-ingress-controller.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,8 @@ spec:
138138
| Field | Type | Description | Required |
139139
| --- | --- | --- | --- |
140140
| `enable` | `boolean` | Enable reporting of the Ingress status. | Yes |
141-
| `externalService` | `string` | Specifies the name of the service with the type LoadBalancer through which the Ingress controller pods are exposed externally. The external address of the service is used when reporting the status of Ingress resources. Note: Only if ServiceType is `NodePort`. | No |
142-
| `ingressLink` | `string` | Specifies the name of the IngressLink resource, which exposes the Ingress Controller pods via a BIG-IP system. The IP of the BIG-IP system is used when reporting the status of Ingress, VirtualServer and VirtualServerRoute resources. Requires `reportIngressStatus.enable` set to `true`. Note: Only if ServiceType is `NodePort` and externalService is not set. | No |
141+
| `externalService` | `string` | Specifies the name of the service with the type LoadBalancer through which the Ingress controller pods are exposed externally. The external address of the service is used when reporting the status of Ingress resources. Note: if `serviceType` is `LoadBalancer`, the value of this field will be ignored, and the operator will use the name of the created LoadBalancer service instead. | No |
142+
| `ingressLink` | `string` | Specifies the name of the IngressLink resource, which exposes the Ingress Controller pods via a BIG-IP system. The IP of the BIG-IP system is used when reporting the status of Ingress, VirtualServer and VirtualServerRoute resources. Requires `reportIngressStatus.enable` set to `true`. Note: If `serviceType` is `LoadBalancer` or `reportIngressStatus.externalService` is set, the value of this field will be ignored. | No |
143143

144144
## NginxIngressController.Prometheus
145145

pkg/apis/k8s/v1alpha1/nginxingresscontroller_types.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -192,13 +192,14 @@ type ReportIngressStatus struct {
192192
Enable bool `json:"enable"`
193193
// Specifies the name of the service with the type LoadBalancer through which the Ingress controller pods are exposed externally.
194194
// The external address of the service is used when reporting the status of Ingress resources.
195-
// Note: Only if serviceType is NodePort.
195+
// Note: if serviceType is LoadBalancer, the value of this field will be ignored, and the operator will use the name of the created LoadBalancer service instead.
196196
// +kubebuilder:validation:Optional
197197
ExternalService string `json:"externalService"`
198198
// Specifies the name of the IngressLink resource, which exposes the Ingress Controller pods via a BIG-IP system.
199199
// The IP of the BIG-IP system is used when reporting the status of Ingress, VirtualServer and VirtualServerRoute resources.
200200
// Requires reportIngressStatus.enable set to true.
201-
// Note: Only if serviceType is NodePort and reportIngressStatus.externalService is not set.
201+
// Note: If serviceType is LoadBalancer or reportIngressStatus.externalService is set, the value of this field
202+
// will be ignored.
202203
// +kubebuilder:validation:Optional
203204
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true
204205
IngressLink string `json:"ingressLink,omitempty"`

0 commit comments

Comments
 (0)