Skip to content
This repository was archived by the owner on May 24, 2023. It is now read-only.

Commit 6014c0f

Browse files
committed
PR feedback
1 parent dd6d115 commit 6014c0f

File tree

2 files changed

+22
-27
lines changed

2 files changed

+22
-27
lines changed

CHANGELOG.md

+18-23
Original file line numberDiff line numberDiff line change
@@ -4,32 +4,24 @@
44

55
Features
66

7-
* Add IngressLink support (#58) @Dean-Coakley
8-
* Add AppProtect User Defined Signatures support (#55) @Dean-Coakley
9-
* Graduate Policies. Add enablePreviewPolicy flag support. (#56) @Dean-Coakley
10-
* Update secret type of default secret to TLS (#39) @pleshakov
7+
* [58](https://github.com/nginxinc/nginx-ingress-operator/pull/58) Add IngressLink support.
8+
* [56](https://github.com/nginxinc/nginx-ingress-operator/pull/56) Graduate Policies. Add enablePreviewPolicy flag support.
9+
* [55](https://github.com/nginxinc/nginx-ingress-operator/pull/55) Add AppProtect User Defined Signatures support.
10+
* [39](https://github.com/nginxinc/nginx-ingress-operator/pull/39) Update secret type of default secret to TLS.
1111

1212
Bug Fixes
1313

14-
* Fix replicas and service to be optional fields (#71) @Dean-Coakley
15-
* Make enableCRDs optional (#70) @Dean-Coakley
16-
* Fix Service to be an optional field. Add support for updating ExtraLabels. (#66) @Dean-Coakley
17-
* Fix SCC resource to only affect KIC pods (#65) @Dean-Coakley
14+
* [71](https://github.com/nginxinc/nginx-ingress-operator/pull/71) Fix replicas and service to be optional fields.
15+
* [70](https://github.com/nginxinc/nginx-ingress-operator/pull/70) Make enableCRDs optional.
16+
* [66](https://github.com/nginxinc/nginx-ingress-operator/pull/66) Fix Service to be an optional field. Add support for updating ExtraLabels.
17+
* [65](https://github.com/nginxinc/nginx-ingress-operator/pull/65) Fix SCC resource to only affect KIC pods.
1818

1919
Documentation
2020

21-
* Update IC compatibility in changelog (#54) @pleshakov
21+
* [54](https://github.com/nginxinc/nginx-ingress-operator/pull/54) Update IC compatibility in changelog.
2222

23-
Maintenance
24-
25-
* Bump golangci/golangci-lint-action from v2.4.0 to v2.5.1 (#67) @dependabot
26-
* Add release-drafter (#64) @lucacome
27-
* Change dependabot interval to weekly (#63) @lucacome
28-
* Bump actions/cache from v2 to v2.1.4 (#53) @dependabot
29-
* Bump golangci/golangci-lint-action from v2 to v2.4.0 (#59) @dependabot
30-
* Bump github.com/google/go-cmp from 0.4.0 to 0.5.4 (#49) @dependabot
31-
* Add dependabot (#45) @lucacome
32-
* Update CRDs, CSVs and Makefile (#36) @lucacome
23+
KNOWN ISSUES:
24+
* The Operator doesn't automatically remove IngressClasses created by [29](https://github.com/nginxinc/nginx-ingress-operator/pull/29).
3325

3426
Compatibility
3527

@@ -38,11 +30,14 @@ Compatibility
3830

3931
Upgrade Instructions
4032

41-
1. Remove existing policy CRD: `kubectl delete crds policies.k8s.nginx.org`
33+
1. Remove the existing Policy CRD: `kubectl delete crd policies.k8s.nginx.org`
4234
**Please note that deletion of the policies.k8s.nginx.org CRD will result in all instances of that CRD being deleted too. Ensure to back up any important Custom Resource instances first!**
43-
2. Delete existing SCC: `kubectl delete scc nginx-ingress-scc`
44-
3. Deploy new operator.
45-
4. Update any existing instances of the nginxingresscontrollers.k8s.nginx.org Custom Resource to use a KIC 1.10 image.
35+
2. Delete the existing SCC: `kubectl delete scc nginx-ingress-scc`
36+
3. Upgrade the operator to version 0.1.0.
37+
4. Update any existing instances of the nginxingresscontrollers.k8s.nginx.org Custom Resource to use an NGINX Ingress Controller 1.10.x image.
38+
39+
Updating the secrets in KIC:
40+
Version 1.10.0 of the Ingress Controller added a requirement for secrets to be one of the following types: kubernetes.io/tls for TLS secrets; nginx.org/jwk for JWK secrets; or nginx.org/ca for CA secrets. The Ingress Controller now ignores secrets that are not one of these supported types. Before upgrading, please ensure that the secrets referenced in Ingress, VirtualServer or Policies resources are of a supported type, which is configured via the type field. Please see https://docs.nginx.com/nginx-ingress-controller/releases/#nginx-ingress-controller-1-10-0 for more details.
4641

4742
### 0.0.7
4843

README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ The following table shows the relation between the versions of the two projects:
1212

1313
| NGINX Ingress Controller | NGINX Ingress Operator |
1414
| --- | --- |
15-
| < 1.7.0 | N/A |
16-
| 1.7.x | 0.0.4 |
17-
| 1.8.x | 0.0.6 |
18-
| 1.9.x | 0.0.7 |
1915
| 1.10.x | 0.1.0 |
16+
| 1.9.x | 0.0.7 |
17+
| 1.8.x | 0.0.6 |
18+
| 1.7.x | 0.0.4 |
19+
| < 1.7.0 | N/A |
2020

2121
Note: The NGINX Ingress Operator works only for NGINX Ingress Controller versions after `1.7.0`.
2222

0 commit comments

Comments
 (0)