Add more linters

Author: lucacome

.github/workflows/lint.yml

@@ -29,6 +29,6 @@ jobs:
       - name: Checkout Repository
         uses: actions/checkout@v2
       - name: Lint Code
-        uses: golangci/golangci-lint-action@v2.5.2
+        uses: golangci/golangci-lint-action@v2
         with:
           args: --timeout ${{ env.GOLANGCI_TIMEOUT }}

.golangci.yml

@@ -4,13 +4,31 @@ linters-settings:
 
 linters:
     enable:
+    - asciicheck
+    - deadcode
+    - errcheck
+    - errorlint
+    - gofmt
+    - gofumpt
     - goimports
+    - gosec
     - gosimple
     - govet
+    - ineffassign
+    - makezero
     - misspell
-    - gofmt
-    - unparam
-    - unconvert
+    - nilerr
+    - noctx
+    - predeclared
+    - staticcheck
     - structcheck
-    - errcheck
+    - typecheck
+    - unconvert
+    - unparam
+    - unused
+    - varcheck
+    - wastedassign
     disable-all: true
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0

Makefile

@@ -85,6 +85,10 @@ fmt: ## Run go fmt against code.
 vet: ## Run go vet against code.
 	go vet ./...
 
+lint: ## Run golangci-lint against code.
+	docker run --pull always --rm -v $(shell pwd):/nginx-ingress-operator -w /nginx-ingress-operator -v $(shell go env GOCACHE):/cache/go -e GOCACHE=/cache/go -e GOLANGCI_LINT_CACHE=/cache/go -v $(shell go env GOPATH)/pkg:/go/pkg golangci/golangci-lint:latest golangci-lint --color always run
+
+
 ENVTEST_ASSETS_DIR=$(shell pwd)/testbin
 test: manifests generate fmt vet ## Run tests.
 	mkdir -p ${ENVTEST_ASSETS_DIR}