Skip to content

Commit f19d40d

Browse files
authored
Fix duplicate join for collection (#2890)
1 parent d3f1323 commit f19d40d

File tree

3 files changed

+1
-4
lines changed

3 files changed

+1
-4
lines changed

src/NHibernate.Test/Async/NHSpecificTest/GH1962/Fixture.cs

-2
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,9 @@ namespace NHibernate.Test.NHSpecificTest.GH1962
1919
public class FixtureAsync : BugTestCase
2020
{
2121
[Test]
22-
[KnownBug("#1962")]
2322
public async Task LinqShouldBeValidAsync()
2423
{
2524
using (var session = OpenSession())
26-
using (session.BeginTransaction())
2725
{
2826
var result =
2927
await (session

src/NHibernate.Test/NHSpecificTest/GH1962/Fixture.cs

-2
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,9 @@ namespace NHibernate.Test.NHSpecificTest.GH1962
77
public class Fixture : BugTestCase
88
{
99
[Test]
10-
[KnownBug("#1962")]
1110
public void LinqShouldBeValid()
1211
{
1312
using (var session = OpenSession())
14-
using (session.BeginTransaction())
1513
{
1614
var result =
1715
session

src/NHibernate/Hql/Ast/ANTLR/Tree/FromElementFactory.cs

+1
Original file line numberDiff line numberDiff line change
@@ -362,6 +362,7 @@ private FromElement CreateEntityAssociation(
362362
_fromClause.Walker.AddQuerySpaces(_queryableCollection.CollectionSpaces);
363363
}
364364
elem.CollectionTableAlias = roleAlias;
365+
_fromClause.AddCollectionJoinFromElementByPath(_path, elem);
365366
return elem;
366367
}
367368

0 commit comments

Comments
 (0)