You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When burn is called on the last token, code in removeNFToken will not clear idToOwnerIndex for it.
Order of these statements should be changed, but even better to use check for last token mentioned in previous issue #104.
The text was updated successfully, but these errors were encountered:
mg6maciej
changed the title
[bug] Resetting of value no non-zero when burning last token
[bug] Resetting of value to non-zero when burning last token
Jun 24, 2018
I'm kind of not sure which approach would be better here.
I would change the order because it is unlikely that an event of burning all the tokens happens often if at all so the check mentioned it #104 would consume more gas overall.
But on the other hand if there would be contract that constantly burns all the tokens the gas price will be much higher for it.
When burn is called on the last token, code in
removeNFToken
will not clearidToOwnerIndex
for it.Order of these statements should be changed, but even better to use check for last token mentioned in previous issue #104.
The text was updated successfully, but these errors were encountered: