Skip to content

Commit 1cf4cc0

Browse files
committed
Apply clang-tidy fixes for readability-identifier-naming in TestBytecodeCallbacks.cpp (NFC)
1 parent 3029acb commit 1cf4cc0

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

mlir/test/lib/IR/TestBytecodeRoundtrip.cpp

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,17 @@ using namespace llvm;
2424
namespace {
2525
class TestDialectVersionParser : public cl::parser<test::TestDialectVersion> {
2626
public:
27-
TestDialectVersionParser(cl::Option &O)
28-
: cl::parser<test::TestDialectVersion>(O) {}
27+
TestDialectVersionParser(cl::Option &o)
28+
: cl::parser<test::TestDialectVersion>(o) {}
2929

30-
bool parse(cl::Option &O, StringRef /*argName*/, StringRef arg,
30+
bool parse(cl::Option &o, StringRef /*argName*/, StringRef arg,
3131
test::TestDialectVersion &v) {
32-
long long major_, minor_;
33-
if (getAsSignedInteger(arg.split(".").first, 10, major_))
34-
return O.error("Invalid argument '" + arg);
35-
if (getAsSignedInteger(arg.split(".").second, 10, minor_))
36-
return O.error("Invalid argument '" + arg);
37-
v = test::TestDialectVersion(major_, minor_);
32+
long long major, minor;
33+
if (getAsSignedInteger(arg.split(".").first, 10, major))
34+
return o.error("Invalid argument '" + arg);
35+
if (getAsSignedInteger(arg.split(".").second, 10, minor))
36+
return o.error("Invalid argument '" + arg);
37+
v = test::TestDialectVersion(major, minor);
3838
// Returns true on error.
3939
return false;
4040
}
@@ -182,12 +182,12 @@ struct TestBytecodeRoundtripPass
182182
if (failed(reader.readVarInt(encoding)) || encoding != 999)
183183
return success();
184184
llvm::outs() << "Overriding parsing of IntegerType encoding...\n";
185-
uint64_t _widthAndSignedness, width;
185+
uint64_t widthAndSignedness, width;
186186
IntegerType::SignednessSemantics signedness;
187-
if (succeeded(reader.readVarInt(_widthAndSignedness)) &&
188-
((width = _widthAndSignedness >> 2), true) &&
187+
if (succeeded(reader.readVarInt(widthAndSignedness)) &&
188+
((width = widthAndSignedness >> 2), true) &&
189189
((signedness = static_cast<IntegerType::SignednessSemantics>(
190-
_widthAndSignedness & 0x3)),
190+
widthAndSignedness & 0x3)),
191191
true))
192192
entry = IntegerType::get(reader.getContext(), width, signedness);
193193
// Return nullopt to fall through the rest of the parsing code path.

0 commit comments

Comments
 (0)