feat(metrics): apply styling

Author: niko-achilles

packages/metrics/src/Metrics.ts

@@ -11,7 +11,7 @@ import {
   ExtraOptions,
   MetricUnit,
   MetricUnits,
-  MetricResolution
+  MetricResolution,
 } from './types';
 
 const MAX_METRICS_SIZE = 100;
@@ -487,7 +487,12 @@ class Metrics extends Utility implements MetricsInterface {
     }
   }
 
-  private storeMetric(name: string, unit: MetricUnit, value: number, resolution?: MetricResolution): void {
+  private storeMetric(
+    name: string,
+    unit: MetricUnit,
+    value: number,
+    resolution?: MetricResolution,
+  ): void {    
     if (Object.keys(this.storedMetrics).length >= MAX_METRICS_SIZE) {
       this.publishStoredMetrics();
     }
@@ -497,7 +502,7 @@ class Metrics extends Utility implements MetricsInterface {
         unit,
         value,
         name,
-        resolution
+        resolution,      
       };
 
     } else {
@@ -511,4 +516,8 @@ class Metrics extends Utility implements MetricsInterface {
 
 }
 
-export { Metrics, MetricUnits, MetricResolution };
+export {
+  Metrics,
+  MetricUnits,
+  MetricResolution,
+};

packages/metrics/src/MetricsInterface.ts

@@ -1,6 +1,12 @@
 import { Metrics } from './Metrics';
-import { MetricUnit, MetricResolution, EmfOutput, HandlerMethodDecorator, Dimensions, MetricsOptions } from './types';
-
+import {
+  MetricUnit,
+  MetricResolution,
+  EmfOutput,
+  HandlerMethodDecorator,
+  Dimensions,
+  MetricsOptions
+} from './types';
 interface MetricsInterface {
   addDimension(name: string, value: string): void
   addDimensions(dimensions: {[key: string]: string}): void

packages/metrics/src/types/Metrics.ts

@@ -21,7 +21,11 @@ type EmfOutput = {
     CloudWatchMetrics: {
       Namespace: string
       Dimensions: [string[]]   
-      Metrics: { Name: string; Unit: MetricUnit; StorageResolution?: MetricResolution }[]
+      Metrics: {
+        Name: string
+        Unit: MetricUnit
+        StorageResolution?: MetricResolution
+      }[]    
     }[]
   }
 };

packages/metrics/tests/unit/Metrics.test.ts

@@ -565,7 +565,8 @@ describe('Class: Metrics', () => {
   });
 
   describe('Feature: Resolution of Metrics', ()=>{
-    test('Should serialized metrics in EMF format not contain StorageResolution as key if none is set',()=>{
+
+    test('serialized metrics in EMF format should not contain `StorageResolution` as key if none is set', () => {
       const metrics = new Metrics();
       metrics.addMetric('test_name', MetricUnits.Seconds, 10);
       const serializedMetrics = metrics.serializeMetrics();
@@ -575,8 +576,7 @@ describe('Class: Metrics', () => {
       expect(Object.keys(serializedMetrics._aws.CloudWatchMetrics[0].Metrics[0])).toContain('Unit');
 
     });
-
-    test('Should be StorageResolution 60 if MetricResolution is set to `Standard`',()=>{
+    test('should set StorageResolution 60 if MetricResolution is set to `Standard`', () => {
       const metrics = new Metrics();
       metrics.addMetric('test_name', MetricUnits.Seconds, 10, MetricResolution.Standard);
       const serializedMetrics = metrics.serializeMetrics();

packages/metrics/tests/unit/middleware/middy.test.ts

@@ -4,8 +4,12 @@
  * @group unit/metrics/middleware
  */
 
-import { Metrics, MetricUnits, logMetrics, MetricResolution } from '../../../../metrics/src';
-import middy from '@middy/core';
+import {
+  Metrics,
+  MetricUnits,
+  logMetrics,
+  MetricResolution
+} from '../../../../metrics/src';import middy from '@middy/core';
 import { ExtraOptions } from '../../../src/types';
 
 const consoleSpy = jest.spyOn(console, 'log').mockImplementation();
@@ -315,8 +319,9 @@ describe('Middy middleware', () => {
       );
     });
   });
-  describe('Feature: Resolution of Metrics', ()=>{
-    test('Should use metric resolution `Standard, 60` if `Standard` is set', async () => {
+  describe('Metrics resolution', () => {
+
+    test('should use metric resolution `Standard, 60` if `Standard` is set', async () => {
       // Prepare
       const metrics = new Metrics({ namespace: 'serverlessAirline', serviceName: 'orders' });
 
@@ -338,7 +343,11 @@ describe('Middy middleware', () => {
               {
                 Namespace: 'serverlessAirline',
                 Dimensions: [['service']],
-                Metrics: [{ Name: 'successfulBooking', Unit: 'Count', StorageResolution: 60 }],
+                Metrics: [{
+                  Name: 'successfulBooking',
+                  Unit: 'Count',
+                  StorageResolution: 60,
+                }],              
               },
             ],
           },
@@ -347,7 +356,8 @@ describe('Middy middleware', () => {
         })
       );
     });
-    test('Should use metric resolution `High, 1` if `High` is set', async () => {
+
+    test('should use metric resolution `High, 1` if `High` is set', async () => {
       // Prepare
       const metrics = new Metrics({ namespace: 'serverlessAirline', serviceName: 'orders' });
 
@@ -369,7 +379,11 @@ describe('Middy middleware', () => {
               {
                 Namespace: 'serverlessAirline',
                 Dimensions: [['service']],
-                Metrics: [{ Name: 'successfulBooking', Unit: 'Count', StorageResolution: 1 }],
+                Metrics: [{
+                  Name: 'successfulBooking',
+                  Unit: 'Count',
+                  StorageResolution: 1
+                }],              
               },
             ],
           },