fix: Make transformation_service_endpoint configuration optional (feast-dev#4880)

* Make transformation_service_endpoint configuration optional

Signed-off-by: Dimitris Stafylarakis <[email protected]>

* Add custom error for transformation service, implement featurestore unit tests

Signed-off-by: Dimitris Stafylarakis <[email protected]>

---------

Signed-off-by: Dimitris Stafylarakis <[email protected]>

Author: xaniasd

go/internal/feast/featurestore.go

@@ -3,6 +3,7 @@ package feast
 import (
 	"context"
 	"errors"
+<<<<<<< HEAD
 <<<<<<< HEAD
 
 	"github.com/apache/arrow/go/v17/arrow/memory"
@@ -11,6 +12,11 @@ import (
 	"fmt"
 	"github.com/apache/arrow/go/v17/arrow/memory"
 >>>>>>> 96da3d849 (feat: Update the go feature server from Expedia code repo. (#4665))
+=======
+
+	"github.com/apache/arrow/go/v17/arrow/memory"
+
+>>>>>>> 95426bd76 (fix: Make transformation_service_endpoint configuration optional (#4880))
 	//"gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"
 
 	"github.com/feast-dev/feast/go/internal/feast/model"
@@ -67,12 +73,16 @@ func NewFeatureStore(config *registry.RepoConfig, callback transformation.Transf
 	}
 
 <<<<<<< HEAD
+<<<<<<< HEAD
+=======
+>>>>>>> 95426bd76 (fix: Make transformation_service_endpoint configuration optional (#4880))
 	var transformationService *transformation.GrpcTransformationService
 	if transformationServerEndpoint, ok := config.FeatureServer["transformation_service_endpoint"]; ok {
 		// Use a scalable transformation service like Python Transformation Service.
 		// Assume the user will define the "transformation_service_endpoint" in the feature_store.yaml file
 		// under the "feature_server" section.
 		transformationService, _ = transformation.NewGrpcTransformationService(config, transformationServerEndpoint.(string))
+<<<<<<< HEAD
 	}
 =======
 	// Use a scalable transformation service like Python Transformation Service.
@@ -87,6 +97,10 @@ func NewFeatureStore(config *registry.RepoConfig, callback transformation.Transf
 	transformationService, _ := transformation.NewGrpcTransformationService(config, transformationServerEndpoint.(string))
 >>>>>>> 96da3d849 (feat: Update the go feature server from Expedia code repo. (#4665))
 
+=======
+	}
+
+>>>>>>> 95426bd76 (fix: Make transformation_service_endpoint configuration optional (#4880))
 	return &FeatureStore{
 		config:                 config,
 		registry:               registry,

go/internal/feast/featurestore_test.go

@@ -92,13 +92,17 @@ func TestNewFeatureStore(t *testing.T) {
 		},
 	}
 <<<<<<< HEAD
+<<<<<<< HEAD
+=======
+>>>>>>> 95426bd76 (fix: Make transformation_service_endpoint configuration optional (#4880))
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			got, err := NewFeatureStore(test.config, nil)
 			if test.errMessage != "" {
 				assert.Nil(t, got)
 				require.Error(t, err)
 				assert.ErrorContains(t, err, test.errMessage)
+<<<<<<< HEAD
 
 			} else {
 				require.NoError(t, err)
@@ -112,43 +116,18 @@ func TestNewFeatureStore(t *testing.T) {
 	fs, err := NewFeatureStore(&config, nil)
 	assert.Nil(t, err)
 	assert.IsType(t, &onlinestore.RedisOnlineStore{}, fs.onlineStore)
+=======
+>>>>>>> 95426bd76 (fix: Make transformation_service_endpoint configuration optional (#4880))
 
-	t.Run("valid config", func(t *testing.T) {
-		config := &registry.RepoConfig{
-			Project:  "feature_repo",
-			Registry: getRegistryPath(),
-			Provider: "local",
-			OnlineStore: map[string]interface{}{
-				"type": "redis",
-			},
-			FeatureServer: map[string]interface{}{
-				"transformation_service_endpoint": "localhost:50051",
-			},
-		}
-		fs, err := NewFeatureStore(config, nil)
-		assert.Nil(t, err)
-		assert.NotNil(t, fs)
-		assert.IsType(t, &onlinestore.RedisOnlineStore{}, fs.onlineStore)
-		assert.NotNil(t, fs.transformationService)
-	})
-
-	t.Run("missing transformation service endpoint", func(t *testing.T) {
-		config := &registry.RepoConfig{
-			Project:  "feature_repo",
-			Registry: getRegistryPath(),
-			Provider: "local",
-			OnlineStore: map[string]interface{}{
-				"type": "redis",
-			},
-		}
-		defer func() {
-			if r := recover(); r == nil {
-				t.Errorf("The code did not panic")
+			} else {
+				require.NoError(t, err)
+				assert.NotNil(t, got)
+				assert.IsType(t, test.expectOnlineStoreType, got.onlineStore)
 			}
-		}()
-		NewFeatureStore(config, nil)
-	})
+		})
+	}
 
+<<<<<<< HEAD
 	t.Run("invalid online store config", func(t *testing.T) {
 		config := &registry.RepoConfig{
 			Project:  "feature_repo",
@@ -166,6 +145,8 @@ func TestNewFeatureStore(t *testing.T) {
 		assert.Nil(t, fs)
 	})
 >>>>>>> 96da3d849 (feat: Update the go feature server from Expedia code repo. (#4665))
+=======
+>>>>>>> 95426bd76 (fix: Make transformation_service_endpoint configuration optional (#4880))
 }
 
 type MockRedis struct {