Skip to content

Update to latest load hooks API #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hpx7 opened this issue Oct 21, 2021 · 10 comments
Closed

Update to latest load hooks API #7

hpx7 opened this issue Oct 21, 2021 · 10 comments

Comments

@hpx7
Copy link

hpx7 commented Oct 21, 2021

This module doesn't seem to work in 16.12, see https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V16.md#16.12.0

@jolyndenning
Copy link

👍🏿 I had seen those upcoming changes in github threads before. Now that it's released I'll go through and update all the loaders to use the new format, and publish new major versions. If you or others have interest in helping, please do so

@hpx7
Copy link
Author

hpx7 commented Oct 31, 2021

Hey @joeldenning just wanted to check if you think you'll have time to look into this soon? No worries if not

@jolyndenning
Copy link

For projects like this I usually just do them when the inspiration strikes. I am quite busy and fairly burned out so I don't do as much open source as I used to. Could be this week or could be in a couple months

@jolyndenning
Copy link

jolyndenning commented Nov 9, 2021

Node>=16.12 is supported in 2.0.0. See https://github.com/node-loader/node-loader-core/releases/tag/v2.0.0.

I plan on working on node-loader/import-maps and node-loader/http next. Let me know if you are using other loaders and I'll try to prioritize those, too

@jolyndenning
Copy link

node-loader/http@2 now supports node 16.12: https://github.com/node-loader/node-loader-http/releases/tag/v2.0.0

@jolyndenning
Copy link

node-loader/import-maps requires no changes since it only uses the resolve hook

@jolyndenning
Copy link

node-loader/postcss@2 now supports Node 16.12. See https://github.com/node-loader/node-loader-postcss/releases/tag/v2.0.0

@jolyndenning
Copy link

node-loader/babel@2 now supports Node 16.12. See https://github.com/node-loader/node-loader-babel/releases/tag/v2.0.0

@jolyndenning
Copy link

That's all of them! So everything should now be compatible with node 16.12

@hpx7
Copy link
Author

hpx7 commented Nov 9, 2021

I upgraded and it works great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants