chore(lint): merge missing-change-version into invalid-change-version (#248)

Author: avivkeller

Diff for: src/linter/rules/index.mjs

@@ -2,7 +2,6 @@
 
 import { duplicateStabilityNodes } from './duplicate-stability-nodes.mjs';
 import { invalidChangeVersion } from './invalid-change-version.mjs';
-import { missingChangeVersion } from './missing-change-version.mjs';
 import { missingIntroducedIn } from './missing-introduced-in.mjs';
 
 /**
@@ -11,6 +10,5 @@ import { missingIntroducedIn } from './missing-introduced-in.mjs';
 export default {
   'duplicate-stability-nodes': duplicateStabilityNodes,
   'invalid-change-version': invalidChangeVersion,
-  'missing-change-version': missingChangeVersion,
   'missing-introduced-in': missingIntroducedIn,
 };

Diff for: src/linter/rules/invalid-change-version.mjs

@@ -60,10 +60,9 @@ export const invalidChangeVersion = entries =>
         .filter(isInvalid)
         .map(version => ({
           level: 'error',
-          message: LINT_MESSAGES.invalidChangeVersion.replace(
-            '{{version}}',
-            version
-          ),
+          message: version
+            ? LINT_MESSAGES.invalidChangeVersion.replace('{{version}}', version)
+            : LINT_MESSAGES.missingChangeVersion,
           location: { path: api_doc_source, position: yaml_position },
         }))
     )

Diff for: src/linter/rules/missing-change-version.mjs

@@ -7,6 +7,35 @@ import { fileURLToPath } from 'node:url';
 import { execPath } from 'node:process';
 
 describe('invalidChangeVersion', () => {
+  it('should return an empty array if all change versions are non-empty', () => {
+    const issues = invalidChangeVersion([assertEntry]);
+
+    deepEqual(issues, []);
+  });
+
+  it('should return an issue if a change version is missing', () => {
+    const issues = invalidChangeVersion([
+      {
+        ...assertEntry,
+        changes: [...assertEntry.changes, { version: undefined }],
+      },
+    ]);
+
+    deepEqual(issues, [
+      {
+        level: 'error',
+        location: {
+          path: 'doc/api/assert.md',
+          position: {
+            end: { column: 35, line: 7, offset: 137 },
+            start: { column: 1, line: 7, offset: 103 },
+          },
+        },
+        message: 'Missing version field in the API doc entry',
+      },
+    ]);
+  });
+
   it('should work with NODE_RELEASED_VERSIONS', () => {
     const result = spawnSync(
       execPath,